Re: [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console

["Laszlo Ersek" <lersek@redhat.com>]

On 7/6/23 14:30, Gerd Hoffmann wrote:
> Be consistent with pl011-based serial console setup.
> 
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b92a916f7eec..85c01351b09d 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -606,7 +606,7 @@ SetupVirtioSerial (
>      1
>    };
>  
> -  STATIC CONST VENDOR_DEVICE_PATH  TerminalNode = {
> +  STATIC VENDOR_DEVICE_PATH  TerminalNode = {
>      {
>        MESSAGING_DEVICE_PATH,
>        MSG_VENDOR_DP,
> @@ -615,7 +615,7 @@ SetupVirtioSerial (
>          (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)
>        },
>      },
> -    DEVICE_PATH_MESSAGING_VT_UTF8
> +    // copy from PcdTerminalTypeGuidBuffer
>    };
>  
>    EFI_STATUS                Status;
> @@ -634,6 +634,11 @@ SetupVirtioSerial (
>      return;
>    }
>  
> +  CopyGuid (
> +    &TerminalNode.Guid,
> +    PcdGetPtr (PcdTerminalTypeGuidBuffer)
> +    );
> +
>    DevicePath = AppendDevicePathNode (
>                   DevicePath,
>                   &SerialNode.Header

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Laszlo