From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.11296.1608741276185461655 for ; Wed, 23 Dec 2020 08:34:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=LSvHQTBR; spf=pass (domain: akeo.ie, ip: 209.85.128.49, mailfrom: pete@akeo.ie) Received: by mail-wm1-f49.google.com with SMTP id y23so6661179wmi.1 for ; Wed, 23 Dec 2020 08:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4evmcd7f95D6rrYaNavJIcf4fsS+xz9zJgtcW4whfBs=; b=LSvHQTBRSS3X0yPaSRpuFL+IHoCgcGeNXy/+6x5vX8+dcF/Lcu/+MIgIrS1FBrIgM0 gHO/YQYyCfoATNDC5KYA00KKzgSkVu3wynzAkTPRutMrivU0cmgkVuIgHyMOSvs8ewax wpALUHvJQ/fLM55UotOaZuGnftUT08qKFe71tQxhIfauLJ5bADYLbZMqJPJrc1VH9Ey0 W0bERkpHNYjVfHCvM6lS/i0OZ1PhnSLO0+C42wPK8EEgMaAQe4a0MvYC27xDChrdGcuK LWOQhf9wYCjf+Sk87L7n96xyYTapr+TvszSZIrBhQk029xXRygnLHAOsZ2yg6O1641f7 kQbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4evmcd7f95D6rrYaNavJIcf4fsS+xz9zJgtcW4whfBs=; b=dpvP/kvvGiNKOxp9QLZsDE6vRSTkU5GGscH77ZXx8JqvofivFAMv5o8cMOmvLQMAkG 0csMFf62wTyia4vEtfaD2xO46SsosgFBwWDXPxU33N/5tsdhoaR/jTNsfuxD2VAEfrS+ NPk7N9e45cIq2QOnMeyhpGv4inV6K051ezp205V5sAZlK52u+DhQ7y5U3qkLBm7mHUPA s+mdZ479a81DKvy90tnAi8LnJRIdh7dFfOb4Y1CTPbgkOM+79XoBm6jYZLvmxLRMKq3G SWEh8ZwompvPVZA6Y6ni2S2dedZvfPy4B+l+UxdeAIUrD7OFrKYYCQJeZX5eiEo9iVkG kRTQ== X-Gm-Message-State: AOAM531gfKs1xJsS1sRtFH48jSJHV29mqqFBvZ2Vw/r8M0f2A9wNGMTw Q4y2cwUWYVK5i+37XzOdHd4c1g== X-Google-Smtp-Source: ABdhPJyrn+7sM7a5hILt1X/OXbqs4qbIAaU3J1aeTkxx6tX7Qci8sIEjVcyGcu5/GffFS0pNLFrL4g== X-Received: by 2002:a1c:7e02:: with SMTP id z2mr453000wmc.173.1608741274671; Wed, 23 Dec 2020 08:34:34 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.84.133]) by smtp.googlemail.com with ESMTPSA id y2sm381363wma.6.2020.12.23.08.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 08:34:33 -0800 (PST) Subject: Re: [edk2-platform][PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> <20201220135355.12814-2-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: Date: Wed, 23 Dec 2020 16:34:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201220135355.12814-2-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.12.20 13:53, Samer El-Haj-Mahmoud wrote: > REF: https://github.com/pftf/RPi4/issues/115 > > GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. > However, the driver never draws the cursor during init. This results > in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) > to actually draw the cursor on the screen, as the logic in FlushCursor depends > on the Mode.CursorVisible state to determine if it should draw or erase > the cursor. > > Fix by changing the default CursorVisible in this driver to FALSE. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Pete Batard > Signed-off-by: Samer El-Haj-Mahmoud > Reviewed-by: Zhichao Gao > --- > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > index c042451a9b52..6b8d11d587d1 100644 > --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate = { > EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), > > 0, > > 0, > > - TRUE > > + FALSE > > }, > > (GRAPHICS_CONSOLE_MODE_DATA *) NULL, > > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL > Reviewed-by: Pete Batard Tested-by: Pete Batard (On an RPi4 platform where we had this annoyance of an unwanted cursor displaying on top of the platform logo)