public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: stephano <stephano.cetola@linux.intel.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [edk2-announce] RFC: Patch Review System Questions
Date: Wed, 14 Nov 2018 14:09:35 -0800	[thread overview]
Message-ID: <dafd484c-ea1d-de91-d608-a2a1fe6fa921@linux.intel.com> (raw)

Here are the specific questions that I am looking to answer regarding 
the different systems. Please feel free to share your thoughts on this 
thread.

Also, as mentioned earlier, if you want to head up an investigation of 
any of those products and provide us with a report, that would be much 
appreciated. This process will help us make a decision based on 
community feedback.

-Stephano
-------------

Please describe how [Phabricator/Gitlab/Gerrit/Github] fulfills the 
following feature requirements. These questions are a guide, so feel 
free to add any information you feel is pertinent. Also, screenshots or 
other examples are highly desirable. Think about how our system works 
today and use that as a reference for what you are describing (e.g. 
today we do it this way, but with [new-system] it will work like this). 
Please send responses directly to me at stephano.cetola@linux.intel.com, 
so that any attachments can be shared (our mailing list does not 
currently support attachments).

1. No Lock-In - What automated data export is available?
We want to be able to leave and take all our data with us. "Data" here 
includes: review comments, pull requests / patches (including metadata), 
old (rejected) pull requests and metadata, issue tracker entries and 
comments (if issue tracker included). This archiving should be 
automated, not something we do by hand.

2. Easy Administration - Are there any scripts or custom code required 
after initial setup? We would like to do as little customizing as possible.

3. Flexible Workflow - Can we use email patches / email review as well 
as pull requests / web UI review?**
   3a. Can we can attach review comments to specific code *and* commit 
message locations?
   3b. Are the comments faithfully translated to notification emails 
(including the locations in code the comment is addressing)?
   3c. Are old topic branches (rejected or updated pull requests) 
available even after being rejected? (i.e. are they ever deleted?)
   3d. Is plain text supported in code review comments?

**To be clear, it is acceptable if the system handles only pull requests 
and a web UI. We do require, however, a *read-only* email notification 
system that thoroughly documents our process.


                 reply	other threads:[~2018-11-14 22:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dafd484c-ea1d-de91-d608-a2a1fe6fa921@linux.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox