public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, ayushdevel1325@gmail.com
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gaibusab, Jabeena B" <jabeena.b.gaibusab@intel.com>
Subject: Re: [edk2-devel] Proposal to move Rust std work to edk2-staging
Date: Mon, 1 Aug 2022 10:49:28 -0400	[thread overview]
Message-ID: <db013ed0-6011-2de6-f58a-7080c3920d19@linux.microsoft.com> (raw)
In-Reply-To: <69796452-56d6-75e9-a884-1c13fc68f8d6@gmail.com>

Hi Ayush,

For the purposes of this work, please don't let process impede progress. 
The main purpose of moving to edk2-staging is to broaden exposure of the 
work and encourage additional collaboration. In particular, within the 
Tianocore/edk2 community.

As the author, you can choose how to best present your work to the 
communities - Rust and Tianocore.

I think it's reasonable to keep the edk2-staging repo light with 
documentation, examples, and edk2-specific changes that reference the 
Rust changes in your rust-lang/rust fork. The code in the edk2-staging 
repo should ultimately aim to transition to an edk2 PR as the edk2 
contribution from the project.

Regards,
Michael

On 7/30/2022 6:01 AM, Ayush Singh wrote:
> Hello everyone. The work on Rust std for UEFI has been progressing 
> smoothly. Running Rust tests is now possible in it's entirety. The 
> number of tests that fail is 133 (4 cause exception + 129 normal fails) 
> out of 13,212 tests. Apart from the 4 tests that cause exceptions, most 
> of the 129 other tests can be ignored since they are caused by needing 
> dynamic linking and/or stack unwinding. So I think, it is time to start 
> considering moving the project to a more appropriate repository before I 
> open a PR upstream.
> 
> 
> However, I do have some concerns regarding moving to edk2-staging:
> 
> 1. Rust development workflow does not use Mailing lists and Patches. 
> This might create friction for the purely `rustc` developers who might 
> want to submit changes and are accustomed to PRs.
> 
> 2. Rust project does not seem to care about maintaining a clean history 
> (most of the merges are performed by bots in form of roll-up merges). 
> This is much different from how edk2 projects are usually managed. The 
> reason where this becomes a problem is having to do re-bases. While Rust 
> provides strong guarantees for stability of user facing APIs, the 
> internal std APIs are constantly changing. Combine that with no 
> clean-history and the upstream PR will probably have to be re-based on 
> latest master every few weeks (and it will likely need manual 
> intervention).
> 
> 
> I am planning on getting the code base ready for upstream PR before 15th 
> August. The main things left to do is to publish new versions of 
> `compiler_builtins` and `r-efi` crates, and refactor the code and UEFI 
> documentation.
> 
> 
> Yours Sincerely
> 
> Ayush Singh
> 
> 
> 
> 
> 

      reply	other threads:[~2022-08-01 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 10:01 Proposal to move Rust std work to edk2-staging Ayush Singh
2022-08-01 14:49 ` Michael Kubacki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db013ed0-6011-2de6-f58a-7080c3920d19@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox