From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.25854.1659365370830781165 for ; Mon, 01 Aug 2022 07:49:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=mXJwAZSA; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id DD7B320FEB90; Mon, 1 Aug 2022 07:49:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DD7B320FEB90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659365370; bh=LfHLzO+Nr2dcKuIOLGu0X9RomOn4fzpSfCG8k1r7vfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mXJwAZSAkVz3v2a1XXVzYDShbukt233IeVj3wZ5CYtb3mQVV0MHNzYhKst/zq7dz0 wvHE+U+7CbbyEbg3+rs3xfCbXGHcAuG89mkyxIa5YQ/uLydn4KqHhH0eLFNboifrxu wILJ4RsbI/m0jMy8mizES+S3S5F2CIl9TGijdvqo= Message-ID: Date: Mon, 1 Aug 2022 10:49:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] Proposal to move Rust std work to edk2-staging To: devel@edk2.groups.io, ayushdevel1325@gmail.com Cc: "Kinney, Michael D" , "Gaibusab, Jabeena B" References: <69796452-56d6-75e9-a884-1c13fc68f8d6@gmail.com> From: "Michael Kubacki" In-Reply-To: <69796452-56d6-75e9-a884-1c13fc68f8d6@gmail.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayush, For the purposes of this work, please don't let process impede progress. The main purpose of moving to edk2-staging is to broaden exposure of the work and encourage additional collaboration. In particular, within the Tianocore/edk2 community. As the author, you can choose how to best present your work to the communities - Rust and Tianocore. I think it's reasonable to keep the edk2-staging repo light with documentation, examples, and edk2-specific changes that reference the Rust changes in your rust-lang/rust fork. The code in the edk2-staging repo should ultimately aim to transition to an edk2 PR as the edk2 contribution from the project. Regards, Michael On 7/30/2022 6:01 AM, Ayush Singh wrote: > Hello everyone. The work on Rust std for UEFI has been progressing > smoothly. Running Rust tests is now possible in it's entirety. The > number of tests that fail is 133 (4 cause exception + 129 normal fails) > out of 13,212 tests. Apart from the 4 tests that cause exceptions, most > of the 129 other tests can be ignored since they are caused by needing > dynamic linking and/or stack unwinding. So I think, it is time to start > considering moving the project to a more appropriate repository before I > open a PR upstream. > > > However, I do have some concerns regarding moving to edk2-staging: > > 1. Rust development workflow does not use Mailing lists and Patches. > This might create friction for the purely `rustc` developers who might > want to submit changes and are accustomed to PRs. > > 2. Rust project does not seem to care about maintaining a clean history > (most of the merges are performed by bots in form of roll-up merges). > This is much different from how edk2 projects are usually managed. The > reason where this becomes a problem is having to do re-bases. While Rust > provides strong guarantees for stability of user facing APIs, the > internal std APIs are constantly changing. Combine that with no > clean-history and the upstream PR will probably have to be re-based on > latest master every few weeks (and it will likely need manual > intervention). > > > I am planning on getting the code base ready for upstream PR before 15th > August. The main things left to do is to publish new versions of > `compiler_builtins` and `r-efi` crates, and refactor the code and UEFI > documentation. > > > Yours Sincerely > > Ayush Singh > > > > >