From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::541; helo=mail-ed1-x541.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE4F5211A2D8F for ; Fri, 14 Dec 2018 08:21:24 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id d39so5371187edb.12 for ; Fri, 14 Dec 2018 08:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eMY7C3Qcq4y4ytGec4o7dJMkSbIe/AYG7/4ze3VWeiA=; b=ZTJFIFHJ1oC+cqD2xxHiicu+cKOWQlGtvk185E3AbjbQ2kCSfer7jvxEBiIYvv18t0 PEl9jWv346fZBwMMFF3MYYBvNEQwYCyoGajOgKDqvpyfVDgdOorPBFuSkF/DoKECjmW3 Ho2qTXRgcXp1fTWfBpdwtZ8jFTTs55mwowjqrstoW1Sm8HMs5kyDtY0KSpJ8ibkkqJ6L HYpZLrXkdd/228jhF8c/w6nAq7H6XbeeP7Xnl6dwVtwYUTMQ7G1tgcRxdRi0Gu48pW8i xnPjgxJ+inXIXEh09nEJc3skjo3THCDOFl4nY0a4ap2pdXKHFG205ycIUTr5mg/pp/7t vN/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eMY7C3Qcq4y4ytGec4o7dJMkSbIe/AYG7/4ze3VWeiA=; b=I06jIg2PEhplfA9Z3Y1poW83Kra/twoI9ilMFA6bziqnge5Auj6Zrl94m1gk52i6c1 J94Rjh83tY03gaqAWYLZRpXMdeEImBKldOweGk0+0NIgitIG1Zw8QY0iqCdIU6wVz4V9 DrHC3/iWdEcRl0xsxGvry3EqOAhNwgFxBGbeVBN0OzaHYHCUlRmqM/s3JYcKirCHRNxM EFHlgQByIHokaRHwGcsZ/8yXNCd8P9diTJQdcqqke1HKGTd0LY+EYfe1HSpdHl1q3z+A BpI3g2uw6h9FmpyDPYr7mtajq0QvwOdshu8JxpvBsuciFFuWVeY59diggI8Z+xvWqsCQ QC9w== X-Gm-Message-State: AA+aEWYs3nBGDwP8dVKj8UMl5xeB+UXeXc7oUucBIwRQeceA1e+GdmxW 2LeXcHfCIp7ZV4Sobjm0M/wp6g== X-Google-Smtp-Source: AFSGD/XEgl7JAQiHx/1RPI5VLy3qix1SHyvyT7RpeBeHcenBnKe+v10049FcXGvN3+DHJ8VY6GMc9w== X-Received: by 2002:a50:90b7:: with SMTP id c52mr3615648eda.31.1544804483025; Fri, 14 Dec 2018 08:21:23 -0800 (PST) Received: from [10.0.0.101] ([84.203.59.7]) by smtp.googlemail.com with ESMTPSA id s46sm1599573edd.9.2018.12.14.08.21.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 08:21:21 -0800 (PST) To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm References: <20181210123853.4864-1-pete@akeo.ie> <20181210123853.4864-17-pete@akeo.ie> From: Pete Batard Message-ID: Date: Fri, 14 Dec 2018 16:21:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v2 edk2-platforms 16/20] Platform/Broadcom/RPi3: Add Raspberry Pi 3 Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 16:21:25 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, Thanks for the review. I will incorporate the points you raised for 8/9/13. On 2018.12.14 15:39, Ard Biesheuvel wrote: > On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Pete Batard >> --- >> Platform/Broadcom/Bcm283x/RaspberryPiPkg.dec | 63 ++ >> Platform/Broadcom/Bcm283x/RaspberryPiPkg.dsc | 636 ++++++++++++++++++++ >> Platform/Broadcom/Bcm283x/RaspberryPiPkg.fdf | 450 ++++++++++++++ >> Platform/Broadcom/Bcm283x/Readme.md | 263 ++++++++ >> 4 files changed, 1412 insertions(+) >> > > This looks fine as well. > > In general, please screen the code for the cosmetic stuff I mentioned. > I haven't looked at the SD/MMC drivers yet, and I don't have the > bandwidth (or the energy) to do a deep review of those. The NV storage > driver I will have a more careful look at, but not today - hopefully > by the end of next week, > > > I tried running PatchCheck.py but it doesn't seem to run on my system > (I have never used it in anger myself), but it should help you spot > many of the issues I brought up. I ran PatchCheck.py on every single patch sent, and made sure the script didn't report any issue. For instance, this is what PatchCheck reports on my Debian system for the 16 patches that apply to edk2-platforms: --------------------------------------------------------------------- # python /usr/src/edk2/BaseTools/Scripts/PatchCheck.py -16 Checking git commit: 4695ab7f1bc7 The commit message format passed all checks. The code passed all checks. Checking git commit: 4583a4c82bba The commit message format passed all checks. The code passed all checks. Checking git commit: 7406c575c809 The commit message format passed all checks. The code passed all checks. Checking git commit: b5ee3fe94aae The commit message format passed all checks. The code passed all checks. Checking git commit: 937845c4cc4d The commit message format passed all checks. The code passed all checks. Checking git commit: 07dae6403e5e The commit message format passed all checks. The code passed all checks. Checking git commit: cef8f008d1fa The commit message format passed all checks. The code passed all checks. Checking git commit: 5304797f8494 The commit message format passed all checks. The code passed all checks. Checking git commit: 17711dc8965d The commit message format passed all checks. The code passed all checks. Checking git commit: 83627cdc550f The commit message format passed all checks. The code passed all checks. Checking git commit: c4f87ea8987b The commit message format passed all checks. The code passed all checks. Checking git commit: ca99e77c7b95 The commit message format passed all checks. The code passed all checks. Checking git commit: eddd965e2672 The commit message format passed all checks. The code passed all checks. Checking git commit: 0893ac6d1509 The commit message format passed all checks. The code passed all checks. Checking git commit: f595d0be1e86 The commit message format passed all checks. The code passed all checks. Checking git commit: fe4b945ac743 The commit message format passed all checks. The code passed all checks. --------------------------------------------------------------------- So, it doesn't look like the script is current set to detect space before parenthesis and the other cosmetic issues you pointed out. But I'll make sure to get that fixed. I am currently looking into having the Visual Studio editor automate the process of fixing this. Note that I also found that 'git am' complained about empty newlines being present at the end of some files, so I'll fix that too. Regards, /Pete