From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DBF51A1DF6 for ; Tue, 23 Aug 2016 06:59:45 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FAF8C057FAA; Tue, 23 Aug 2016 13:59:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-95.phx2.redhat.com [10.3.116.95]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7NDxhqI019293; Tue, 23 Aug 2016 09:59:44 -0400 To: Michael Kinney , edk2-devel@ml01.01.org, "Zeng, Star" References: <1471504170-11800-1-git-send-email-michael.d.kinney@intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 23 Aug 2016 09:59:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471504170-11800-1-git-send-email-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Aug 2016 13:59:44 +0000 (UTC) Subject: Re: [Patch 0/3] Use PcdAcpiS3Enable in CpuS3DataDxe and PiSmmCpuDxeSmm X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 13:59:45 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/18/16 03:09, Michael Kinney wrote: > Update CpuS3DataDxe and PiSmmCpuDxeSmm to consume PcdAcpiS3Enable. > If this PCD is disabled, then skip the S3 related logic in modules. > Also update PiSmmCpuDxeSmm to move S3 related code to CpuS3.c. > > Star Zeng (3): > UefiCpuPkg/CpuS3DataDxe: Consume PcdAcpiS3Enable to control the code > UefiCpuPkg/PiSmmCpuDxeSmm: Move S3 related code to CpuS3.c > UefiCpuPkg/PiSmmCpuDxeSmm: Consume PcdAcpiS3Enable to control the code > > UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 5 + > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 2 + > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 381 +++++++++++++++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 324 +---------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 70 +++-- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 1 + > 6 files changed, 442 insertions(+), 341 deletions(-) > This series doesn't apply to current master (93e59f76fe50) any longer, which I think might be due to commit eadf70bdfbc1 which I requested. Anyway, I applied this series based off bd0656b5e2a57b0113d230c10866826d94301b5b (selected semi-randomly, just looking at the commit date vs. the posting date of this series), with git-am, cleanly, and then rebased it to current master. It built okay. I tested the series with OVMF, using 32-bit and 64-bit Fedora guests on Q35, SMM enabled. I tested both S3-enabled and S3-disabled QEMU command lines for both. Whenever S3 was enabled, I tested S3 suspend/resume too. I also compared the logs before/after the series. For all patches: Tested-by: Laszlo Ersek For patches #1 and #3: Reviewed-by: Laszlo Ersek For patch #2: Acked-by: Laszlo Ersek (I didn't review the code movement in patch #2 in detail, only skimmed it.) Thanks Laszlo