From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3ACBF21BADAB2 for ; Thu, 9 Aug 2018 19:05:58 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id n7-v6so3631818pgq.4 for ; Thu, 09 Aug 2018 19:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=RHo+zJH63B0IKhYUQgJB6GPBSqpyKujqlSn3Cvz3LX8=; b=JB3x0aR/+3ZFug18u/gvVE50vpAtYbOSvvTwvgLDZwJllVVgNdJ6KwJ8UtFwilP4rz 4mW5vwEN12LJzSB5Lx1nNY+tl21fiWswY498uJUA8jCcCZOa6jiu4KUA4GUiGtvXDtc9 7LugKtnoiYKZ7Y9OZi/z7xjO7c5AKjb0xFP2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=RHo+zJH63B0IKhYUQgJB6GPBSqpyKujqlSn3Cvz3LX8=; b=T2OPtbpIffwqUF5+T102nAlKnBjFtAK3Vqv2JKbu7JYOYT7CbVGR7VKzdIj+VXx/sV 9PnT5CLlr1rr/JVubqIeCmcZple3nS2V+Lo6AEhDpvWdGonN34bgw8v7xWCT8dP1yeiW UrziOhwLsQw3Pmy4P6BvGH0VzjypoE/JLn0lG7OfzIJ9/KQknWzj8XghXB9nCe0NDWYX whGVva4Rne5ukoJ+aFsxgeThDyV/ov0gREoUwIxy4ZJg+JykKy/fzcLjjV6pXs9zxeer XPIPRdvISQmvSIiYlJ6u000jUU8S5IHlRFvCvBA+zc518bI6cYKJVmV3iKVENQHNs9XZ 76tw== X-Gm-Message-State: AOUpUlFlRwhEGZy3fGsjk0fXnLZkNq5A1TeCEKYKfe24+m/i5Y2wBffV afcKVrLWiDH2Ox+q/v8FHRuAcA== X-Google-Smtp-Source: AA+uWPyG4MABM1sYwMOnrGmDco3KGin8nxFaFOhAPnT3QF52MmVS4bkKZTd490x6EZs2rQjbdqCA5A== X-Received: by 2002:a63:f657:: with SMTP id u23-v6mr4422617pgj.258.1533866757803; Thu, 09 Aug 2018 19:05:57 -0700 (PDT) Received: from [10.199.0.182] ([64.64.108.224]) by smtp.gmail.com with ESMTPSA id b62-v6sm15428663pfm.97.2018.08.09.19.05.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 19:05:57 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, ZhenYao , Heyi Guo References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-34-ming.huang@linaro.org> <20180804151432.jc45us7rfyz6bytm@bivouac.eciton.net> <20180809122738.wsqfwf7aeq3vql5g@bivouac.eciton.net> From: Ming Message-ID: Date: Fri, 10 Aug 2018 10:05:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180809122738.wsqfwf7aeq3vql5g@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 02:05:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 在 8/9/2018 8:27 PM, Leif Lindholm 写道: > On Thu, Aug 09, 2018 at 08:15:27PM +0800, Ming wrote: >> 在 8/4/2018 11:14 PM, Leif Lindholm 写道: >>> On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: >>>> From: ZhenYao >>>> >>>> When BIOS booting, the power consumption is too high, so need close >>>> some clusters clock that don't work to reduce power consumption. >>> >>> On the one hand: should this not be handled in ARM-TF? >> >> This can no be handled in TF and should be handled in Sec phase. > > OK. > Well, as long as it's in Sec phase, I guess it doesn't make too much > difference. > >>> What if (during development) we load a bad EDK2 image? >> >> Sorry, I don't understand really. > > What happens to the system if the EDK2 image crashes before we get > here? Will it overheat and damage the silicon? Or is it purely a power > consumption issue to avoid blowing the fuses in the data centre when > you power on a whole rack at once? It will not damage the silicon if wo load a bad EDK2 image. It is purely a power consumption issue. > > / > Leif > >>>> The implementation of functions is in edk2-non-osi. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: ZhenYao >>>> Signed-off-by: Ming Huang >>>> Signed-off-by: Heyi Guo >>>> --- >>>> Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >>>> index ec2b9a36e7..cc60e213de 100644 >>>> --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >>>> +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >>>> @@ -102,5 +102,8 @@ VOID PlatformEventBroadcastConfig(VOID); >>>> UINTN GetDjtagRegBase(UINT32 NodeId); >>>> VOID LlcCleanInvalidateAsm(VOID); >>>> VOID PlatformMdioInit(VOID); >>>> +VOID CloseClusterClock(UINTN CpuClusterBase); >>> >>> The opposite of Enable is Disable. So Could this be DisableClusterClock? >> >> Yes, this name is better. >> >>> >>>> +VOID EnableClusterClock(UINTN CpuClusterBase); >>>> +VOID CloseSktClock (UINT8 Skt); >>> >>> Disable? >>> Also, Socket, not Skt. >> >> OK, modify it in v2. >> >>> >>> / >>> Leif >>> >>>> >>>> #endif >>>> -- >>>> 2.17.0 >>>>