From: rebecca@bsdio.com
To: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh
Date: Mon, 22 Jul 2019 18:00:02 -0600 [thread overview]
Message-ID: <db45b3b0-fd89-a0ce-fcd7-6c360e80da44@bsdio.com> (raw)
In-Reply-To: <156383729562.19762.9432602825677327108@jljusten-skl>
On 2019-07-22 17:14, Jordan Justen wrote:
>
> I was suggesting that if they didn't specify -n as a param to
> build.sh, then build.sh should not send -n to the edk2 build command.
> The effect would be for the edk2 build command to check
> Conf/target.txt. By default, I think target.txt will not set
> THREADNUMBER, so "0" would still be the result.
>
> Yet, it would give them the option to set it in Conf/target.txt.
> Today, since we always use the -n param, target.txt is always ignored
> for this parameter.
On a related topic, I wonder if we should add a "-j" parameter if we
build BaseTools for users (e.g. "make -j4 -C BaseTools")? I've found
that it can be pretty slow without it: on my system adding -j4 reduces
build time from 55 seconds to 15. Going higher doesn't seem to produce
much more benefit: -j32 (on a ThreadRipper system) reduces it to 12 seconds.
--
Rebecca Cran
next prev parent reply other threads:[~2019-07-23 0:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 0:58 [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh rebecca
2019-07-22 7:11 ` Jordan Justen
2019-07-22 20:06 ` [edk2-devel] " Laszlo Ersek
2019-07-22 23:14 ` Jordan Justen
2019-07-22 23:52 ` rebecca
2019-07-23 0:00 ` rebecca [this message]
2019-07-23 7:44 ` Laszlo Ersek
2019-07-23 8:05 ` Jordan Justen
2019-07-23 12:05 ` Laszlo Ersek
[not found] <15B394CDDC5FF98D.6157@groups.io>
2019-07-22 0:59 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db45b3b0-fd89-a0ce-fcd7-6c360e80da44@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox