From: "GuoMinJ" <newexplorerj@gmail.com>
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>, Eric Dong <eric.dong@intel.com>,
Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
Date: Wed, 4 Mar 2020 19:39:28 +0800 [thread overview]
Message-ID: <db4c6d5e94a1ac583ed209cc9eed483e5d0ed463.1583321950.git.newexplorerj@gmail.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
The comment haven't indicate the output attribute.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index a987c32109..096d1c9b4b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 455cb3f09a..06556197c3 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -658,7 +658,7 @@ GetProcessorNumber (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 17b60903c5..a548fed23f 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
--
2.17.1
next reply other threads:[~2020-03-04 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 11:39 GuoMinJ [this message]
2020-03-04 14:35 ` [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue Dong, Eric
2020-03-04 16:59 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db4c6d5e94a1ac583ed209cc9eed483e5d0ed463.1583321950.git.newexplorerj@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox