From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Nhi Pham <nhi@os.amperecomputing.com>,
devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>
Cc: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com,
chuong@os.amperecomputing.com, quic_llindhol@quicinc.com,
Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com,
Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib
Date: Thu, 14 Jul 2022 08:40:27 +0100 [thread overview]
Message-ID: <db4ee75e-5769-9df2-cee5-683c5cab5249@arm.com> (raw)
In-Reply-To: <ec6ac857-1c65-05d2-0673-d714586420a6@os.amperecomputing.com>
Hi Nhi,
I will do that no problem. However, we really need an edk2-platforms CI
to catch such issues.
Regards,
Sami Mujawar
On 14/07/2022 04:34 am, Nhi Pham wrote:
> Hi Sami,
>
> Could you help update for
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
>
> Thanks,
> Nhi
>
> On 12/07/2022 21:40, Sami Mujawar wrote:
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Add an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This allows the variable
>> driver to build successfully as it has a dependency on this
>> library class.
>>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>> ---
>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> index
>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4
>> 100644
>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>> !endif
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>> #
next prev parent reply other threads:[~2022-07-14 7:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 14:40 [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 01/12] Platform/ARM: FVP: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 02/12] Platform/ARM: Morello: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: " Sami Mujawar
2022-07-14 12:30 ` Thomas Abraham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 04/12] Silicon/AMD/Styx: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 05/12] Silicon/Socionext/SynQuacer: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 06/12] Platform/RaspberryPi: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 07/12] Platform/ARM: N1SDP: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib Sami Mujawar
2022-07-14 3:34 ` Nhi Pham
2022-07-14 7:40 ` Sami Mujawar [this message]
[not found] ` <1701A22D591971D9.31468@groups.io>
2022-07-14 9:06 ` [edk2-devel] " Sami Mujawar
2022-07-14 9:12 ` Nhi Pham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-14 3:34 ` Nhi Pham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 10/12] Silicon/Phytium: Add VariableFlashInfoLib Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 11/12] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 12/12] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib Sami Mujawar
2022-07-13 13:18 ` [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro PierreGondois
2022-07-14 6:38 ` [edk2-devel] " Masahisa Kojima
2022-07-14 8:01 ` Sami Mujawar
2022-07-14 8:06 ` Sami Mujawar
2022-07-14 8:43 ` Masahisa Kojima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db4ee75e-5769-9df2-cee5-683c5cab5249@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox