From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.54]) by mx.groups.io with SMTP id smtpd.web10.4977.1657784452338013006 for ; Thu, 14 Jul 2022 00:40:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ZNNHKdKq; spf=pass (domain: arm.com, ip: 40.107.7.54, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=J0qR5cNwcCpNNcImay1NaKXylhxvk9HU//QgM6po0lyOwQwOFnoT4iYQ7yq5jlkBq5vHl9z12jyimmycJbVBzdUKzWPggjf5EbHvPxnHMTUrUAoX8EXHqVP+gGfLimTTGYxoLOgKdHuX2hjGdKgRjP0/rZbbhtT9zDZ29dgcukw6Bc/BuLvqQ7lLMBuKIaA2ysyeoeLWuqvQz0hggtz/GH4tvV8N8kKXgy4bY8hW5mAkI1s3e4l8+KFZI/mTmzmovbfxzoeI/ZJSOZC1pJhNTVQHEtU18ZfN28JSDgiu58CPKjLlTBrKinRDt9Xi+fmA6tDfSeGDvB15mXlEe8hjZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gBNe4AB2rlf9b2Lx9BOmi6jK3euO8wwLe6jyc0DLxwE=; b=goXp31RZN4nGUdKtFr+ylyIFYprVZSBo4NB0bZvc7LDQHnAVawq3y2S1V0dr2z6aGMIzvOvZocX9kNK13SDhk+kKCVJelHnNHzUvZR+nCuu/vJCeRJ0RYnPoHt4QWTn/eWoiWhla17BSype3K8kn705s/XrGY1/rIO47KiOqqdZrOL0GiKGBauXOSULSys9v+kG/73DY139fYEZhEGDPsPxrL+NoDm43qX4zRvbzGs/7oh48zD3fjibHGZDoiajI9XhUkKklKet7p2r/6rgjeIYBDxrukkbB6dAsTKc4/0dAgqkzN0oRWN9xygNbORiuinVVbzVMrEJnAeDnSJM65A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gBNe4AB2rlf9b2Lx9BOmi6jK3euO8wwLe6jyc0DLxwE=; b=ZNNHKdKqIvaw6/Cg5oXVXVKHw2sNrXPbEVZ9B9hGAeaLmv+FSapEtK89KMFqAe2gWThEOozLoWNyaKos/tVhXwsh4gyLZe35Z/uV53nXFj5tisczAUyDCWR2toz0fBtTsfDIao+Ajz1FkLDCk82zeU/EfJ1xuSLSiKm8qCnlIAo= Received: from AS9PR01CA0021.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::27) by AM9PR08MB6209.eurprd08.prod.outlook.com (2603:10a6:20b:283::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 14 Jul 2022 07:40:49 +0000 Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::31) by AS9PR01CA0021.outlook.office365.com (2603:10a6:20b:540::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 07:40:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 07:40:48 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Thu, 14 Jul 2022 07:40:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 54636d36a863f5f9 X-CR-MTA-TID: 64aa7808 Received: from 113afd56dfff.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6DD56C5-47FA-4B09-BB28-31F5CBD0A614.1; Thu, 14 Jul 2022 07:40:37 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 113afd56dfff.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 07:40:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oYLLzvAFkuHfpuC53Ihug2buf54IzevZuOv7sqORPJ9WTTEtlMJmlxuVAPl9WnC0ipWduaiqXLG/m9ZVjtoQc9TcgG4xwS/JtVGwrZ5PkG+fWG+qYDFIsHcDMaKCfRAj4vGVLhqkQDLjQzOCw1SaA4CHEGhkdZWY7IMfvYe4jAdmlaW5xz0jYtoxLeWurbtpgv5RwDE4yiBgeeHlNqEcP+4Csbih3J1vd2hd8BK+Y3qaldw/TdkU57nXXBHI4yw4oIc8F8QBl/vSy/xu3L/FCVgBp72qHwUfhkqo5Mj7vXuMZu6masJHKERdTSgjpc2b7msuYTMXEUJtPMg5LuoDkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gBNe4AB2rlf9b2Lx9BOmi6jK3euO8wwLe6jyc0DLxwE=; b=n2xwaA6/KpoCQAFQxx8dDvBP0KU1slKBiOjnQpQoxy7WtxuZGPi8otsYT8+Lk16QHHgnyEIeBPt1Fx3xAMvBhbKtGt9s10KH25Hx8vi21m7tKRAhHo7ZX6gpPQMHpBaHR2E2rigZmsJu2wDK3lBLdkNGqjvgLHra5AqhCXpwyKsSYiRzj25Oq6IkXQ/YlZoGHO6/u7wxp1r+qxvWGtQ3LoVtl9cB3dgblF5E6Hz5tC2QCBZ5br0gdpwwT2mCc8fFDQBAQvu5KbK7VpKhuwMU0LSuxTTJXlhFTjONIzMCdPqLialLGLazEzPDZoIGY6dgkIh6Jq/yuqmBbxlGpE+/3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gBNe4AB2rlf9b2Lx9BOmi6jK3euO8wwLe6jyc0DLxwE=; b=ZNNHKdKqIvaw6/Cg5oXVXVKHw2sNrXPbEVZ9B9hGAeaLmv+FSapEtK89KMFqAe2gWThEOozLoWNyaKos/tVhXwsh4gyLZe35Z/uV53nXFj5tisczAUyDCWR2toz0fBtTsfDIao+Ajz1FkLDCk82zeU/EfJ1xuSLSiKm8qCnlIAo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBBPR08MB5916.eurprd08.prod.outlook.com (2603:10a6:10:205::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 07:40:28 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%5]) with mapi id 15.20.5438.012; Thu, 14 Jul 2022 07:40:28 +0000 Message-ID: Date: Thu, 14 Jul 2022 08:40:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib To: Nhi Pham , devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Pierre Gondois CC: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, quic_llindhol@quicinc.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220712144047.3080-1-sami.mujawar@arm.com> <20220712144047.3080-9-sami.mujawar@arm.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0532.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d472f560-bb31-4f41-1183-08da656c2b84 X-MS-TrafficTypeDiagnostic: DBBPR08MB5916:EE_|VE1EUR03FT011:EE_|AM9PR08MB6209:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +vDkWn9QPhTkAmo82EVRtY/gOD0+mchK7xWxsvsJ1bChCFdWCy3AP517znUsH2RRMu9jCODV3QLrxQR081UE7Wm1+argQqwwXMnLOhZ6QT6zpWpgLbwKAKzIMPTs2IxqRG1QuXDwEDu/zZ51TKzY6aCpdt4pWFN0aY8zj8hkgPe810lU9cBR7kVopok+b7iaFn60OYYpmWPBoi3a5SkIm5nge8EtwwJ63sZClvZNMptX/diXdg5i4xw4S8Q8aHkHNU5J31ctOKpqXMyGm0JupY1SVrdcmC09sL3Zay269kd2lsglQnemMjhMP6EPEWFhWNwbuksfiyVoLiqE/087EO9iESMti+qxowQfaw1a6C6bk/dEl4AQeBKCAAAtcKW68+a+AndrDKN5s2TsOX7SSkIriHeb7oyXDv2/jZHJUbosmc5dykogJSKp0GqUUPvh6gJpfQ6lPClzp43OCUxTm6GflqZuBJEYG2Qktiw7ZQHked8q0iAa69C71xW2a4k92rXibGi53wibEElN9ydtQTFp++Xh9+/ZFQek4bPVVkEobyWxwpbMK67zipaXwG6Cs9nM1NKR0La3ZLVsVwe57OeweuCbomJ7cTIuOOsUTHU/yu86AuOVlSHFwocsAxxGjHuxgM/HCIGojAe/Wm5qLLDn4Ring5o95qA+RT4lsjgE1qE4jbHHzUPMeZ8iXPjPqz8XYklEEV9VhBH1uLDw19abwiKAlO1Fklm+K8A6eyNJk26wcJgTekNUG4Ps+o7y9bZHvxGaaU/hbL9okt3VqWKtUUtpSR1rRDHENG4XFQWi49HNR1K0sWokWRsptgEsur7V43jO0i6uwsosoLi9dCxTdkqTQ78x1WoAf6q3aiolZApK7xw3f48kIrSoqTSN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(39860400002)(366004)(346002)(6506007)(478600001)(53546011)(8936002)(5660300002)(186003)(44832011)(38100700002)(31686004)(66946007)(4326008)(66556008)(66476007)(6636002)(36756003)(316002)(83380400001)(110136005)(8676002)(6512007)(6486002)(26005)(2616005)(2906002)(41300700001)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5916 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4220d4fc-e31c-423e-b698-08da656c1f6a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oEDcvOlUYK2IB/fpSu05K9tw8IpPTyxtXg1YZntK4loZXCOcupLh6dJZh0ZaxMyw39bk/7sMQoR3VxUqGwpAeBTy+9hUo6ZgDgWRfACThwKyIL7hSEq5JlMKfuVQ/LdzFmY1r44864UkhGKoqxBykImcWK32YXOBK5bqsNTynTG4IcLiWgki3T170VNhfLR4hHQw+KKSuuGglbEGxzz2qX5MALELV6XQlWHhPle2k7HEf1iD2oYexbMTSWI2r6kec0379lyxnc9pc8x+vUINDnPbwIWN7dzqjMHao3eWBb2sVq7bPpkO5WVxuFPVirGTCXxtNNXXudxbQAd3TD39cKtBToX7Jlk1oiYa9Q0Qh1FAcObRwW4uqZsoZWb/7w6SHZ9xa2GeeSGzdCXZPXluWOrE9fqBzYo7Zs9c9Uao/m/1a/jSHzS8T3XrKcm1FBDlTq7OIV9s0Bu93yoWMu17ZYGlLIdzR4jaMjRApI59AtDUK+Fi98OOFkDKqwV668DGlRTIv23BIghKYirrL6L7s6g1XWm1lEboW3qBn31YZWjsNCsXWFDHhegGCIQEMgTJW6D/J8zCrDpWw9RAoF1SkbVTarL/WEg2ax1qukN0+GEtxINhkxCmY4X+e3SbyMG8JfbxK09d6qPfMeVxAMNluP/O7dG4v8pMpNc7u9fcOGMF3s9DPtRHj6uncaFT5jzlWCv/Crw90XcGPXHfDawFveOxGx4xHqrrcXAUU+a/TV1+GePadYICVf+eZ3tp7nJUluElwa/X291xzeVvPEAgLs+VTFs2QQdMLouQhN50AI8GDx3b/e52A1hpjcG6o5W0d2Rxf+XbdOLJOXCc87ei7NbwpUfft6XiPx0qvAePBAtg/dQ0OCxse0dzy8+nui/W X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(40470700004)(36840700001)(83380400001)(5660300002)(186003)(8936002)(47076005)(336012)(86362001)(2906002)(2616005)(356005)(82310400005)(82740400003)(40480700001)(81166007)(44832011)(31696002)(40460700003)(26005)(31686004)(110136005)(6506007)(6636002)(478600001)(70586007)(70206006)(36756003)(8676002)(4326008)(6486002)(53546011)(41300700001)(316002)(36860700001)(6512007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 07:40:48.5732 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d472f560-bb31-4f41-1183-08da656c2b84 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6209 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Nhi, I will do that no problem. However, we really need an edk2-platforms CI=20 to catch such issues. Regards, Sami Mujawar On 14/07/2022 04:34 am, Nhi Pham wrote: > Hi Sami, > > Could you help update for=20 > Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? > > Thanks, > Nhi > > On 12/07/2022 21:40, Sami Mujawar wrote: >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3479 >> >> Add an instance for the library class VariableFlashInfoLib that >> was recently introduced in MdeModulePkg. This allows the variable >> driver to build successfully as it has a dependency on this >> library class. >> >> Signed-off-by: Sami Mujawar >> --- >> =C2=A0 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + >> =C2=A0 1 file changed, 1 insertion(+) >> >> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc=20 >> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >> index=20 >> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d= 1727bd4fe4=20 >> 100644 >> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >> @@ -154,6 +154,7 @@ [LibraryClasses.common] >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLib= Null.inf >> =C2=A0 !endif >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyL= ib.inf >> +=20 >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseV= ariableFlashInfoLib.inf >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Var= iablePolicyHelperLib.inf >> =C2=A0 =C2=A0=C2=A0=C2=A0 #