From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
Date: Wed, 5 Jun 2019 10:03:29 +0200 [thread overview]
Message-ID: <db7f13e5-f0ee-1974-1beb-630a8c0aef20@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C191BCC@SHSMSX104.ccr.corp.intel.com>
On 06/05/19 03:10, Ni, Ray wrote:
> Hi everyone,
>
> Hao pushed the patch because:
> 1. it's a bug fix
> 2. it got a R-b.
> I don't think it's his fault.
>
> For #1, it's gap in process.
> For #2, it's my fault. Because even the patch title says EmulatorPkg but the patch itself changes MdeModulePkg, I am still the person who can approve changes in both packages.
>
> In Maintainers.txt:
> R: Ray Ni <ray.ni@intel.com>
> (especially for Bus, Universal/Console, Universal/Disk,
> Universal/BdsDxe and related libraries, header files)
>
> The UiApp actually is not in the "especially" part, but the word "especially"
> means I can also R-b to other components. In fact, I am not quite qualified on
> the other components, e.g.: UiApp.
> So I propose to assign clear reviewers for each components in MdeModulePkg.
> What do you think?
Fully agreed. MdeModulePkg is huge and we should have fine-grained
maintainership assignments.
Thanks
Laszlo
next prev parent reply other threads:[~2019-06-05 8:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:45 [Patch V2] EmulatorPkg: don't diaplay the cpu current speed Zhiguang Liu
2019-06-03 6:51 ` [edk2-devel] " Ni, Ray
[not found] ` <15A49DA9FFA456B0.4546@groups.io>
2019-06-04 8:50 ` Ni, Ray
2019-06-04 11:53 ` Ard Biesheuvel
2019-06-04 13:40 ` Liming Gao
2019-06-04 13:41 ` Ard Biesheuvel
2019-06-04 14:19 ` Liming Gao
2019-06-05 1:10 ` Ni, Ray
2019-06-05 8:03 ` Laszlo Ersek [this message]
2019-06-05 14:31 ` Zeng, Star
2019-06-10 6:01 ` Wu, Hao A
2019-06-10 6:13 ` Yao, Jiewen
2019-06-10 6:20 ` Wu, Hao A
2019-06-10 7:16 ` Ni, Ray
2019-06-10 7:32 ` Wu, Hao A
2019-06-10 7:33 ` Ni, Ray
2019-06-10 7:37 ` Ard Biesheuvel
2019-06-10 8:07 ` Wu, Hao A
2019-06-10 10:50 ` Ard Biesheuvel
2019-06-11 15:19 ` Laszlo Ersek
2019-06-10 7:39 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db7f13e5-f0ee-1974-1beb-630a8c0aef20@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox