From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 05 Jun 2019 01:04:01 -0700
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 762C73082E25;
	Wed,  5 Jun 2019 08:03:42 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-4.ams2.redhat.com [10.36.117.4])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 544F660576;
	Wed,  5 Jun 2019 08:03:35 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
To: "Ni, Ray" <ray.ni@intel.com>, "Gao, Liming" <liming.gao@intel.com>,
 "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
 Leif Lindholm <leif.lindholm@linaro.org>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Liu, Zhiguang" <zhiguang.liu@intel.com>,
 "Justen, Jordan L" <jordan.l.justen@intel.com>, Andrew Fish <afish@apple.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
References: <20190603064503.20460-1-zhiguang.liu@intel.com>
 <15A49DA9FFA456B0.4546@groups.io>
 <734D49CCEBEEF84792F5B80ED585239D5C18F543@SHSMSX104.ccr.corp.intel.com>
 <CAKv+Gu90P0GwbjQNDUTQAp1+s3Fpi6h-GbHHnbXzjbPdYuwycQ@mail.gmail.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E46B8D2@SHSMSX104.ccr.corp.intel.com>
 <CAKv+Gu_xdOxZm5V_mzbdQ2UGH22dMPV4JXPu3Vi1NoiFG1QEBQ@mail.gmail.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E46B97B@SHSMSX104.ccr.corp.intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C191BCC@SHSMSX104.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <db7f13e5-f0ee-1974-1beb-630a8c0aef20@redhat.com>
Date: Wed, 5 Jun 2019 10:03:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C191BCC@SHSMSX104.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 05 Jun 2019 08:04:00 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/05/19 03:10, Ni, Ray wrote:
> Hi everyone,
> 
> Hao pushed the patch because:
> 1. it's a bug fix
> 2. it got a R-b.
> I don't think it's his fault.
> 
> For #1, it's gap in process.
> For #2, it's my fault. Because even the patch title says EmulatorPkg but the patch itself changes MdeModulePkg, I am still the person who can approve changes in both packages.
> 
> In Maintainers.txt:
> R: Ray Ni <ray.ni@intel.com>
>   (especially for Bus, Universal/Console, Universal/Disk,
>    Universal/BdsDxe and related libraries, header files)
> 
> The UiApp actually is not in the "especially" part, but the word "especially"
> means I can also R-b to other components. In fact, I am not quite qualified on
> the other components, e.g.: UiApp.
> So I propose to assign clear reviewers for each components in MdeModulePkg.
> What do you think?

Fully agreed. MdeModulePkg is huge and we should have fine-grained
maintainership assignments.

Thanks
Laszlo