From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.11341.1620732034565740720 for ; Tue, 11 May 2021 04:20:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H1CpFmAO; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620732033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/azUIN0eG9iFwq54V47ixbCnZf3VpgbImEIBAraQNg=; b=H1CpFmAO59BnmkHqOc6jlXWrSvH1bQ2VDRPUMscCUos0lcDFt+kD2Iu7uM/LeywKAicoAb /lypEmmUmYwqvFNF3R6Ho/WgTH2JYzXUx6Eyou+weJmJyClajNEbLFZwzulyLAQv1tEqVR Aa3LY1NHMk4mDKfLeCVCH8r/S2u92OQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-pc5ROElqM7iin1c-1f0glQ-1; Tue, 11 May 2021 07:20:31 -0400 X-MC-Unique: pc5ROElqM7iin1c-1f0glQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C979107ACC7; Tue, 11 May 2021 11:20:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-233.ams2.redhat.com [10.36.112.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id A91685D9D7; Tue, 11 May 2021 11:20:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 12/13] OvmfPkg/TpmMmioSevDecryptPei: use MemEncryptSevClearMmioPageEncMask() To: devel@edk2.groups.io, brijesh.singh@amd.com Cc: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas References: <20210507203838.23706-1-brijesh.singh@amd.com> <20210507203838.23706-13-brijesh.singh@amd.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 11 May 2021 13:20:27 +0200 MIME-Version: 1.0 In-Reply-To: <20210507203838.23706-13-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask > for the Mmio address range. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c b/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c > index df2ad623308d..570c8467a673 100644 > --- a/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c > +++ b/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c > @@ -62,11 +62,10 @@ TpmMmioSevDecryptPeimEntryPoint ( > "%a: mapping TPM MMIO address range unencrypted\n", > __FUNCTION__)); > > - DecryptStatus = MemEncryptSevClearPageEncMask ( > + DecryptStatus = MemEncryptSevClearMmioPageEncMask ( > 0, > FixedPcdGet64 (PcdTpmBaseAddress), > - EFI_SIZE_TO_PAGES ((UINTN) 0x5000), > - FALSE > + EFI_SIZE_TO_PAGES ((UINTN) 0x5000) > ); > > if (RETURN_ERROR (DecryptStatus)) { > Reviewed-by: Laszlo Ersek