Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

Hi Liming,

Friendly ping, can you please review this patchset?

Thanks,
Oliver

On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote:
> ImagePropertiesRecordLib is currently creating Image Records that
> are not accurate. It is setting the CodeSegmentSize to be the size
> of the raw data in the image file, however, when the image is
> loaded into memory, the raw data size is aligned to the
> section alignment. This caused the memory attributes table to
> have incorrect entries for systems, like ARM64, where the section
> alignment is not 4k for all modules.
> 
> In fixing this, I noticed that MemoryProtection.c is using its own
> version of image record creation where this logic was actually
> correct. ImagePropertiesRecordLib was created to consolidate the
> logic around creating and managing image records, so this patchset
> also updates MemoryProtection.c to use ImagePropertiesRecordsLib
> after making a few small adjustments to ensure the same functionality
> is present.
> 
> This patchset was tested on ArmVirtQemu to ensure that all image
> records were the same before and after this, other than fixing
> the CodeSegmentSize.
> 
> v2:
> - Align VirtualSize instead of SizeOfRawData
> 
> Github PR: https://github.com/tianocore/edk2/pull/5402
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
> 
> Oliver Smith-Denny (3):
>    MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
>      CodeSize
>    MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>    MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
> 
>   MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c                            | 241 +++-----------------
>   MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |  86 +++++--
>   2 files changed, 94 insertions(+), 233 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116718): https://edk2.groups.io/g/devel/message/116718
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

Hi Liming,

Another friendly ping, can you review these patches? 2 RBs and
conversation has died down.

Thanks,
Oliver

On 3/13/2024 10:33 AM, Oliver Smith-Denny wrote:
> Hi Liming,
> 
> Friendly ping, can you please review this patchset?
> 
> Thanks,
> Oliver
> 
> On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote:
>> ImagePropertiesRecordLib is currently creating Image Records that
>> are not accurate. It is setting the CodeSegmentSize to be the size
>> of the raw data in the image file, however, when the image is
>> loaded into memory, the raw data size is aligned to the
>> section alignment. This caused the memory attributes table to
>> have incorrect entries for systems, like ARM64, where the section
>> alignment is not 4k for all modules.
>>
>> In fixing this, I noticed that MemoryProtection.c is using its own
>> version of image record creation where this logic was actually
>> correct. ImagePropertiesRecordLib was created to consolidate the
>> logic around creating and managing image records, so this patchset
>> also updates MemoryProtection.c to use ImagePropertiesRecordsLib
>> after making a few small adjustments to ensure the same functionality
>> is present.
>>
>> This patchset was tested on ArmVirtQemu to ensure that all image
>> records were the same before and after this, other than fixing
>> the CodeSegmentSize.
>>
>> v2:
>> - Align VirtualSize instead of SizeOfRawData
>>
>> Github PR: https://github.com/tianocore/edk2/pull/5402
>>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
>>
>> Oliver Smith-Denny (3):
>>    MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
>>      CodeSize
>>    MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>>    MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
>>
>>   
>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c                            | 241 +++-----------------
>>   
>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |  86 +++++--
>>   2 files changed, 94 insertions(+), 233 deletions(-)
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116943): https://edk2.groups.io/g/devel/message/116943
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

Hi Mike and Ray,

I'm here to bug you again :). I have another patchset that
unfortunately Liming has not gotten to review in a month's
time frame with weekly pings. When I bugged you last time,
he reviewed the next day, so something must have worked out
there. Can you please help get this merged?

Liming, do you need the community to find another member
to help as a second MdeModulePkg maintainer? It's obviously
a large job and you have been less responsive the past few
months, which has slowed down getting some really
important fixes into MdeModulePkg.

Thanks,
Oliver

On 3/20/2024 10:35 AM, Oliver Smith-Denny wrote:
> Hi Liming,
> 
> Another friendly ping, can you review these patches? 2 RBs and
> conversation has died down.
> 
> Thanks,
> Oliver
> 
> On 3/13/2024 10:33 AM, Oliver Smith-Denny wrote:
>> Hi Liming,
>>
>> Friendly ping, can you please review this patchset?
>>
>> Thanks,
>> Oliver
>>
>> On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote:
>>> ImagePropertiesRecordLib is currently creating Image Records that
>>> are not accurate. It is setting the CodeSegmentSize to be the size
>>> of the raw data in the image file, however, when the image is
>>> loaded into memory, the raw data size is aligned to the
>>> section alignment. This caused the memory attributes table to
>>> have incorrect entries for systems, like ARM64, where the section
>>> alignment is not 4k for all modules.
>>>
>>> In fixing this, I noticed that MemoryProtection.c is using its own
>>> version of image record creation where this logic was actually
>>> correct. ImagePropertiesRecordLib was created to consolidate the
>>> logic around creating and managing image records, so this patchset
>>> also updates MemoryProtection.c to use ImagePropertiesRecordsLib
>>> after making a few small adjustments to ensure the same functionality
>>> is present.
>>>
>>> This patchset was tested on ArmVirtQemu to ensure that all image
>>> records were the same before and after this, other than fixing
>>> the CodeSegmentSize.
>>>
>>> v2:
>>> - Align VirtualSize instead of SizeOfRawData
>>>
>>> Github PR: https://github.com/tianocore/edk2/pull/5402
>>>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
>>>
>>> Oliver Smith-Denny (3):
>>>    MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
>>>      CodeSize
>>>    MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>>>    MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
>>>
>>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c                            | 241 +++-----------------
>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |  86 +++++--
>>>   2 files changed, 94 insertions(+), 233 deletions(-)
>>>
>>
>>
>>
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117178): https://edk2.groups.io/g/devel/message/117178
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Ard Biesheuvel]

On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
<osde@linux.microsoft.com> wrote:
>
> Hi Mike and Ray,
>
> I'm here to bug you again :). I have another patchset that
> unfortunately Liming has not gotten to review in a month's
> time frame with weekly pings. When I bugged you last time,
> he reviewed the next day, so something must have worked out
> there. Can you please help get this merged?
>
> Liming, do you need the community to find another member
> to help as a second MdeModulePkg maintainer? It's obviously
> a large job and you have been less responsive the past few
> months, which has slowed down getting some really
> important fixes into MdeModulePkg.
>

Yes, could we please get this merged? These are important fixes.

In case it was missed, for the series:

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117231): https://edk2.groups.io/g/devel/message/117231
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Michael D Kinney]

Hi Ard,

I have reviewed the discussion on the V1 and V2 versions of the series.
For the V2 Series:

    Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

I will add the Rb/Ab tags and get this merged.

Mike

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Friday, March 29, 2024 1:03 AM
> To: devel@edk2.groups.io; osde@linux.microsoft.com
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; Taylor
> Beebe <taylor.d.beebe@gmail.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> ImagePropertiesRecordLib Fixes
> 
> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
> <osde@linux.microsoft.com> wrote:
> >
> > Hi Mike and Ray,
> >
> > I'm here to bug you again :). I have another patchset that
> > unfortunately Liming has not gotten to review in a month's
> > time frame with weekly pings. When I bugged you last time,
> > he reviewed the next day, so something must have worked out
> > there. Can you please help get this merged?
> >
> > Liming, do you need the community to find another member
> > to help as a second MdeModulePkg maintainer? It's obviously
> > a large job and you have been less responsive the past few
> > months, which has slowed down getting some really
> > important fixes into MdeModulePkg.
> >
> 
> Yes, could we please get this merged? These are important fixes.
> 
> In case it was missed, for the series:
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117235): https://edk2.groups.io/g/devel/message/117235
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

Thanks Mike!

Oliver

On 3/29/2024 10:12 AM, Michael D Kinney wrote:
> Hi Ard,
> 
> I have reviewed the discussion on the V1 and V2 versions of the series.
> For the V2 Series:
> 
>      Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> I will add the Rb/Ab tags and get this merged.
> 
> Mike
> 
>> -----Original Message-----
>> From: Ard Biesheuvel <ardb@kernel.org>
>> Sent: Friday, March 29, 2024 1:03 AM
>> To: devel@edk2.groups.io; osde@linux.microsoft.com
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
>> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; Taylor
>> Beebe <taylor.d.beebe@gmail.com>
>> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
>> ImagePropertiesRecordLib Fixes
>>
>> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
>> <osde@linux.microsoft.com> wrote:
>>>
>>> Hi Mike and Ray,
>>>
>>> I'm here to bug you again :). I have another patchset that
>>> unfortunately Liming has not gotten to review in a month's
>>> time frame with weekly pings. When I bugged you last time,
>>> he reviewed the next day, so something must have worked out
>>> there. Can you please help get this merged?
>>>
>>> Liming, do you need the community to find another member
>>> to help as a second MdeModulePkg maintainer? It's obviously
>>> a large job and you have been less responsive the past few
>>> months, which has slowed down getting some really
>>> important fixes into MdeModulePkg.
>>>
>>
>> Yes, could we please get this merged? These are important fixes.
>>
>> In case it was missed, for the series:
>>
>> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117236): https://edk2.groups.io/g/devel/message/117236
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Michael D Kinney]

Hi Oliver,

I am seeing a merge conflict with the V2 patches from the emails.

Can you please rebase, resolve conflicts, and resend?

Thanks,

Mike

> -----Original Message-----
> From: Oliver Smith-Denny <osde@linux.microsoft.com>
> Sent: Friday, March 29, 2024 10:14 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> Ard Biesheuvel <ardb@kernel.org>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Leif
> Lindholm <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>;
> Taylor Beebe <taylor.d.beebe@gmail.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> ImagePropertiesRecordLib Fixes
> 
> Thanks Mike!
> 
> Oliver
> 
> On 3/29/2024 10:12 AM, Michael D Kinney wrote:
> > Hi Ard,
> >
> > I have reviewed the discussion on the V1 and V2 versions of the series.
> > For the V2 Series:
> >
> >      Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > I will add the Rb/Ab tags and get this merged.
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Ard Biesheuvel <ardb@kernel.org>
> >> Sent: Friday, March 29, 2024 1:03 AM
> >> To: devel@edk2.groups.io; osde@linux.microsoft.com
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> >> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> >> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; Taylor
> >> Beebe <taylor.d.beebe@gmail.com>
> >> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> >> ImagePropertiesRecordLib Fixes
> >>
> >> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
> >> <osde@linux.microsoft.com> wrote:
> >>>
> >>> Hi Mike and Ray,
> >>>
> >>> I'm here to bug you again :). I have another patchset that
> >>> unfortunately Liming has not gotten to review in a month's
> >>> time frame with weekly pings. When I bugged you last time,
> >>> he reviewed the next day, so something must have worked out
> >>> there. Can you please help get this merged?
> >>>
> >>> Liming, do you need the community to find another member
> >>> to help as a second MdeModulePkg maintainer? It's obviously
> >>> a large job and you have been less responsive the past few
> >>> months, which has slowed down getting some really
> >>> important fixes into MdeModulePkg.
> >>>
> >>
> >> Yes, could we please get this merged? These are important fixes.
> >>
> >> In case it was missed, for the series:
> >>
> >> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117237): https://edk2.groups.io/g/devel/message/117237
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

Will do! Sorry, it's sat for a bit, so not too surprising. I'll
get that up soon.

Thanks,
Oliver

On 3/29/2024 10:27 AM, Michael D Kinney wrote:
> Hi Oliver,
> 
> I am seeing a merge conflict with the V2 patches from the emails.
> 
> Can you please rebase, resolve conflicts, and resend?
> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: Oliver Smith-Denny <osde@linux.microsoft.com>
>> Sent: Friday, March 29, 2024 10:14 AM
>> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
>> Ard Biesheuvel <ardb@kernel.org>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Leif
>> Lindholm <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>;
>> Taylor Beebe <taylor.d.beebe@gmail.com>
>> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
>> ImagePropertiesRecordLib Fixes
>>
>> Thanks Mike!
>>
>> Oliver
>>
>> On 3/29/2024 10:12 AM, Michael D Kinney wrote:
>>> Hi Ard,
>>>
>>> I have reviewed the discussion on the V1 and V2 versions of the series.
>>> For the V2 Series:
>>>
>>>       Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>>>
>>> I will add the Rb/Ab tags and get this merged.
>>>
>>> Mike
>>>
>>>> -----Original Message-----
>>>> From: Ard Biesheuvel <ardb@kernel.org>
>>>> Sent: Friday, March 29, 2024 1:03 AM
>>>> To: devel@edk2.groups.io; osde@linux.microsoft.com
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
>>>> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
>>>> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; Taylor
>>>> Beebe <taylor.d.beebe@gmail.com>
>>>> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
>>>> ImagePropertiesRecordLib Fixes
>>>>
>>>> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
>>>> <osde@linux.microsoft.com> wrote:
>>>>>
>>>>> Hi Mike and Ray,
>>>>>
>>>>> I'm here to bug you again :). I have another patchset that
>>>>> unfortunately Liming has not gotten to review in a month's
>>>>> time frame with weekly pings. When I bugged you last time,
>>>>> he reviewed the next day, so something must have worked out
>>>>> there. Can you please help get this merged?
>>>>>
>>>>> Liming, do you need the community to find another member
>>>>> to help as a second MdeModulePkg maintainer? It's obviously
>>>>> a large job and you have been less responsive the past few
>>>>> months, which has slowed down getting some really
>>>>> important fixes into MdeModulePkg.
>>>>>
>>>>
>>>> Yes, could we please get this merged? These are important fixes.
>>>>
>>>> In case it was missed, for the series:
>>>>
>>>> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>>>
>>>
>>>
>>>
>>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117238): https://edk2.groups.io/g/devel/message/117238
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

I sent a v3 with the fixup (it was trivial, from my last patch,
apologies for not fixing up before). I added the RBs/AB, hope that
was alright since there was no substantial code change, just the
merge fix.

Thanks,
Oliver

On 3/29/2024 10:28 AM, Oliver Smith-Denny wrote:
> Will do! Sorry, it's sat for a bit, so not too surprising. I'll
> get that up soon.
> 
> Thanks,
> Oliver
> 
> On 3/29/2024 10:27 AM, Michael D Kinney wrote:
>> Hi Oliver,
>>
>> I am seeing a merge conflict with the V2 patches from the emails.
>>
>> Can you please rebase, resolve conflicts, and resend?
>>
>> Thanks,
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: Oliver Smith-Denny <osde@linux.microsoft.com>
>>> Sent: Friday, March 29, 2024 10:14 AM
>>> To: devel@edk2.groups.io; Kinney, Michael D 
>>> <michael.d.kinney@intel.com>;
>>> Ard Biesheuvel <ardb@kernel.org>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Ni, Ray 
>>> <ray.ni@intel.com>; Leif
>>> Lindholm <quic_llindhol@quicinc.com>; Sami Mujawar 
>>> <sami.mujawar@arm.com>;
>>> Taylor Beebe <taylor.d.beebe@gmail.com>
>>> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
>>> ImagePropertiesRecordLib Fixes
>>>
>>> Thanks Mike!
>>>
>>> Oliver
>>>
>>> On 3/29/2024 10:12 AM, Michael D Kinney wrote:
>>>> Hi Ard,
>>>>
>>>> I have reviewed the discussion on the V1 and V2 versions of the series.
>>>> For the V2 Series:
>>>>
>>>>       Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>>>>
>>>> I will add the Rb/Ab tags and get this merged.
>>>>
>>>> Mike
>>>>
>>>>> -----Original Message-----
>>>>> From: Ard Biesheuvel <ardb@kernel.org>
>>>>> Sent: Friday, March 29, 2024 1:03 AM
>>>>> To: devel@edk2.groups.io; osde@linux.microsoft.com
>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
>>>>> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif 
>>>>> Lindholm
>>>>> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; 
>>>>> Taylor
>>>>> Beebe <taylor.d.beebe@gmail.com>
>>>>> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
>>>>> ImagePropertiesRecordLib Fixes
>>>>>
>>>>> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
>>>>> <osde@linux.microsoft.com> wrote:
>>>>>>
>>>>>> Hi Mike and Ray,
>>>>>>
>>>>>> I'm here to bug you again :). I have another patchset that
>>>>>> unfortunately Liming has not gotten to review in a month's
>>>>>> time frame with weekly pings. When I bugged you last time,
>>>>>> he reviewed the next day, so something must have worked out
>>>>>> there. Can you please help get this merged?
>>>>>>
>>>>>> Liming, do you need the community to find another member
>>>>>> to help as a second MdeModulePkg maintainer? It's obviously
>>>>>> a large job and you have been less responsive the past few
>>>>>> months, which has slowed down getting some really
>>>>>> important fixes into MdeModulePkg.
>>>>>>
>>>>>
>>>>> Yes, could we please get this merged? These are important fixes.
>>>>>
>>>>> In case it was missed, for the series:
>>>>>
>>>>> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>>>>
>>>>
>>>>
>>>>
>>>>
>>
>>
>>
>>
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117243): https://edk2.groups.io/g/devel/message/117243
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Oliver Smith-Denny]

ImagePropertiesRecordLib is currently creating Image Records that
are not accurate. It is setting the CodeSegmentSize to be the size
of the raw data in the image file, however, when the image is
loaded into memory, the raw data size is aligned to the
section alignment. This caused the memory attributes table to
have incorrect entries for systems, like ARM64, where the section
alignment is not 4k for all modules.

In fixing this, I noticed that MemoryProtection.c is using its own
version of image record creation where this logic was actually
correct. ImagePropertiesRecordLib was created to consolidate the
logic around creating and managing image records, so this patchset
also updates MemoryProtection.c to use ImagePropertiesRecordsLib
after making a few small adjustments to ensure the same functionality
is present.

This patchset was tested on ArmVirtQemu to ensure that all image
records were the same before and after this, other than fixing
the CodeSegmentSize.

v2:
- Align VirtualSize instead of SizeOfRawData

Github PR: https://github.com/tianocore/edk2/pull/5402

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Taylor Beebe <taylor.d.beebe@gmail.com>

Oliver Smith-Denny (3):
  MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
    CodeSize
  MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
  MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib

 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c                            | 241 +++-----------------
 MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |  86 +++++--
 2 files changed, 94 insertions(+), 233 deletions(-)

-- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116657): https://edk2.groups.io/g/devel/message/116657
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-