From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes
Date: Mon, 8 Nov 2021 18:09:47 +0100 [thread overview]
Message-ID: <dbc30832-cbb8-8ac7-3658-23ac858bf2ca@linux.intel.com> (raw)
In-Reply-To: <20211101213737.586-6-michael.d.kinney@intel.com>
Hey Mike,
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Thanks,
Maciej
On 01-Nov-21 22:37, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> NetworkPkg/Include/Library/NetLib.h | 8 ++++----
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h
> index 858d0b6ba07c..6c0924863147 100644
> --- a/NetworkPkg/Include/Library/NetLib.h
> +++ b/NetworkPkg/Include/Library/NetLib.h
> @@ -277,7 +277,7 @@ typedef struct {
> NETDEBUG_LEVEL_TRACE, \
> Module, \
> __FILE__, \
> - __LINE__, \
> + DEBUG_LINE_NUMBER, \
> NetDebugASPrint PrintArg \
> )
>
> @@ -286,7 +286,7 @@ typedef struct {
> NETDEBUG_LEVEL_WARNING, \
> Module, \
> __FILE__, \
> - __LINE__, \
> + DEBUG_LINE_NUMBER, \
> NetDebugASPrint PrintArg \
> )
>
> @@ -295,7 +295,7 @@ typedef struct {
> NETDEBUG_LEVEL_ERROR, \
> Module, \
> __FILE__, \
> - __LINE__, \
> + DEBUG_LINE_NUMBER, \
> NetDebugASPrint PrintArg \
> )
>
> @@ -311,7 +311,7 @@ typedef struct {
> NETDEBUG_LEVEL_TRACE,
> "Tcp",
> __FILE__,
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> NetDebugASPrint ("State transit to %a\n", Name)
> )
>
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 2a555a7b90fa..0f95ce4b710d 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -434,7 +434,7 @@ SyslogBuildPacket (
> NETDEBUG_LEVEL_TRACE,
> "Tcp",
> __FILE__,
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> NetDebugASPrint ("State transit to %a\n", Name)
> )
>
next prev parent reply other threads:[~2021-11-08 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 21:37 [Patch V2 0/7] Reproduce builds across source format changes Michael D Kinney
2021-11-01 21:37 ` [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds Michael D Kinney
2021-11-02 2:12 ` 回复: " gaoliming
2021-11-02 7:05 ` [edk2-devel] " Michael D Kinney
2021-11-04 5:24 ` 回复: " gaoliming
2021-11-01 21:37 ` [Patch V2 2/7] MdePkg: Reproduce builds across source format changes Michael D Kinney
2021-11-01 21:37 ` [Patch V2 3/7] ArmPkg: " Michael D Kinney
2021-11-01 21:37 ` [Patch V2 4/7] MdeModulePkg: " Michael D Kinney
2021-11-01 21:37 ` [Patch V2 5/7] NetworkPkg: " Michael D Kinney
2021-11-08 17:09 ` Maciej Rabeda [this message]
2021-11-01 21:37 ` [Patch V2 6/7] SecurityPkg: " Michael D Kinney
2021-11-02 0:14 ` Yao, Jiewen
2021-11-01 21:37 ` [Patch V2 7/7] OvmfPkg: " Michael D Kinney
2021-11-05 3:18 ` Yao, Jiewen
2021-11-02 2:31 ` 回复: [Patch V2 0/7] " gaoliming
2021-11-02 7:10 ` Michael D Kinney
2021-11-04 5:15 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc30832-cbb8-8ac7-3658-23ac858bf2ca@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox