From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by mx.groups.io with SMTP id smtpd.web08.1563.1636392350796348222
 for <devel@edk2.groups.io>;
 Mon, 08 Nov 2021 09:25:51 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.120, mailfrom: maciej.rabeda@linux.intel.com)
X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="230994944"
X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; 
   d="scan'208";a="230994944"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 09:09:54 -0800
X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; 
   d="scan'208";a="503108285"
Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.249.153.170]) ([10.249.153.170])
  by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 09:09:52 -0800
Message-ID: <dbc30832-cbb8-8ac7-3658-23ac858bf2ca@linux.intel.com>
Date: Mon, 8 Nov 2021 18:09:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>
References: <20211101213737.586-1-michael.d.kinney@intel.com>
 <20211101213737.586-6-michael.d.kinney@intel.com>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
In-Reply-To: <20211101213737.586-6-michael.d.kinney@intel.com>
Content-Language: pl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hey Mike,

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

Thanks,
Maciej

On 01-Nov-21 22:37, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   NetworkPkg/Include/Library/NetLib.h      | 8 ++++----
>   NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h
> index 858d0b6ba07c..6c0924863147 100644
> --- a/NetworkPkg/Include/Library/NetLib.h
> +++ b/NetworkPkg/Include/Library/NetLib.h
> @@ -277,7 +277,7 @@ typedef struct {
>       NETDEBUG_LEVEL_TRACE, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -286,7 +286,7 @@ typedef struct {
>       NETDEBUG_LEVEL_WARNING, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -295,7 +295,7 @@ typedef struct {
>       NETDEBUG_LEVEL_ERROR, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -311,7 +311,7 @@ typedef struct {
>              NETDEBUG_LEVEL_TRACE,
>              "Tcp",
>              __FILE__,
> -           __LINE__,
> +           DEBUG_LINE_NUMBER,
>              NetDebugASPrint ("State transit to %a\n", Name)
>            )
>   
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 2a555a7b90fa..0f95ce4b710d 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -434,7 +434,7 @@ SyslogBuildPacket (
>              NETDEBUG_LEVEL_TRACE,
>              "Tcp",
>              __FILE__,
> -           __LINE__,
> +           DEBUG_LINE_NUMBER,
>              NetDebugASPrint ("State transit to %a\n", Name)
>            )
>