public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: Andrei Warkentin <andrey.warkentin@gmail.com>, devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com
Subject: Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
Date: Mon, 11 May 2020 11:58:28 +0100	[thread overview]
Message-ID: <dbf34a0b-682b-6dd2-4c9e-5a101975b42e@akeo.ie> (raw)
In-Reply-To: <20200510213603.12741-1-andrey.warkentin@gmail.com>

On 2020.05.10 22:36, Andrei Warkentin wrote:
> The scaled resolutions are useful, but are not the default expected
> by most users. Linux and BSDs don't set preferred resolution in
> their OS loader, so when booting via setup UI, the OS is left
> running at 800x600, not the native resolution. This looks crummy.
> 
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
>   2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index a138c874..8dd4cbff 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -471,7 +471,11 @@
>     #
>     # Display-related.
>     #
> -  gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
> +
> +  #
> +  # Just enable native resolution by default.
> +  #
> +  gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>     gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>   
>     #
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 75867f03..9413fe66 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -486,7 +486,11 @@
>     #
>     # Display-related.
>     #
> -  gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
> +
> +  #
> +  # Just enable native resolution by default.
> +  #
> +  gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>     gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>   
>     #
> 

Reviewed-by: Pete Batard <pete@akeo.ie>

For the series:
Tested-by: Pete Batard <pete@akeo.ie>

  reply	other threads:[~2020-05-11 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 21:36 [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode Andrei Warkentin
2020-05-11 10:58 ` Pete Batard [this message]
2020-05-11 11:06   ` Ard Biesheuvel
2020-05-11 11:38     ` Pete Batard
     [not found] ` <160DF42BB1B94275.21511@groups.io>
2020-05-11 11:00   ` [edk2-devel] " Pete Batard
2020-05-11 11:56     ` Ard Biesheuvel
2020-05-11 12:07       ` Pete Batard
2020-05-11 12:08         ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf34a0b-682b-6dd2-4c9e-5a101975b42e@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox