* [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
@ 2020-05-10 21:36 Andrei Warkentin
2020-05-11 10:58 ` Pete Batard
[not found] ` <160DF42BB1B94275.21511@groups.io>
0 siblings, 2 replies; 8+ messages in thread
From: Andrei Warkentin @ 2020-05-10 21:36 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, pete, philmd
The scaled resolutions are useful, but are not the default expected
by most users. Linux and BSDs don't set preferred resolution in
their OS loader, so when booting via setup UI, the OS is left
running at 800x600, not the native resolution. This looks crummy.
Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index a138c874..8dd4cbff 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -471,7 +471,11 @@
#
# Display-related.
#
- gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
+
+ #
+ # Just enable native resolution by default.
+ #
+ gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
#
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 75867f03..9413fe66 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -486,7 +486,11 @@
#
# Display-related.
#
- gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
+
+ #
+ # Just enable native resolution by default.
+ #
+ gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
#
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-10 21:36 [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode Andrei Warkentin
@ 2020-05-11 10:58 ` Pete Batard
2020-05-11 11:06 ` Ard Biesheuvel
[not found] ` <160DF42BB1B94275.21511@groups.io>
1 sibling, 1 reply; 8+ messages in thread
From: Pete Batard @ 2020-05-11 10:58 UTC (permalink / raw)
To: Andrei Warkentin, devel; +Cc: ard.biesheuvel, leif, philmd
On 2020.05.10 22:36, Andrei Warkentin wrote:
> The scaled resolutions are useful, but are not the default expected
> by most users. Linux and BSDs don't set preferred resolution in
> their OS loader, so when booting via setup UI, the OS is left
> running at 800x600, not the native resolution. This looks crummy.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
> ---
> Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
> Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index a138c874..8dd4cbff 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -471,7 +471,11 @@
> #
> # Display-related.
> #
> - gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
> +
> + #
> + # Just enable native resolution by default.
> + #
> + gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>
> #
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 75867f03..9413fe66 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -486,7 +486,11 @@
> #
> # Display-related.
> #
> - gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
> +
> + #
> + # Just enable native resolution by default.
> + #
> + gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>
> #
>
Reviewed-by: Pete Batard <pete@akeo.ie>
For the series:
Tested-by: Pete Batard <pete@akeo.ie>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
[not found] ` <160DF42BB1B94275.21511@groups.io>
@ 2020-05-11 11:00 ` Pete Batard
2020-05-11 11:56 ` Ard Biesheuvel
0 siblings, 1 reply; 8+ messages in thread
From: Pete Batard @ 2020-05-11 11:00 UTC (permalink / raw)
To: devel, Andrei Warkentin; +Cc: ard.biesheuvel, leif, philmd
Actually forgot one thing on this one:
Subject line should say "RPi" not "RPi3" since it affects both Pi's.
/Pete
On 2020.05.11 11:58, Pete Batard via groups.io wrote:
> On 2020.05.10 22:36, Andrei Warkentin wrote:
>> The scaled resolutions are useful, but are not the default expected
>> by most users. Linux and BSDs don't set preferred resolution in
>> their OS loader, so when booting via setup UI, the OS is left
>> running at 800x600, not the native resolution. This looks crummy.
>>
>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>> ---
>> Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
>> Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> index a138c874..8dd4cbff 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> @@ -471,7 +471,11 @@
>> #
>> # Display-related.
>> #
>> -
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>
>> +
>> + #
>> + # Just enable native resolution by default.
>> + #
>> +
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>
>>
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>
>> #
>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> index 75867f03..9413fe66 100644
>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> @@ -486,7 +486,11 @@
>> #
>> # Display-related.
>> #
>> -
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>
>> +
>> + #
>> + # Just enable native resolution by default.
>> + #
>> +
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>
>>
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>
>> #
>>
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
>
> For the series:
> Tested-by: Pete Batard <pete@akeo.ie>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-11 10:58 ` Pete Batard
@ 2020-05-11 11:06 ` Ard Biesheuvel
2020-05-11 11:38 ` Pete Batard
0 siblings, 1 reply; 8+ messages in thread
From: Ard Biesheuvel @ 2020-05-11 11:06 UTC (permalink / raw)
To: Pete Batard, Andrei Warkentin, devel; +Cc: leif, philmd
On 5/11/20 12:58 PM, Pete Batard wrote:
> On 2020.05.10 22:36, Andrei Warkentin wrote:
>> The scaled resolutions are useful, but are not the default expected
>> by most users. Linux and BSDs don't set preferred resolution in
>> their OS loader, so when booting via setup UI, the OS is left
>> running at 800x600, not the native resolution. This looks crummy.
>>
>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>> ---
>> Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
>> Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> index a138c874..8dd4cbff 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> @@ -471,7 +471,11 @@
>> #
>> # Display-related.
>> #
>> -
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>
>> +
>> + #
>> + # Just enable native resolution by default.
>> + #
>> +
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>
>>
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>
>> #
>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> index 75867f03..9413fe66 100644
>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> @@ -486,7 +486,11 @@
>> #
>> # Display-related.
>> #
>> -
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>
>> +
>> + #
>> + # Just enable native resolution by default.
>> + #
>> +
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>
>>
>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>
>> #
>>
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
>
> For the series:
> Tested-by: Pete Batard <pete@akeo.ie>
Thanks Pete.
What do you mean by series? This is patch 1/1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-11 11:06 ` Ard Biesheuvel
@ 2020-05-11 11:38 ` Pete Batard
0 siblings, 0 replies; 8+ messages in thread
From: Pete Batard @ 2020-05-11 11:38 UTC (permalink / raw)
To: Ard Biesheuvel, Andrei Warkentin, devel; +Cc: leif, philmd
On 2020.05.11 12:06, Ard Biesheuvel wrote:
> On 5/11/20 12:58 PM, Pete Batard wrote:
>> On 2020.05.10 22:36, Andrei Warkentin wrote:
>>> The scaled resolutions are useful, but are not the default expected
>>> by most users. Linux and BSDs don't set preferred resolution in
>>> their OS loader, so when booting via setup UI, the OS is left
>>> running at 800x600, not the native resolution. This looks crummy.
>>>
>>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>>> ---
>>> Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
>>> Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> index a138c874..8dd4cbff 100644
>>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> @@ -471,7 +471,11 @@
>>> #
>>> # Display-related.
>>> #
>>> -
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>>
>>> +
>>> + #
>>> + # Just enable native resolution by default.
>>> + #
>>> +
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>>
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>>
>>> #
>>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> index 75867f03..9413fe66 100644
>>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> @@ -486,7 +486,11 @@
>>> #
>>> # Display-related.
>>> #
>>> -
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f
>>>
>>> +
>>> + #
>>> + # Just enable native resolution by default.
>>> + #
>>> +
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20
>>>
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1
>>>
>>> #
>>>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>> For the series:
>> Tested-by: Pete Batard <pete@akeo.ie>
>
> Thanks Pete.
>
> What do you mean by series? This is patch 1/1
>
My bad, I treated the previous 2 and this one as a 3 patches series.
/Pete
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-11 11:00 ` [edk2-devel] " Pete Batard
@ 2020-05-11 11:56 ` Ard Biesheuvel
2020-05-11 12:07 ` Pete Batard
0 siblings, 1 reply; 8+ messages in thread
From: Ard Biesheuvel @ 2020-05-11 11:56 UTC (permalink / raw)
To: Pete Batard, devel, Andrei Warkentin; +Cc: leif, philmd
On 5/11/20 1:00 PM, Pete Batard wrote:
> Actually forgot one thing on this one:
> Subject line should say "RPi" not "RPi3" since it affects both Pi's.
>
OK. I fixed that up.
For future patches, could you please start adding 'Platform/RaspberryPi'
in full? I have to fix that up manually every time, and sometimes I forget.
This patch pushed as d492639638ee..bfa32ac70a75
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-11 11:56 ` Ard Biesheuvel
@ 2020-05-11 12:07 ` Pete Batard
2020-05-11 12:08 ` Ard Biesheuvel
0 siblings, 1 reply; 8+ messages in thread
From: Pete Batard @ 2020-05-11 12:07 UTC (permalink / raw)
To: Ard Biesheuvel, devel, Andrei Warkentin; +Cc: leif, philmd
On 2020.05.11 12:56, Ard Biesheuvel wrote:
> On 5/11/20 1:00 PM, Pete Batard wrote:
>> Actually forgot one thing on this one:
>> Subject line should say "RPi" not "RPi3" since it affects both Pi's.
>>
>
> OK. I fixed that up.
>
> For future patches, could you please start adding 'Platform/RaspberryPi'
> in full? I have to fix that up manually every time, and sometimes I forget.
Got it. Do you want full 'Platform/RaspberryPi' or is shortening to
'Platform/RPi' okay?
> This patch pushed as d492639638ee..bfa32ac70a75
Thanks.
/Pete
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode
2020-05-11 12:07 ` Pete Batard
@ 2020-05-11 12:08 ` Ard Biesheuvel
0 siblings, 0 replies; 8+ messages in thread
From: Ard Biesheuvel @ 2020-05-11 12:08 UTC (permalink / raw)
To: Pete Batard, devel, Andrei Warkentin; +Cc: leif, philmd
On 5/11/20 2:07 PM, Pete Batard wrote:
> On 2020.05.11 12:56, Ard Biesheuvel wrote:
>> On 5/11/20 1:00 PM, Pete Batard wrote:
>>> Actually forgot one thing on this one:
>>> Subject line should say "RPi" not "RPi3" since it affects both Pi's.
>>>
>>
>> OK. I fixed that up.
>>
>> For future patches, could you please start adding
>> 'Platform/RaspberryPi' in full? I have to fix that up manually every
>> time, and sometimes I forget.
>
> Got it. Do you want full 'Platform/RaspberryPi' or is shortening to
> 'Platform/RPi' okay?
>
The former is preferred, but if you run out of space for a meaningful
subject, the latter is acceptable as well.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-11 12:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-10 21:36 [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode Andrei Warkentin
2020-05-11 10:58 ` Pete Batard
2020-05-11 11:06 ` Ard Biesheuvel
2020-05-11 11:38 ` Pete Batard
[not found] ` <160DF42BB1B94275.21511@groups.io>
2020-05-11 11:00 ` [edk2-devel] " Pete Batard
2020-05-11 11:56 ` Ard Biesheuvel
2020-05-11 12:07 ` Pete Batard
2020-05-11 12:08 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox