Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

["Laszlo Ersek" <lersek@redhat.com>]

On 10/18/23 10:57, Ard Biesheuvel wrote:
> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
> <yuinyee.chew@starfivetech.com> wrote:
>>
>> Dear Maintainers,
>>
>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>
> 
> Thanks for the reminder. I don't have time to review this myself but
> I'm happy to merge it if someone else reviews it

Heinrich gave an Acked-by up-thread.

(I'd just go ahead and merge this myself to help you out a bit, but I
don't have access to the original patch!)

Laszlo


> 
> 
>>
>> -----Original Message-----
>> From: YuinYee Chew
>> Sent: Friday, September 29, 2023 9:35 PM
>> To: 'Heinrich Schuchardt' <heinrich.schuchardt@canonical.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
>> Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>>
>> Hi Heinrich,
>>
>> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
>> gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html
>> gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e
>> So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e".
>> If sync with Linux, gd25lq128d will be better.
>>
>> Do you have any suggestion on this?
>> Or anyone have any opinion?
>>
>> Thanks again for the feedback! =)
>>
>> -----Original Message-----
>> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> Sent: Friday, September 29, 2023 4:55 PM
>> To: YuinYee Chew <yuinyee.chew@starfivetech.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
>> Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>>
>> On 9/29/23 04:02, John Chew wrote:
>>> Update Gigadevice norflash list:
>>> gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
>>>
>>> Add Silicon Kaiser norflash list:
>>> sk25lp128
>>>
>>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>>> Cc: Li Yong <yong.li@intel.com>
>>> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Abner Chang <abner.chang@amd.com>
>>> Cc: Daniel Schaefer <git@danielschaefer.me>
>>> Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
>>> ---
>>>   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> index e16c1c6a14..422fdac851 100644
>>> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> @@ -1,6 +1,7 @@
>>>   /** @file
>>>   *
>>>   *  Copyright (c) 2017 Marvell International Ltd.
>>> +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights
>>> +reserved.<BR>
>>>   *
>>>   *  SPDX-License-Identifier: BSD-2-Clause-Patent
>>>   *
>>> @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
>>>     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>>>     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>>>     /* GIGADEVICE */
>>> -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>>>     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>
>> Linux calls this gd25q64 but probably we don't want to change the displayed name.
>>
>>> +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>
>> Linux calls this gd25lq128d.
>>
>>> +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },
>>
>> Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux.
>>
>>>     /* ISSI */
>>>     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
>>>     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>>>     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>>> +  /* XINKAI / SILICON KAISER */
>>> +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>
>> This matches
>> https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/
>>
>> Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>
>>
>>>     /* MACRONIX */
>>>     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
>>>     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },
>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109832): https://edk2.groups.io/g/devel/message/109832
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-