From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 308E87803CC for ; Fri, 20 Oct 2023 09:49:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pz9ee9tsaxZAOS0hllXXpeOZEDEI9rDq+NuUuQZ9TP4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697795380; v=1; b=K9oPfDlEd8taa8mVL+xQwdI0iV2O3MshPrVpgC2xtELbiiz7XzcmXxyDW9p0UYIAcWJSHBHB 6qrPGc8nosPtWC+isnbSTJYjBlSj3JB8ZuWeDP/w+Mh4Zg1OefD6s/6qtsM3K1T7I6h6ErS98Yk 8HEbrJPTids44TMLBva5QQiY= X-Received: by 127.0.0.2 with SMTP id teSMYY7687511xuBWekHDCgS; Fri, 20 Oct 2023 02:49:40 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.50720.1697795379721012313 for ; Fri, 20 Oct 2023 02:49:40 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-578-uMyHy4x_NgGwT9Oq2Du5rQ-1; Fri, 20 Oct 2023 05:49:33 -0400 X-MC-Unique: uMyHy4x_NgGwT9Oq2Du5rQ-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFDE1381CC18; Fri, 20 Oct 2023 09:49:32 +0000 (UTC) X-Received: from [10.39.194.108] (unknown [10.39.194.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C4A7492BFC; Fri, 20 Oct 2023 09:49:30 +0000 (UTC) Message-ID: Date: Fri, 20 Oct 2023 11:49:29 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list To: devel@edk2.groups.io, ardb@kernel.org, YuinYee Chew Cc: Sunil V L , Li Yong , Heinrich Schuchardt , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer References: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> <4487065a-ac8f-4a73-a3e5-b7069df9e7d3@canonical.com> <7844b7331b5f42019dfdf3fc706671c0@EXMBX073.cuchost.com> <82caabf5e259418487d56236a817de42@EXMBX073.cuchost.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ID8OzhBhfJRaraUYR5m1Gkjux7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=K9oPfDlE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/18/23 10:57, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 10:49, YuinYee Chew > wrote: >> >> Dear Maintainers, >> >> Just a friendly reminder to ask if you could take a look at my patch. I'= d really appreciate your feedback and help. >> >=20 > Thanks for the reminder. I don't have time to review this myself but > I'm happy to merge it if someone else reviews it Heinrich gave an Acked-by up-thread. (I'd just go ahead and merge this myself to help you out a bit, but I don't have access to the original patch!) Laszlo >=20 >=20 >> >> -----Original Message----- >> From: YuinYee Chew >> Sent: Friday, September 29, 2023 9:35 PM >> To: 'Heinrich Schuchardt' >> Cc: Sunil V L ; Li Yong ; L= eif Lindholm ; Ard Biesheuvel ; Abner Chang ; Daniel Schaefer ; devel@edk2.groups.io >> Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash dev= ice list >> >> Hi Heinrich, >> >> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}" >> gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi= -nor-flash/gd25lq128d.html >> gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi= -nor-flash/gd25lq128e >> So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e". >> If sync with Linux, gd25lq128d will be better. >> >> Do you have any suggestion on this? >> Or anyone have any opinion? >> >> Thanks again for the feedback! =3D) >> >> -----Original Message----- >> From: Heinrich Schuchardt >> Sent: Friday, September 29, 2023 4:55 PM >> To: YuinYee Chew >> Cc: Sunil V L ; Li Yong ; L= eif Lindholm ; Ard Biesheuvel ; Abner Chang ; Daniel Schaefer ; devel@edk2.groups.io >> Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash dev= ice list >> >> On 9/29/23 04:02, John Chew wrote: >>> Update Gigadevice norflash list: >>> gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 >>> >>> Add Silicon Kaiser norflash list: >>> sk25lp128 >>> >>> Cc: Sunil V L >>> Cc: Li Yong >>> Cc: Heinrich Schuchardt >>> Cc: Leif Lindholm >>> Cc: Ard Biesheuvel >>> Cc: Abner Chang >>> Cc: Daniel Schaefer >>> Signed-off-by: John Chew >>> --- >>> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++= - >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >>> b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >>> index e16c1c6a14..422fdac851 100644 >>> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >>> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >>> @@ -1,6 +1,7 @@ >>> /** @file >>> * >>> * Copyright (c) 2017 Marvell International Ltd. >>> +* Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights >>> +reserved.
>>> * >>> * SPDX-License-Identifier: BSD-2-Clause-Patent >>> * >>> @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] =3D { >>> { L"en25q128b", { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024, 256,= 0 }, >>> { L"en25s64", { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024, 128,= 0 }, >>> /* GIGADEVICE */ >>> - { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, = NOR_FLASH_ERASE_4K }, >>> + { L"gd25q16", { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024, 32, = NOR_FLASH_ERASE_4K }, >>> + { L"gd25q32", { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024, 64, = NOR_FLASH_ERASE_4K }, >>> { L"gd25lq32", { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, = NOR_FLASH_ERASE_4K }, >>> + { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, = NOR_FLASH_ERASE_4K }, >> >> Linux calls this gd25q64 but probably we don't want to change the displa= yed name. >> >>> + { L"gd25lq64c", { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, = NOR_FLASH_ERASE_4K }, >>> + { L"gd25q128", { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024, 256, = NOR_FLASH_ERASE_4K }, >>> + { L"gd25lq128", { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, = NOR_FLASH_ERASE_4K }, >> >> Linux calls this gd25lq128d. >> >>> + { L"gd25q256", { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024, 512, = NOR_FLASH_ERASE_4K }, >> >> Except for the two labels the changes match drivers/mtd/spi-nor/gigadevi= ce.c in Linux. >> >>> /* ISSI */ >>> { L"is25lp032", { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, = 0 }, >>> { L"is25lp064", { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024, 128,= 0 }, >>> { L"is25lp128", { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024, 256,= 0 }, >>> + /* XINKAI / SILICON KAISER */ >>> + { L"sk25lp128", { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024, 256, = NOR_FLASH_ERASE_4K }, >> >> This matches >> https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/ >> >> Acked-by: Heinrich Schuchardt >> >> >>> /* MACRONIX */ >>> { L"mx25l2006e", { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024, 4, = 0 }, >>> { L"mx25l4005", { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024, 8, = 0 }, >> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109832): https://edk2.groups.io/g/devel/message/109832 Mute This Topic: https://groups.io/mt/101660590/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-