From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0056.outbound.protection.outlook.com [104.47.40.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2613521CFA5F7 for ; Wed, 16 Aug 2017 08:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8D3E8U5vp+IpIzUlgMS7sz6BHZZtbwjts1JwIGRLtCU=; b=bPCu7y7HzGzpRwP83Pr0EX6bvDofGKd2G+jX2HsT43E8Gzgi5bA9xmSa+vL1dSMi3zchoaBsyFgrbI3sG1rIliVvwa7UwIx3FzQLgqU+OXATUgTqKftS0npoOK8sCKQWrLscZdtJEc3qlC1JGpwn2xZpV5QJO9edH+yq2/aAxcg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.21; Wed, 16 Aug 2017 15:58:33 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-7-git-send-email-brijesh.singh@amd.com> <817088c8-f655-4589-5a88-95d87d851b7d@redhat.com> From: Brijesh Singh Message-ID: Date: Wed, 16 Aug 2017 10:58:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <817088c8-f655-4589-5a88-95d87d851b7d@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR11CA0006.namprd11.prod.outlook.com (10.172.17.16) To CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1509dfc4-8f45-484b-2af7-08d4e4bfa61b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0150; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 3:ESvyaLmr6rllfPQFUI43e3iiw0s1kDyPPcfNwgNOWJILcCQDY7J2Ip2Sha7IdkqlmPv96IXswCoGkvBuMnwiN8qYy4WDSgPo2bfLtY0L6l2SO9RjPrGbQprtAKhxWSyxJH5gMOhQi+1ePfrjuXHD8QnDrEtX/Cl4qG+4tEHqXO5fvPf5J6qjl9ejxOPKZum6iW1bqU6un3gmFqE4fBSK9d+Td5gj9ESPhaWkJ/RptTQH4CUwTZFW0A5dnwkG2ETB; 25:W5zh47xOgBjYPr65XXCCqVlOHHczlCiGjA+kb52V+UAWovzDkhy95DLJoMUB+4Do5kErQMp5VITx1kxjxd01JHpIyuwFvU0pO40CJm+WUgW1/uzH9lEyaLJA30FpI9eTseCeP8Pyeh+tz32rEqMF/+M57umG7I6V5pFpXIInu3lFABcOyfA0CgA0uvMnBSZR6V+/T/YhU0o1Sh/y89UpGk25lQiGtOpd2vLpQShk/PLC+4xkbwldK+B3fo+18lO+aAO7MJL86pOc3iqCLAD69CBnCmsP8G9ixhwdmAIH9dUcnwXYopW1etcFDM22Oleg++dL8fDe/xSW95bNdQswQQ==; 31:IDLDlYO7TSVznTRh9agAKNNwa/4w50WGzQYqpl43Fb4EZlntbMdJPDFjkGIJIqhs81Z/MVNJFfh+pNNUf0ttHP6KTTn9llmCY/mMODMAkKBWd+OeLjRHjvl80NOGg6bMmYo7ow2+HxihRDX33kMqNwLaClz8GmyRaqvMT0MAsENQ7eA1HcXaFnGAgqr8RGHPD1X7NIxdIX6BLEdopGVIIeGz/YVuJsZrBvfkbcPR/QY= X-MS-TrafficTypeDiagnostic: CY1PR12MB0150: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 20:Tf1sbWL3WPo2SMWLPI250WtXhGsntouLU9oGRFCU042APgs9Uhdycs6/dxgZVw11eX0vCwOeiJN267pLEwDezmm8//CCUaig9gPh3mahF3OpEdGtGFE5KYRK5G2d0VlEPesdWNUlKYARSYF1LaX1qnAoy6IbItSMIQq0wgOn6SuEekvnVtW6jXiXoBeoeqnt4Ze8D0RSpQbDLHsB+BDmvX7QdE8RakAn5fhDIrlaf492p5pxNsUaxygxAccg79mWq6nRvfwbqri9/q319+YxFuWiWWl7HyfCxKBokJWDzZFvYTY2+SQK/RFRkzjLx7Kox3eTehaP6nsHzXZZKegvIjmPVn7x9pnxNC7LtH6WoBfF6PyT2QulQDnorc8iQlARbYuU0rsYeM9cqdUk2xOC24/tmkqUOFS98/aFwSCv5ceyBTpVfch9bCr6l23KfIb43VbhtiHZ2J40uydalPUW5B4Dk5oQeHid6C5odbXN3u/ccPDpnQ+ansVuKqrBZZna; 4:MPHZ5UcQ6H0qffX0b/ngNaBIPzfuzR5Pg5NKjc9nOkItkXOY+OKm1T2f5AeJziQ5EzoH7LOR1OnIxbsk/XrdJVGvERyUmZNbiqNCFFlZXwh5iIpKcoMiEgZJj2/j4h0wsjKetUKY9Q/KzcRo9KiwXXFQkCBbQ6YP+vXp0hlLqrnZRuyrChaoR1BeAW/+skn3fpp5c13RlJlvGqkkBd/XcnTLHHsNTdV9hV/sEtSOlBMeBTlIy+0GpB0wpMREp27e X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0150; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0150; X-Forefront-PRVS: 0401647B7F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6049001)(6009001)(39860400002)(377454003)(199003)(24454002)(189002)(47776003)(33646002)(76176999)(54356999)(4326008)(53546010)(64126003)(50986999)(65956001)(66066001)(230700001)(25786009)(97736004)(65806001)(65826007)(77096006)(6486002)(5660300001)(106356001)(105586002)(90366009)(42186005)(68736007)(101416001)(6116002)(3846002)(189998001)(54906002)(23676002)(81166006)(229853002)(8676002)(81156014)(2950100002)(305945005)(7736002)(6246003)(4001350100001)(50466002)(110136004)(83506001)(53936002)(86362001)(6666003)(7350300001)(31696002)(478600001)(2906002)(31686004)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0150; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzIzOnZUSWpqaU9CSituck5FS1dqRVRLMkhXRjBY?= =?utf-8?B?Mld0cmlEZldTM1YvNGZEa09ZTGNkKzR6aGJUMlBuZ3ViRjcrSlFwaGdxcUJF?= =?utf-8?B?UHFhTDFOdlBCQnhsQ3hUbmRwVkJHZFZ5cWJuSmdRWEJaR2lTUjJvck8wVE9S?= =?utf-8?B?TTVaaTBGQm96cmFTbFJ4RUQ2TThuTSs5cFV2OGVYck9oT2Z0RDh6L0tpbTh6?= =?utf-8?B?RHhjakF2NE9MczlmaEs2QUpHNUg1dGM1MGxBYmIreEtFcTNhNzh1SnhmelBZ?= =?utf-8?B?Z2VyWTNOOXZVWkxHNUlCQTRqQ0hNY3d5OEF6cGdYeGlXSFNqTVpFelRSdVV0?= =?utf-8?B?M1BzZHV5aVdhbXFQK1dHaG1aRW9SSCtSMkFrTU5NZzVFZ29wYWV2OHlPNG1O?= =?utf-8?B?M1ozRGh0OUZXWnNwRlNyZ2IyQUdoblRzVFMxRzBSVHhmV3pvd0YwK3dmNXds?= =?utf-8?B?QklLUVl2V0pCc3NEVlRPcmxDN1YyZ0phR3dZL2FVazgrVEU0YjlZV0Z6NXZS?= =?utf-8?B?aE5jYzBPRk52ckgxOE9GR2VBd0pFWkl3a2c1RXg2RmRVMUVqTFJUSlZTbjN5?= =?utf-8?B?RTgwSXdoRVRpUjQzOHZka2l1UFBXanIzYnU4VVZ2OVFqYjBwNUhWejdqeVJF?= =?utf-8?B?RmdMMHYvYVBwN1RndFY2cDRrRlhPNjVubnV5Tzc5NmNOTDZscUxOQ3NVb2dN?= =?utf-8?B?Z0N2NlVKYmlseFQyUk9yWnJyNkt2clNENERYUjlSYzI0anZzSnpwWXBaZHFS?= =?utf-8?B?Wjc0dDdIVTJEdE5NQjBBZmRLSVlGTTJ5WVA5VVA3dmRudGQzbmRPMTBWOW4w?= =?utf-8?B?MkRvb0g5dCtkbnl6RXVjQXBpcDFDZHc0SmM3YkNGSnh3YTJ3ei94akdsaHo2?= =?utf-8?B?cnVjYUlURkJzYTg0S2JLNzdaZDd5TmhFYkg4RDdtTUo0K05kakt0ZGs3U2Zt?= =?utf-8?B?aGp3bGpwbExHOGlLT0h2QzBadkd0OWk0MlVNVWpGL01PaEEwUmNMZ1Q3VEUy?= =?utf-8?B?UlgxRjdtRWMxMjEwZVJxLy9IYk9DUERvc1JjeVlBY0o3QXI0U1BtWnFTbnZx?= =?utf-8?B?MExpRUprTFVEQi9sdFgzeGV0Y0NnOFJNaXgvWUh0Wmpjak9GNWhzTmFzeFhO?= =?utf-8?B?WEdpTWFNRURxTFFRaFZpeXE2OHJaR0trTkRnMWIrSlhmemkvdHRjWkZ4RWpl?= =?utf-8?B?cnJuVUV3UjdpdUZ6MmorU0RpWEtSQTVZTjFjbFhBNTV2S3RTL1pCOG54aE9w?= =?utf-8?B?cEtpVFliY2JxRE1aQVo2ZTRpdWU5enFnVGpQOXo3OE84eUlZSE9PM04zMTh1?= =?utf-8?B?NkpHU2xuUldEZWdNcDdBdVBNL3p0R0dJdk0xUlJpKzM0SGgxN2xUcC9jeUp6?= =?utf-8?B?WlhLekxZRHZuUWc1c05NZVlERkJ4d2o1Qksxcm5Lam03OUxrNGpuTDZydi9y?= =?utf-8?B?dENPdDdrR3YrMnFKd0hnUlIrTlBOS0xXcnBVQmxzeWZ5WGNSL2VsU2V5N3ZH?= =?utf-8?B?aGQvbUwraUdwNVBCanMvR1c3ZUxEZ2Q1SHh1SVZFT1hieXB3cnJsalBVR2JV?= =?utf-8?B?ZUlTS2p6b1VzQWR0bVB1aU1jaVI4S0VCektSdGNoV1pYMHJTZmVoaVptM09G?= =?utf-8?B?RTJEdUFLdzdYckM1L2V3NVJCbkJEbWUrS1U3SlJSblFLWXNSNllkU0dMVVJV?= =?utf-8?B?L1d2WXFpdkRPMW1BTUVRbmg4ajZYN1czTlE4SGV5K3k2TGhwaXMzTGI4aUtr?= =?utf-8?B?TS9jMml1L1ljRnJUM2Q4OXlKOFJmczRMM01kZGEvMlB5a005bnQ4VmFMOUVT?= =?utf-8?B?cjE5NFVPT2VCQ01TNzB6SGpaZitTdEtRdjAwSllFUE5pTHZVSWFvOE44Yi9Y?= =?utf-8?B?UkF5WGVGVlQzMDhza0FpeTZaUWJNb3ZJZS8vOGpaZVJJamNZcG94Y05ad1pV?= =?utf-8?B?bDYya2pVMlh3PT0=?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 6:E13mXhELm9PrdgFUQwkuoIRCwALPqJZPADcIOQtARpxJ2eXpCM7xh5vkKFcKuxjnK0Pfvhf319B3tTgfwbwvC27S5MsN+HiFhg188AY3pEwQmwqUUm2/PmbMY7F/jP5gJx9QepZCtPk0az6wTrgTtHdSCvgfXKYS6njyeZmsupGn8lQ10qNpKHfSINYGgauNei6LKIBSrwHj0Re1ZK0o8ibICg6+tgu7WUzu73J2dlteDMlRLVg1M902Q0/ArR1JfFD6RTbBlERMHPs17xjBxN/VI+olHWuBTZTylJoYkKUO/KJLchQLoX/m23yxKjH9h5VJcDuqQElhGSwb4x37dg==; 5:nI38LYsTC1sb2op0CADF4aseBfkGdslSC4V8RoXg+Z5vczMCbZbWTcWYrjcsCtTEcQQ7LgnoEOEiXVBeUmfGHtOIyiAymmgNaCI8eZb/cPN4LBpKJp4xMTbKvXe3SO+64RDHVC+DUnBH7hUo7jyR3w==; 24:4oB0kawyWjJr8VwZTFvnOntWpCCNTHaZl7aofdMmDihImMNVLH7B+21N/MOmxaAhQQ0An2rBkSvkbHue+s8RwHY+9Np/+7LaYiKNJ6hkdAQ=; 7:UYaJ4b7sbfA7zHIVJ2u2nx/bCK+KRK2nSE7L+mUYlQqONpLHbYEgtcxE4bavtbn6hkDNyhU0BwjwPgZ5DMdufT44mi9gQVVbfjUVoVhTmobkg2NWm3/bCZag2Im5Iou6ccsLq0Xsit0IOCIDfIXJOBrrs260a+jCU1PLNgpdrA4KXNNNXIUYQye5SvqRvdTjQYl74wBqiumyvGx4zY8LvDMcbjdzFwg99iu7OpFJX6I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 20:XRnDZdIvVnH4KKRyXnFA5URzFNLrIi+VurvNTumjomqRAvTOWzq/4n8yKnDFwFsG+5XE4ltHSoLjPZbIHf8/XW5V6cQR7+h01JWypP8mVBKKzplAoz29+R9TNmj1cejkkdAANFKQzGMtfWCLRj0E16F/iQgGSf/5dIXdJIEX7UuRbCvDubD5USeb0n8kLHp89jdO6fA2SJqatOkHKgSUdYMLko/VTrn53NcIYVm2YRrYK7xHDus/HGfkq9HL8bUO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 15:58:33.5579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0150 Subject: Re: [PATCH v2 06/23] OvmfPkg/Virtio: introduce IOMMU-like member functions to VIRTIO_DEVICE_PROTOCOL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 15:56:10 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/16/2017 09:37 AM, Laszlo Ersek wrote: > (1) In my previous review (msgid > ) point (1), I > suggested the following subject line: > > "OvmfPkg: introduce IOMMU-like member functions to VIRTIO_DEVICE_PROTOCOL" > > This subject was 72 characters long (within the 74 chars limit). > > Your current subject is: > > "OvmfPkg/Virtio: introduce IOMMU-like member functions to > VIRTIO_DEVICE_PROTOCOL" > > It is too long (79 chars). > > So please drop the "/Virtio" string, as I requested. > Will do > On 08/14/17 13:36, Brijesh Singh wrote: >> The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new >> member functions: >> >> - AllocateSharedPages : allocate a memory region suitable for sharing >> between guest and hypervisor (e.g ring buffer). >> >> - FreeSharedPages: free the memory allocated using AllocateSharedPages (). >> >> - MapSharedBuffer: map a host address to device address suitable to share >> with device for bus master operations. >> >> - UnmapSharedBuffer: unmap the device address obtained through the >> MapSharedBuffer(). > > (2) You missed point (20) of my above-referenced v1 review. Again, > please append the following to the commit message: > > --------- > We're free to extend the protocol structure without changing the > protocol GUID, or bumping any protocol version fields (of which we > currently have none), because VIRTIO_DEVICE_PROTOCOL is internal to edk2 > by design -- see the disclaimers in "VirtioDevice.h". > --------- > I will add this text in commit message. [snip] > > (3) s/taken/token/ I think I will have his error in all the place (due to copy/paste). I will go through each patches and fix them all. -Brijesh