From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web11.131025.1673744564343871299 for ; Sat, 14 Jan 2023 17:02:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=ogwMjkRE; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AD40F5C007A; Sat, 14 Jan 2023 20:02:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 14 Jan 2023 20:02:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1673744563; x= 1673830963; bh=yNuJeBnJnjzsLCwjyZXLfcPfnKpzM3mS0XmELrUbAmw=; b=o gwMjkREfyd/MAT3q87K3hQeoE42KkXQ4oQBHHOdZQ6AxEsBLuUaf0pskxJ/NzJzQ 7X8q+plpn57fAWSXWmPDCSofMVOBLMay1Ju7b6bawVKHhpHawZ7ZRW5Q4tSYilD5 eVS7MNA5Q5puvRt0DXFrE/ez8bQkdHoqI00kWGN/gvRHCYJUqvKy5bdDUU9kd7/O ZWy+nAcYscNCbX4U+rP7rShoBPNEU8+SvP2TttuMR7LIDGbIUmXVxOUCwLuwDd23 kNVrzMG/OPRoW04w52Y6XwohiRLuL8ER6iA/c7H5kXfSm9uIEdKFFkAezYN9RvDS ZWKTUS1a0T0kBSr6zXOmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673744563; x= 1673830963; bh=yNuJeBnJnjzsLCwjyZXLfcPfnKpzM3mS0XmELrUbAmw=; b=c byvKxTd+PyjGtXpge8biclYJR8YD5+bnJjvI0jZ3UPNqyfYX/KE1FHs4QfDklHIe Bi4v7EEBgl3kf6GVgBLDD7XSpCfXZt6yV/F9EDTSRO7yYzr6aeXUcwB3Uws/cuqG I81m1mTm68pFjaB0QLZK5oCmW1CFUfXMBfsG2XzLQB0GfjyLP4Ve/7AxtqlFRQRp 4+a+KEt5QQn+dcl3f1GYarhOefEOV4PU73j/nNlBMIGZgsHZFQPk9eb0LChoKQlP naL/vNq7cdOxBYIVlJWX5tPWQQq8s6gQ4Mbg7Ta6dnEnuVpnq478P9crLY/LckTd i48XSPeFCtj7i1spPvyJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtuddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 14 Jan 2023 20:02:41 -0500 (EST) Message-ID: Date: Sat, 14 Jan 2023 18:02:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application To: devel@edk2.groups.io, ray.ni@intel.com, Ard Biesheuvel , "quic_rcran@quicinc.com" Cc: Kun Qin , Sami Mujawar , Ard Biesheuvel , Leif Lindholm , "Wang, Jian J" , "Gao, Liming" , Tiger Liu References: <20230104153727.345236-1-rebecca@quicinc.com> <20230104153727.345236-4-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This is the current output of the EfiMpServiceProtocolShellUnitTest. Many of the failures appear to be because one of the tests runs an infinite loop on the APs, and so subsequent requests to power them on fail because they're already running: FS0:\> MpProtocolUnitTest.efi InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B FCBC0DC0 add-symbol-file /home/rcran/src/upstream/uefi/Build/ArmJuno/NOOPT_GCC5/AARCH64/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolShellUnitTest/DEBUG/MpProtocolUnitTest.dll 0xF8E7D000 Loading driver at 0x000F8E7C000 EntryPoint=0x000F8E7D000 MpProtocolUnitTest.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF FCBC0B18 ProtectUefiImageCommon - 0xFCBC0DC0 - 0x00000000F8E7C000 - 0x0000000000014000 SetUefiImageMemoryAttributes - 0x00000000F8E7C000 - 0x0000000000001000 (0x0000000000004008) SetUefiImageMemoryAttributes - 0x00000000F8E7D000 - 0x0000000000011000 (0x0000000000020008) SetUefiImageMemoryAttributes - 0x00000000F8E8E000 - 0x0000000000002000 (0x0000000000004008) InstallProtocolInterface: 752F3136-4E16-4FDC-A22A-E5F46812F4CA FEFFF2A0 EfiMpServiceProtocol Unit Test v0.1 Adding Common Test case Running All Test Suites InitUTContext: BspNumber = 0x2 InitUTContext: NumberOfProcessors = 0x6, NumberOfEnabledProcessors = 0x6 NumberOfDisabledAPs: 0 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 PSCI_CPU_ON call failed: -4 CheckUTContext: New NumberOfEnabledProcessors = 0x5 CheckUTContext: AP(0x0) is disabled unexpectedly and reenable it. SaveFrameworkState - Could not save state! Unsupported --------------------------------------------------------- ------------- UNIT TEST FRAMEWORK RESULTS --------------- --------------------------------------------------------- ///////////////////////////////////////////////////////// SUITE: Identify the currently executing processor PACKAGE: MpServices.WhoAmI ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestWhoAmI1 TEST: Test WhoAmI 1 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 1 (100) Failed: 0 (0) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Retrieve the number of logical processor PACKAGE: MpServices.GetNumberOfProcessors ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestGetNumberOfProcessors1 TEST: Test GetNumberOfProcessors 1 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestGetNumberOfProcessors2 TEST: Test GetNumberOfProcessors 2 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestGetNumberOfProcessors3 TEST: Test GetNumberOfProcessors 3 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 3 (100) Failed: 0 (0) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Get detailed information on the requested logical processor PACKAGE: MpServices.GetProcessorInfo ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestGetProcessorInfo1 TEST: Test GetProcessorInfo 1 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestGetProcessorInfo2 TEST: Test GetProcessorInfo 2 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 2 (100) Failed: 0 (0) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Caller enables or disables an AP from this point onward PACKAGE: MpServices.EnableDisableAP ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestEnableDisableAP1 TEST: Test EnableDisableAP 1 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestEnableDisableAP2 TEST: Test EnableDisableAP 2 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestEnableDisableAP3 TEST: Test EnableDisableAP 3 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 3 (100) Failed: 0 (0) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Get the requested AP to execute a caller-provided function PACKAGE: MpServices.StartupThisAP ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestStartupThisAP1 TEST: Test StartupThisAP 1 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestStartupThisAP2 TEST: Test StartupThisAP 2 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestStartupThisAP3 TEST: Test StartupThisAP 3 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** ********************************************************* CLASS NAME: TestStartupThisAP4 TEST: Test StartupThisAP 4 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1118 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1118: Status 'Status' is EFI_ERROR (Unsupported)! ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 3 (75) Failed: 1 (25) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Execute a caller provided function on all enabled APs PACKAGE: MpServices.StartupAllAPs ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestStartupAllAPs1 TEST: Test StartupAllAPs 1 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1181 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1181: Status 'Status' is EFI_ERROR (Not Ready)! ********************************************************** ********************************************************* CLASS NAME: TestStartupAllAPs2 TEST: Test StartupAllAPs 2 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1224 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1224: Status 'Status' is EFI_ERROR (Not Ready)! ********************************************************** ********************************************************* CLASS NAME: TestStartupAllAPs3 TEST: Test StartupAllAPs 3 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1275 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1275: Status 'Status' is EFI_ERROR (Not Ready)! ********************************************************** ********************************************************* CLASS NAME: TestStartupAllAPs4 TEST: Test StartupAllAPs 4 STATUS: FAILED FAILURE: ASSERT_STATUSEQUAL FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1311 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1311: Status 'Status' is Not Ready, should be Time out! ********************************************************** ********************************************************* CLASS NAME: TestStartupAllAPs5 TEST: Test StartupAllAPs 5 STATUS: PASSED FAILURE: NO FAILURE FAILURE MESSAGE: ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 1 (20) Failed: 4 (80) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ///////////////////////////////////////////////////////// SUITE: Switch the requested AP to be the BSP from that point onward PACKAGE: MpServices.SwitchBSP ///////////////////////////////////////////////////////// ********************************************************* CLASS NAME: TestSwitchBSP1 TEST: Test SwitchBSP 1 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1426 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1426: Status 'Status' is EFI_ERROR (Unsupported)! ********************************************************** ********************************************************* CLASS NAME: TestSwitchBSP2 TEST: Test SwitchBSP 2 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1492 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1492: Status 'Status' is EFI_ERROR (Not Ready)! ********************************************************** ********************************************************* CLASS NAME: TestSwitchBSP3 TEST: Test SwitchBSP 3 STATUS: FAILED FAILURE: ASSERT_STATUSEQUAL FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1540 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1540: Status 'Status' is Unsupported, should be Invalid Parameter! ********************************************************** ********************************************************* CLASS NAME: TestSwitchBSP4 TEST: Test SwitchBSP 4 STATUS: FAILED FAILURE: ASSERT_NOTEFIERROR FAILURE FAILURE MESSAGE: /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1591 LOG: [ERROR] [ASSERT FAIL] /home/rcran/src/upstream/uefi/edk2/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommon.c:1591: Status 'Status' is EFI_ERROR (Unsupported)! ********************************************************** +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Suite Stats Passed: 0 (0) Failed: 4 (100) Not Run: 0 (0) +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ========================================================= Total Stats Passed: 13 (59) Failed: 9 (40) Not Run: 0 (0) ========================================================= SetUefiImageMemoryAttributes - 0x00000000F8E7C000 - 0x0000000000014000 (0x0000000000000008) remove-symbol-file /home/rcran/src/upstream/uefi/Build/ArmJuno/NOOPT_GCC5/AARCH64/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolShellUnitTest/DEBUG/MpProtocolUnitTest.dll 0xF8E7D000 On 1/9/23 18:08, Ni, Ray wrote: > UefiCpuPkg\Test\UnitTest\EfiMpServicesPpiProtocol\EfiMpServiceProtocolShellUnitTest.inf > can be used to build the shell app. > >> -----Original Message----- >> From: Ard Biesheuvel >> Sent: Tuesday, January 10, 2023 1:13 AM >> To: devel@edk2.groups.io; quic_rcran@quicinc.com >> Cc: Ni, Ray ; Kun Qin ; Sami Mujawar ; Ard Biesheuvel >> ; Leif Lindholm ; Wang, Jian J ; Gao, >> Liming ; Tiger Liu >> Subject: Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application >> >> On Mon, 9 Jan 2023 at 15:25, Rebecca Cran wrote: >>> >>> Thanks, I hadn't seen that. Unless people want the additional control >>> this application provides via the command-line options, I can drop this >>> patch. >>> >>> -- >>> Rebecca Cran >>> >>> On 1/8/23 18:32, Ni, Ray wrote: >>>> Rebecca, >>>> Have you reviewed UefiCpuPkg\Test\UnitTest\EfiMpServicesPpiProtocol? It's based on UnitTestFrameworkPkg for unit >> testing on MP PPI and MP protocol. >>>> Do you think if the MpServicesTest app and the EfiMpServicesPpiProtocol have some overlapped functionalities? >>>> >> >> Having a shell app to run against the MP services protocol is rather >> useful. Does a unit test provide the same functionality? >> >> I am not talking about CI here but about diagnostics on an actual system. > > > > >