Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build

["Laszlo Ersek" <lersek@redhat.com>]

On 10/07/20 04:15, Abner Chang wrote:
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
>  .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..89c632c0a7 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -31,7 +31,7 @@ jobs:
>          Build.Pkgs: 'MdeModulePkg'
>          Build.Targets: 'RELEASE,NO-TARGET'
>        TARGET_NETWORK:
> -        Build.Pkgs: 'NetworkPkg'
> +        Build.Pkgs: 'NetworkPkg,RedfishPkg'
>          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>        TARGET_OTHER:
>          Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
>

I'd like Sean and/or Bret to re-review this patch, because the related
subthread in the v5 review session seems to have ended with an open
question about NetworkPkg.

https://edk2.groups.io/g/devel/message/65948
http://mid.mail-archive.com/CS1PR8401MB1144EF23CAAF9AF8A147D874FF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM

It would also be nice to have *some* explanation in the commit message
*why* we're coupling RedfishPkg with NetworkPkg specifically. I'm not
arguing against this coupling by any means, I'd just like to see it
explained.

If someone can propose a concise 1-2 paragraph explanation in response,
I'm happy to reword the commit message myself (including those
paragraphs), when I merge this (v6) series (with Sean's or Bret's
renewed approval of this patch).

Thanks!
Laszlo