From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.10448.1602068089067030941 for ; Wed, 07 Oct 2020 03:54:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Olx0icMw; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602068088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=asS1TkiO6QSe9YOYw3ijo4ifLkqdZuAXKchZ9Sc9n1U=; b=Olx0icMwogStydRDLr1Xe+oTpmgZbRVopg5qYr/rLIGPOoq/4BGMMEOq+MEqi2TsDGeJ39 mut0Nz71pB9L3WTZlit5zuwKbFg46OkB8D5Yxix5MM0KI9lUfoN5Z6FhpyyTijsofWMN+R /es4w+NTePF4k1J6ezW5Ks2y4riLI3c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-oGA1GK7KOMSOlhshmNRoOw-1; Wed, 07 Oct 2020 06:54:45 -0400 X-MC-Unique: oGA1GK7KOMSOlhshmNRoOw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78FF718A076D; Wed, 7 Oct 2020 10:54:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-94.ams2.redhat.com [10.36.113.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 818AA5D9DD; Wed, 7 Oct 2020 10:54:41 +0000 (UTC) Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Nickle Wang , "Leif Lindholm (Nuvia address)" References: <20201007021545.25936-1-abner.chang@hpe.com> <20201007021545.25936-4-abner.chang@hpe.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 7 Oct 2020 12:54:40 +0200 MIME-Version: 1.0 In-Reply-To: <20201007021545.25936-4-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/07/20 04:15, Abner Chang wrote: > Signed-off-by: Abner Chang > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Nickle Wang > Reviewed-by: Bret Barkelew > --- > .azurepipelines/templates/pr-gate-build-job.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml > index 2683687a1c..89c632c0a7 100644 > --- a/.azurepipelines/templates/pr-gate-build-job.yml > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > @@ -31,7 +31,7 @@ jobs: > Build.Pkgs: 'MdeModulePkg' > Build.Targets: 'RELEASE,NO-TARGET' > TARGET_NETWORK: > - Build.Pkgs: 'NetworkPkg' > + Build.Pkgs: 'NetworkPkg,RedfishPkg' > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > TARGET_OTHER: > Build.Pkgs: 'PcAtChipsetPkg,ShellPkg' > I'd like Sean and/or Bret to re-review this patch, because the related subthread in the v5 review session seems to have ended with an open question about NetworkPkg. https://edk2.groups.io/g/devel/message/65948 http://mid.mail-archive.com/CS1PR8401MB1144EF23CAAF9AF8A147D874FF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM It would also be nice to have *some* explanation in the commit message *why* we're coupling RedfishPkg with NetworkPkg specifically. I'm not arguing against this coupling by any means, I'd just like to see it explained. If someone can propose a concise 1-2 paragraph explanation in response, I'm happy to reword the commit message myself (including those paragraphs), when I merge this (v6) series (with Sean's or Bret's renewed approval of this patch). Thanks! Laszlo