From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id B71C6207E53F8
 for <edk2-devel@lists.01.org>; Thu, 24 May 2018 10:25:58 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 0BE8440BC048;
 Thu, 24 May 2018 17:25:58 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-84.rdu2.redhat.com
 [10.10.121.84])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 690512026985;
 Thu, 24 May 2018 17:25:57 +0000 (UTC)
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
 Jordan Justen <jordan.l.justen@intel.com>
References: <20180523202121.8125-1-lersek@redhat.com>
 <20180523202121.8125-2-lersek@redhat.com>
 <CAKv+Gu8iYBo9TedCG=b=0sp-rz_Dy90dOWvf94mGKqpVnnSi3w@mail.gmail.com>
 <79485048-7ee5-c3ee-40b6-25f0eeb46ca6@redhat.com>
 <CAKv+Gu982zzm4YSaEkLT0CPb9x0OMh+PUqTE3QVjFLGQeon9hg@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <dc2f8bdd-e0b7-fcee-1730-0d348f51d1ac@redhat.com>
Date: Thu, 24 May 2018 19:25:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu982zzm4YSaEkLT0CPb9x0OMh+PUqTE3QVjFLGQeon9hg@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Thu, 24 May 2018 17:25:58 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Thu, 24 May 2018 17:25:58 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v2 1/7] OvmfPkg: introduce PciCapLib
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 17:25:58 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/24/18 16:41, Ard Biesheuvel wrote:
> On 24 May 2018 at 16:39, Laszlo Ersek <lersek@redhat.com> wrote:
>> On 05/24/18 09:53, Ard Biesheuvel wrote:

>>>> +RETURN_STATUS
>>>> +EFIAPI
>>>> +PciCapGetInfo (
>>>> +  IN  PCI_CAP      *Cap,
>>>> +  OUT PCI_CAP_INFO *Info
>>>> +  )
>>>> +{
>>>> +  PCI_CAP *InstanceZero;
>>>> +
>>>
>>> Nit: add
>>>
>>> ASSERT (Info != NULL);
>>>
>>> here?
>>>
>>> I know it seems rather arbitrary to add it here and not anywhere else,
>>> but PciCapGetInfo() is part of the API, and dereferencing Info [which
>>> may be the result of e.g., a pool allocation] for writing is
>>> particularly bad.
>>
>>
>> I will add the ASSERT().
>>
>> (I hope I didn't miss any of your comments!)
>>
> 
> It's just a nit, feel free to ignore.
> 
> In any case,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 

Thanks! I'll add the ASSERT.
Laszlo