public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, devel@edk2.groups.io
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Use physical address with SEV-ES
Date: Sat, 23 Jan 2021 01:25:35 +0100	[thread overview]
Message-ID: <dc56cff4-ec34-0c58-05a8-dfd2a2ae3924@redhat.com> (raw)
In-Reply-To: <e7b4494a-134c-0b1b-b67a-4e4b82ae3e3d@amd.com>

On 01/22/21 23:40, Tom Lendacky wrote:

> Can SetVirtualAddressMap() be called more than once?

According to the UEFI spec: no, it can't.

    The call to SetVirtualAddressMap() must be done with the physical
    mappings. On successful return from this function, the system must
    then make any future calls with the newly assigned virtual mappings.

    [...]

    The SetVirtualAddressMap() and ConvertPointer() services are only
    callable in physical mode, so they do not need to be converted from
    physical pointers to virtual pointers.

    [...]

    A virtual address map may only be applied one time. Once the runtime
    system is in virtual mode, calls to this function return
    EFI_UNSUPPORTED.

(I seem to detect a bit of contradiction between quotes #1+#2 and #3 --
the first two quotes seem to explain that a second call is expected to
be impossible, whereas the third quote explains how a second or later
call should behave. But, anyway, the intent is clear.)

Thanks,
Laszlo


  reply	other threads:[~2021-01-23  0:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 17:55 [PATCH] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Use physical address with SEV-ES Lendacky, Thomas
2021-01-22 22:29 ` [edk2-devel] " Laszlo Ersek
2021-01-22 22:40   ` Lendacky, Thomas
2021-01-23  0:25     ` Laszlo Ersek [this message]
2021-01-23  1:29       ` Andrew Fish
2021-01-23  2:24         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc56cff4-ec34-0c58-05a8-dfd2a2ae3924@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox