From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 09 Apr 2019 00:21:47 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1EB63084031; Tue, 9 Apr 2019 07:21:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-114.rdu2.redhat.com [10.10.120.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0626363F9B; Tue, 9 Apr 2019 07:21:45 +0000 (UTC) Subject: Re: [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h To: "Zhang, Shenglei" , "devel@edk2.groups.io" Cc: "Justen, Jordan L" References: <20190329014126.20208-1-shenglei.zhang@intel.com> <20190329014126.20208-2-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 9 Apr 2019 09:21:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 09 Apr 2019 07:21:47 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/09/19 03:07, Zhang, Shenglei wrote: > Hi All, > > I'd like to know if you have any comment on this change. > > Thanks, > Shenglei I reviewed your patch eight (8) days ago. http://mid.mail-archive.com/8ef11c83-27ed-6b0f-9b56-fb628bab1915@redhat.com https://lists.01.org/pipermail/edk2-devel/2019-April/038462.html My review email was addressed to you as well ("Shenglei Zhang "), not just the list. Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Shenglei Zhang >> Sent: Friday, March 29, 2019 9:41 AM >> To: edk2-devel@lists.01.org >> Cc: Justen, Jordan L ; Laszlo Ersek >> >> Subject: [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove >> dependency on Mps.h >> >> Mps.h is included in BdsPlatform.h but not actually used. >> So remove it. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Shenglei Zhang >> --- >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> index 4948ca6518..d6dfe1e697 100644 >> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> @@ -63,7 +63,6 @@ Abstract: >> >> #include >> #include >> -#include >> #include >> #include >> #include >> -- >> 2.18.0.windows.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel