From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.481.1587746915033529408 for ; Fri, 24 Apr 2020 09:48:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bZVgHzWV; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587746914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0FGTnCKSoSgXARYny6db2ucdCq37gPdT47xoHGSH84=; b=bZVgHzWVO3WAHjKQ12Tb7n7h9AzWAXir2E7KufCyiSDljGa3QEwbkaxJudyAOorjSwu2Th 9zgubYFDnv86cnMQd+ZHHRKUSZsJLT6dDN6pcQZwg8lGsHrCHxES17ppN6BfaamOFARN4G me8qhBpW9IBrNRExevuyTRXI2xGnHwI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-iXEV3uHrNA27x6WqieRrwg-1; Fri, 24 Apr 2020 12:48:30 -0400 X-MC-Unique: iXEV3uHrNA27x6WqieRrwg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3928800D24; Fri, 24 Apr 2020 16:48:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-159.ams2.redhat.com [10.36.113.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id A9DF95D9CC; Fri, 24 Apr 2020 16:48:27 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 2/2] BhyvePkg: Update BhyvePkgX64.dsc to use DxeResetSystemLibBhyve To: devel@edk2.groups.io, rebecca@bsdio.com, Jordan Justen , Ard Biesheuvel Cc: Peter Grehan References: <20200423030214.57861-1-rebecca@bsdio.com> <20200423030214.57861-3-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 24 Apr 2020 18:48:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200423030214.57861-3-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/23/20 05:02, Rebecca Cran wrote: > bhyve uses a different method for powering off guests than OVMF, so > use the new DxeResetSystemLibBhyve library to support that. > > Signed-off-by: Rebecca Cran > Cc: Peter Grehan > --- > BhyvePkg/BhyvePkgX64.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BhyvePkg/BhyvePkgX64.dsc b/BhyvePkg/BhyvePkgX64.dsc > index 51e565994c..554adeb9b9 100644 > --- a/BhyvePkg/BhyvePkgX64.dsc > +++ b/BhyvePkg/BhyvePkgX64.dsc > @@ -173,7 +173,7 @@ > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > !endif > > - ResetSystemLib|OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > + ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibBhyve.inf > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > IoApicLib|PcAtChipsetPkg/Library/BaseIoApicLib/BaseIoApicLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > This patch should be submitted later, because it depends on both your BhyvePkg series, and on patch#1 in this series. Further, under patch#1, I'm going to recommend to call this instance BaseResetSystemLibBhyve, not "Dxe...". I'll explain why under patch#1. Thanks Laszlo