public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Brown" <mcb30@ipxe.org>
To: Peter Grehan <grehan@freebsd.org>,
	devel@edk2.groups.io, c.koehne@beckhoff.com
Cc: "Patrick Brünn" <P.Bruenn@beckhoff.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"jordan.l.justen@intel.com" <jordan.l.justen@intel.com>,
	"rebecca@bsdio.com" <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/Bhyve: add USB support
Date: Fri, 2 Jul 2021 13:21:32 +0100	[thread overview]
Message-ID: <dc7a4092-764f-b7f1-5710-94ef8bb974cf@ipxe.org> (raw)
In-Reply-To: <848fb5ee-6e52-eed1-0b0d-39e4dda5c5dc@freebsd.org>

On 02/07/2021 00:31, Peter Grehan wrote:
>>>>>   bhyve doesn't (and will likely never) support Uhci/Ehci 
>>>>> controllers so those lines can be removed.
>>>>
>>>> Is it possible to pass such a controller by PCI-Passthrough to a VM?
>>>> If it's possible, I would keep these lines.
>>>
>>>   Uhci/Ehci only support legacy interrupts and that isn't supported 
>>> by bhyve PCI passthru.
>>
>> Is that a detail of the current implementation, or a fundamental 
>> limitation in the bhyve architecture?
> 
>   Only two choices ? :) Maybe half way between those points.

When there is no fundamental limitation, i.e. when a future version of 
the hypervisor may be able to support the feature with no changes to the 
firmware, then it would be good practice to leave the drivers enabled. 
Doing so avoids creating an unnecessarily tight coupling between the 
hypervisor and firmware versions.

More importantly: does it even matter that the hypervisor doesn't 
support passthrough of PCI legacy interrupts?  UEFI operates on a 
polling basis, with the only active interrupt being some kind of 
periodic timer.  Where do you see any requirement for legacy interrupts 
in the UHCI/EHCI drivers?

Thanks,

Michael

  reply	other threads:[~2021-07-02 12:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  6:05 [PATCH v2 0/2] Prepare bhyve for GPU-Passthrough Corvin Köhne
2021-06-24  6:05 ` [PATCH v2 1/2] OvmfPkg/Bhyve: add USB support Corvin Köhne
2021-06-29  3:14   ` Peter Grehan
2021-07-01  9:51     ` Corvin Köhne
2021-07-01 10:32       ` [edk2-devel] " Peter Grehan
2021-07-01 14:12         ` Michael Brown
2021-07-01 23:31           ` Peter Grehan
2021-07-02 12:21             ` Michael Brown [this message]
2021-07-02 13:55               ` Peter Grehan
2021-06-24  6:05 ` [PATCH v2 2/2] OvmfPkg/Bhyve: use static PCI32Base address Corvin Köhne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc7a4092-764f-b7f1-5710-94ef8bb974cf@ipxe.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox