From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.134]) by mx.groups.io with SMTP id smtpd.web10.40936.1683167624421676548 for ; Wed, 03 May 2023 19:33:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=QVVk7q0P; spf=pass (domain: os.amperecomputing.com, ip: 40.107.237.134, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbB17VZygnQxktaZSvi4+jkoUQe2s6xo+92I3QmCN5nOwj2cXcqD+lvj9TekrNtUIBOED2ylFy4YBzt1kwNdWEvdjmiG7GU8gIxm5yDgGO5HgJIyY4/NNPxfsRK1/JCCEoDV20SqDe0EkZB0pjFze9PZxk8Rhk59r3K4E0C3U5OqFk7t+1MD0hpLAt0dMt13sLYJXaR3s/xmvC3QBUaA0VR+rFggAaCDCeHqn558FP1e3lP96OtTUdbRVHwTsFT7aNTLMD56M40HJtI2NPWTcSXWRKsNvvU2vI4N/U8eXsfj1a9zkSIWX8mQdGUnkHccmbdomUEvj2+xaSMjI8JfTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rO+8AM6RX6RSw6s0ZjFu+XM/xAQNtfoVr+6KkvdshhY=; b=aSS1d+8OMFeOWXuBqDpCpwcB1Z69SvE01+Pr5P60MJTlFz30uyPe27RmJbUKaf79OHF/iC1j6nws/hgb+U4yzRiTRyBkyh/kbWKWl+a9R9o5b06sUtxohX43UZ9TGztrgHwlhNjOrJcUd66HS3ZpjNwNz7xsKov+dgQXYbC97GePJGai8f9r77eCn4VbqoUGNn+bQIG5ljpykn517sMLAwcM/uuNT7v7wJ/gGFml626742Vov6x+mPsu5mACVUCph4FFLSnsBrwiBbtiIwtoT4V2+ZTluYi9HGZkuhnu4NbQXTs2rC/L4jMyrDkPU0RrHRHdQblZXlIzJp2madp14Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rO+8AM6RX6RSw6s0ZjFu+XM/xAQNtfoVr+6KkvdshhY=; b=QVVk7q0PSAUP1hM/E7ObL7kqOjVYy5pwfChKsKWs1PPTgDboIlW1nx+lmukXDwBqJyGWEk2s3HvCFSHPIoxr6r0/Y2GiLnlB3pIA85R1PlBFnZD8V6Disv2Wx0q27RgveT9L5fwddefsw2VMQyrIAZpm+qAA+VWJZyRr9YrsqJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by BY3PR01MB6610.prod.exchangelabs.com (2603:10b6:a03:364::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 02:33:40 +0000 Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 02:33:39 +0000 Message-ID: Date: Thu, 4 May 2023 09:33:29 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg To: "Chang, Abner" , Minh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "nicklew@nvidia.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> From: Minh Nguyen In-Reply-To: X-ClientProxiedBy: SI2PR01CA0022.apcprd01.prod.exchangelabs.com (2603:1096:4:192::14) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|BY3PR01MB6610:EE_ X-MS-Office365-Filtering-Correlation-Id: 34503e34-9289-4d25-0bf8-08db4c47f81e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AVdyCk60kUjPVSyjik/WEZOHL0fBVDL3J3dPPMGev5fiVuuftLavZDMK9daoAxOcBIcQXyFFmu/qeFOzFHBe0iEu91P5dk+56vq9++El97oHroxNcweAX+JOmbb0oC+xeUZHa+oPlsyt3wUoeHGtAk6VHuI0G9znij70QosfAkKh8XW1ZAaYNgZpS7uu3BJLu9ED3cVdTF63sk/CP8GOLPyOUVX5GO01ATGZCaDiHqCoYUgc2T7NRojR+Nhj9c95PChDYBWIcUKs7zu9cyO4unE7lGU/mQWoXpLwfVQ/l7OKY1Ujt4ulDMj8bZz04x+QUI0tEqBsBCrvk8nwHBEpFv7359X4Mn9S6bB8vhaqSWkmQWRcB38H4EC3HerTw7j/u5n2wh1guQv5S8HG4ML7X1x9BCnbGZBKVJgCwGn3Sr8h9fALH6uzL/dig3qvb++qU2wpX9gCWg1+5C+uIP/eSoWbJpDFm6cBAb02djEK7Dxo+RDVKv77muCU7CcEDMdow++JaCPns0th9J1PNxQOc10f8SXHw/8taK3OTHcHHC+6vqktZxU7tMtSq6ibsIeX1Pp+hVcTkaXYzdUyET5As2uoVXPVhqOLgRRawu1n5AhhoSoUvvgq06U20iQwD6dI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB8048.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39850400004)(376002)(366004)(136003)(451199021)(54906003)(110136005)(107886003)(83380400001)(42882007)(31686004)(83170400001)(5660300002)(2616005)(26005)(6506007)(6512007)(38100700002)(53546011)(8676002)(8936002)(186003)(2906002)(6486002)(41300700001)(6666004)(31696002)(316002)(4326008)(66476007)(66556008)(66946007)(478600001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2FywFy2w06VQ6t+RK4v9r8JSuRVZtX/wFvybpvWgw8p+JTQnKTICVauL4lHO?= =?us-ascii?Q?dmpEJxPT2QiUFBdIx7yhZRQqISSjE/XA6bBxjLSuvUvLQPR4DE/ckSTmf0bw?= =?us-ascii?Q?vu9kvZPVQcZnBp7KC51bMY+HhaG/TerXfr/0Y1iNHr6oSw5dA2p2c0YSssLA?= =?us-ascii?Q?pgCWvQHGFOtr2u5rUJ5PC6q/t68p2XGeLswEu0E4bxV61qpupvaXEd2z69t4?= =?us-ascii?Q?QGQv14l8uFM8/5i8QYOMDa8t72987e9rKnaDFG3IOcjVYScNltgYBS25yqF6?= =?us-ascii?Q?9XEO3Q3HT5WnkX1QL0PLu3mPvlDmb55jhMZdR5qutGoRYv53PjZfeCCdosBe?= =?us-ascii?Q?NIpdN0HYAACEUYHN/+40NDP6zt2uhPM+ZIDfPxXLUgWUnOYnZ39PsVc1+bAG?= =?us-ascii?Q?LwNqMJJq2eO/HaknS3Yf2667e9MLmTLRz0jdlYqJkQiocTKVePluoUDoan2H?= =?us-ascii?Q?+gbqUnVmZ+yDtFRCk3TdWsdsVpIxF3KfjRYYTQKxy2edi1E5IwfBaUuLdr37?= =?us-ascii?Q?yEhiN2g1FVNBp89HhBkaDwyl8TBMZQdgCVG3AFGUOXo4bV9V437xUSa/Gv8J?= =?us-ascii?Q?ViRck7FiNOk4z5efiN7L/VUcPrHkx+BMdf3zP4a7IAmBerf0hZRaFNB+DtCF?= =?us-ascii?Q?X7CrCxFdFs5iGORvQEG6BoI7EAUBe33KtmFYH1cENI5C/TdNx/ojDC5gFFhY?= =?us-ascii?Q?6qZ7ROeRFY9omdBpjg127mV5RV2zE24dcTVqtH1RIG42t2xgDlkJXgBJdLc6?= =?us-ascii?Q?lSQLP842l27s6K7inodVyHt7RjCzhBy8gXXqSioefzvFOY6Squpu9Jr2tybw?= =?us-ascii?Q?SPXWHGbbuQqCkY4WFj3ur/qG7uHIsXKmDYjLnsbyEAwcKHXwJG+58x3hZJyE?= =?us-ascii?Q?tm4BLt0Hr+hyx/2mj71edsAjMFXoF3iPWTWvHWL7CDZtMvSaAPHYytegcGpM?= =?us-ascii?Q?4CguapHp5Fr5q9murbrHRqBro6uqQxwoOCFFBbTdgXQSR3lpI42AeZzTTOEy?= =?us-ascii?Q?A1Vyi5tlgVz8ol8CvfcUAndK9bUpWJhCsudfgGUJc1/dK6+ntQ0iUqdmUKCO?= =?us-ascii?Q?1smeT/NozvzOlyIH6upSub7wrB+Fk3XfJ8M6PIq67bK5O51lRpt76tIrwhf9?= =?us-ascii?Q?HwmRZGGXZjFyasar+gEfU8PdHTQLhEOBTdYpD3irUKSgWIGifX4qKpbxF5NY?= =?us-ascii?Q?CELmgLWLOIE3nPL0DbNYxZBZ0vAznTDKYG8uQ14w6xtNLbDygydt8E2FftyH?= =?us-ascii?Q?qo3R8Mv5rprkJvbC02l/7zZiuDu8NslmpB/46lyMUmpVxduiica+64+PaSV9?= =?us-ascii?Q?n6fOo6QNam6LKaMGbWjlbDUH/ihEIoSj6EUf/X8iOqO6AaXxUFmIOKo+wy1h?= =?us-ascii?Q?g4L/u+4HcB1SencJRrKMwpsV4yNDjMxqBvFGd19v9ZZ9t7NfXKX/L17KC7X+?= =?us-ascii?Q?D0t+xXRrY+F/siytSvofC5/NXvznWRpkfmNqHLJufvcneMO9zdaYUDTbGeIV?= =?us-ascii?Q?VZv+YFr66uO7jE8W0vW2neQs99Qvm7LIwkvxDwisxB0RvoDSU9U821BklVaX?= =?us-ascii?Q?G2n4Xqx0eP+dUNYG20TNcKtQXAm+yRbFs6hqh1LUnxZjbg2DWl5V5/K/JMzo?= =?us-ascii?Q?RiQAdBjSiyiDNDiSuJMguDVRNiS48MzROut/uDDG0T4t?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34503e34-9289-4d25-0bf8-08db4c47f81e X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 02:33:39.5816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ek3XSwcKVvPnyszyK/n921gRKD60uCNhhkH4L/03OCzCjVjonbHolsWhxFHsz18HWha5u26VEEmNttPPXf/2Em0vpYm2XllSKc/57yZll6AyEaTVJWCwvTspTxmyr6Rw X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6610 Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Abner, =C2=A0Thanks for this point, I will add the "Cc:" to maintainers in commit= =20 message at PATCH V2. Thanks, Minh Nguyen. On 5/4/2023 9:16 AM, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Minh, > You can run Patchcheck (Basetools/Scripts/) before you sending out the pa= tch, Patchcheck can catch the patch format errors. > Please add "Cc:" to maintainers in commit message in each patch and send = the V2 with the subject prefix in the format of "PATCH version", such as "P= ATCH V2". > > For example: > Cc: Michael D Kinney > Cc: Liming Gao > > Thanks > Abner > >> -----Original Message----- >> From: Minh Nguyen >> Sent: Thursday, May 4, 2023 9:58 AM >> To: devel@edk2.groups.io >> Cc: patches@amperecomputing.com; Chang, Abner >> ; nicklew@nvidia.com; igork@ami.com; >> nhi@os.amperecomputing.com; Minh Nguyen >> >> Subject: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> This patchset adds necessary changes for RedfishPkg to avoid some >> unexpected cases and fix compilation. >> >> Changes since v1: >> + Remove redundant change and change the commit message for more >> precise in PATCH 2/5. >> >> Nhi Pham (1): >> RedfishPkg: Add missing newline character >> >> Vu Nguyen (4): >> RedfishPkg: Correct variable type to prevent memory corruption >> RedfishPkg: Fix condition checking of error status >> RedfishPkg: Create RestEx child on selected interface >> RedfishPkg: Fix compile issue on Linux >> >> RedfishPkg/Include/Library/RestExLib.h | 3 + >> RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +- >> RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +- >> RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 +++= +++++---- >> -------- >> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +- >> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +- >> 6 files changed, 73 insertions(+), 98 deletions(-) >> >> -- >> 2.39.0