From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DF4AE74003B for ; Mon, 11 Mar 2024 17:02:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=on5Ot7UrjrWP/F337AZ27ZO0tyaAGsiHK7fSE8rMAuo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710176578; v=1; b=rkvaMzKJC/CqMRDBrlt168YLiqsMctdsHM2LQVM6Zj/thKSC+Qst0WHqWFUYzUf3AW0Mldeq fik3QNwNoG3GtdpYEHwAcEIVAMERYP+M2auyRf+0sOksrWK0RvEgdT2R/znTTEs++NULHZJP17s JyTLxAk2Bw9aD3UhsNrc6DTgHkaUorg2jnLxatwHN3oc0b+36qJmNtMAX2PU25Gw9NSiDzhWVK7 wFVZU8sZ5Dpql4weLhkFl2msAVXvoLPyRtxoCZBWU5CtA1BBWm4K5GghsoqcscG7OVemYuJdEL2 xynD4GCyh+viEw0JZNFcrlccpQX/tuIQHMBBid57rUrHw== X-Received: by 127.0.0.2 with SMTP id Kn4wYY7687511xEixwJ61T6W; Mon, 11 Mar 2024 10:02:58 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.232.1710176577718611070 for ; Mon, 11 Mar 2024 10:02:58 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22FF9FEC; Mon, 11 Mar 2024 10:03:34 -0700 (PDT) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 077533F64C; Mon, 11 Mar 2024 10:02:55 -0700 (PDT) Message-ID: Date: Mon, 11 Mar 2024 10:02:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg To: Leif Lindholm Cc: Ard Biesheuvel , "devel@edk2.groups.io" , "Yao, Jiewen" , Liming Gao , "Kinney, Michael D" , Sami Mujawar , "Liu, Zhiguang" References: <20231121164228.766299-1-quic_llindhol@quicinc.com> <4951c86b-ecd8-4253-95e7-ceb00b8192b9@arm.com> <725dcaa0-8365-46d8-a6fe-f95b1d495518@arm.com> <128c59bc-dd86-4b26-81f7-ecc07f4c72ed@quicinc.com> <58a4fbc9-36a0-4ebd-93a4-0e00fff7d293@quicinc.com> From: "PierreGondois" In-Reply-To: <58a4fbc9-36a0-4ebd-93a4-0e00fff7d293@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zBgnNSpvRYF22saYfimAx0qwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rkvaMzKJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/1/24 12:45, Leif Lindholm wrote: > Thank you. >=20 > OK, that's logically consistent. > So we'd need an ArmLibNull in MdePkg until ArmLib itself migrates there > (ideally subsumed into BaseLib). From what Jiewen said, it doesn't seem that creating an ArmLibNull in the MdePkg is necessary (unless I misunderstood). I will send a follow-up patch to the RFC tomorrow. Along the RFC patch, it should be sufficient to move ArmLib to the MdePkg, Regards, Pierre >=20 > But the dependency in .inf should still be able to be declared under > [LibraryClasses.AArch64, LibraryClasses.ARM]? >=20 > Regards, >=20 > Leif >=20 > On 2024-03-01 01:00, Yao, Jiewen wrote: >> Sure. >> >> When we say "dependency", what we really mean is the dependency in INF f= ile, not "dependency" in DSC file. >> >> From package release perspective, only INF is the interface to other p= ackage. >> The DSC is only the package internal stuff, you can create multiple DSCs= or add/remove DSC freely. >> >> Having "dependency" in DSC does not matter. >> Having dependency in INF is something we should care about. >> >> Thank you >> Yao, Jiewen >> >> >>> -----Original Message----- >>> From: Leif Lindholm >>> Sent: Tuesday, February 13, 2024 1:38 AM >>> To: Pierre Gondois ; devel@edk2.groups.io; Yao, >>> Jiewen >>> Cc: Ard Biesheuvel ; Liming Gao >>> ; Kinney, Michael D ; >>> Sami Mujawar ; Liu, Zhiguang >>> >>> Subject: Re: [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg >>> >>> Jiewen, can you clarify what you said back in >>> https://edk2.groups.io/g/devel/message/111551 >>> ? >>> >>> On 2024-02-12 17:24, Pierre Gondois wrote: >>>>>> A ArmLibNull.inf library might also need to be created. If the >>>>>> OpensslLibFullAccel.inf module will depend on the ArmLib library, >>>>>> a Null implementation will be necessary for non-Arm architectures. >>>>> >>>>> Can ArmLib be declared under a [LibraryClasses.AArch64, >>>>> LibraryClasses.ARM]? Have I forgotten something that we discussed bac= k >>>>> in ... November? >>>> >>>> From [1], it seems the MdePkg/CryptoPkg should build without a depe= ndency >>>> on the ArmPkg. This is currently not really the case. cf. [2]. >>>> >>>> However, having a ArmLibNull implementation in the MdePkg would allow = to >>>> avoid going in this direction when providing libraries to CryptoPkg.ds= c. >>>> >>>> (Just in case, I think this ArmLibNull is a minor point.) >>> >>> Well, sure, it is now. >>> Until we need a RiscV64LibNull, LoongarchLibNull, ... >>> >>>> [1] https://edk2.groups.io/g/devel/message/111545 >>>> [2] >>>> >>> https://github.com/tianocore/edk2/blob/8801c75b4d77c2e6e06b3ddc8560e0db >>> 590f6342/CryptoPkg/CryptoPkg.dsc#L117 >>>> >>>>> >>>>>> Otherwise I could apply and run the CryptoPkg/Arm native instruction= s >>>>>> patchset on top of this patch. >>>>>> >>>>>> --- >>>>>> >>>>>> As a side note, it also seems that: >>>>>> - ArmPkg/Include/Chipset/ArmCortexA5x.h >>>>>> =C2=A0 =C2=A0 isn't used anymore in edk2/edk2-platorms >>>>>> - ArmPkg/Include/Chipset/ArmCortexA9.h >>>>>> =C2=A0 =C2=A0 is barely used in edk2-platforms. >>>>>> Maybe the files should have been removed/simplified as part of >>>>>> - cffa7925a293 ("ArmPkg: remove ArmCpuLib header and implementations= ") >>>>>> - a913ad02479d ("ArmPlatformPkg: remove ArmVExpressPkg") >>>>> >>>>> I think you're right. >>>>> Well, ArmCortexA9.h is still *used*, but I can't imagine the Arm bran= ch >>>>> of ArmVExpressLib has been build by anyone for some time. And surely = the >>>>> inclusion of ArmVExpressLibSec in ArmVExpress-FVP-AArch64.dsc is >>>>> superfluous (such that that .inf can be deleted)? >>>> >>>> The file could just be moved in the Library. I assume you/Sami/Ard >>>> will know more on the usage of the library itself, >>> >>> Sami? >>> >>> / >>> Leif >>> >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116649): https://edk2.groups.io/g/devel/message/116649 Mute This Topic: https://groups.io/mt/102731845/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-