From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"pierre.gondois@arm.com" <pierre.gondois@arm.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation
Date: Wed, 12 Feb 2020 02:07:11 +0000 [thread overview]
Message-ID: <dca3312a1a114dbea50b2126c7065986@intel.com> (raw)
In-Reply-To: <20200210104908.116064-1-pierre.gondois@arm.com>
This patch set is good to me.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: Monday, February 10, 2020 6:49 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Sami.Mujawar@arm.com; pierre.gondois@arm.com; nd@arm.com
Subject: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation
v4:
Remove caret in NASM_INC macro:
I could not reproduce the build fail Bob Feng had when issuing
the following command:
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86
Nonetheless, this v4 should only have an impact on the builds
made on Windows platforms using nmake.
The changes can be seen at https://github.com/PierreARM/edk2/tree/720_BaseTools_Rationalise_makefile_generation_v4
Pierre Gondois (2):
BaseTools: Rationalise makefile generation
BaseTools: Remove caret in NASM_INC macro
BaseTools/Source/Python/AutoGen/GenMake.py | 145 +++++++++++---------
BaseTools/Source/Python/AutoGen/IncludesAutoGen.py | 34 +++-- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 13 +-
BaseTools/Source/Python/build/build.py | 25 ++--
4 files changed, 120 insertions(+), 97 deletions(-)
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2020-02-12 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:49 [PATCH v4 0/2] BaseTools: Rationalise makefile generation PierreGondois
2020-02-10 10:49 ` [PATCH v4 1/2] " PierreGondois
2020-02-10 10:49 ` [PATCH v4 2/2] BaseTools: Remove caret in NASM_INC macro PierreGondois
2020-02-12 2:07 ` Bob Feng [this message]
[not found] ` <15F285876DA55E24.22872@groups.io>
2020-02-12 2:37 ` [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca3312a1a114dbea50b2126c7065986@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox