From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.20833.1581473235241642443 for ; Tue, 11 Feb 2020 18:07:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 18:07:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="251758132" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 11 Feb 2020 18:07:14 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 18:07:13 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 12 Feb 2020 10:07:12 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 12 Feb 2020 10:07:12 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "pierre.gondois@arm.com" CC: "Gao, Liming" , "Sami.Mujawar@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation Thread-Topic: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation Thread-Index: AQHV3//G4V4bVJfBGEGH9xGAG6ft/6gW0ZIg Date: Wed, 12 Feb 2020 02:07:11 +0000 Message-ID: References: <20200210104908.116064-1-pierre.gondois@arm.com> In-Reply-To: <20200210104908.116064-1-pierre.gondois@arm.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFiMGIxMTAtOGM2Zi00YTUxLWIzN2QtMTI1YTYwMzk4M2U4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibjNhek41azlRZytxdXk3NnFxRStIVmhHQ1dPYWxsSWpIZG9JNXkyTjUzZFVnR09HWnR2d1RnbDFqVDN2SlhlRSJ9 dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch set is good to me. Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Monday, February 10, 2020 6:49 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; Feng, Bob C ; Gao, Liming ; Sami.Mujawar@arm.com; pierre.gon= dois@arm.com; nd@arm.com Subject: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile gener= ation v4: Remove caret in NASM_INC macro: I could not reproduce the build fail Bob Feng had when issuing the following command: build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86 Nonetheless, this v4 should only have an impact on the builds made on Windows platforms using nmake. The changes can be seen at https://github.com/PierreARM/edk2/tree/720_Base= Tools_Rationalise_makefile_generation_v4 Pierre Gondois (2): BaseTools: Rationalise makefile generation BaseTools: Remove caret in NASM_INC macro BaseTools/Source/Python/AutoGen/GenMake.py | 145 +++++++++++-----= ---- BaseTools/Source/Python/AutoGen/IncludesAutoGen.py | 34 +++-- BaseTools= /Source/Python/AutoGen/PlatformAutoGen.py | 13 +- BaseTools/Source/Python/build/build.py | 25 ++-- 4 files changed, 120 insertions(+), 97 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'