From: Laszlo Ersek <lersek@redhat.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"Palmer, Thomas" <thomas.palmer@hpe.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
Rebecca Cran <rebecca@bluestop.org>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI call conv spec
Date: Mon, 8 Jan 2018 23:18:58 +0100 [thread overview]
Message-ID: <dca651e1-7732-4759-342f-be84857c4f0e@redhat.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CA3C19506@FMSMSX103.amr.corp.intel.com>
On 01/08/18 22:06, Carsey, Jaben wrote:
> Agree that the internal use is questionable.
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
>> -----Original Message-----
>> From: Palmer, Thomas [mailto:thomas.palmer@hpe.com]
>> Sent: Monday, January 08, 2018 10:07 AM
>> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-
>> devel@lists.01.org>
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
>> <liming.gao@intel.com>; Rebecca Cran <rebecca@bluestop.org>; Ni, Ruiyu
>> <ruiyu.ni@intel.com>
>> Subject: RE: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing
>> EFIAPI call conv spec
>> Importance: High
>>
>> Reviewed by thomas.palmer@hpe.com
>>
>>
>> Regards,
>>
>> Thomas Palmer
Commit 038720e89959.
Thank you both!
Laszlo
prev parent reply other threads:[~2018-01-08 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 20:03 [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI call conv spec Laszlo Ersek
2018-01-08 18:07 ` Palmer, Thomas
2018-01-08 21:06 ` Carsey, Jaben
2018-01-08 22:18 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca651e1-7732-4759-342f-be84857c4f0e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox