From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6F3E82035D315
 for <edk2-devel@lists.01.org>; Mon,  8 Jan 2018 14:13:50 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id A07ECC04AC53;
 Mon,  8 Jan 2018 22:19:00 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-28.rdu2.redhat.com
 [10.10.122.28])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 2898F601B3;
 Mon,  8 Jan 2018 22:18:58 +0000 (UTC)
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
 "Palmer, Thomas" <thomas.palmer@hpe.com>,
 edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>, Rebecca Cran
 <rebecca@bluestop.org>, "Ni, Ruiyu" <ruiyu.ni@intel.com>
References: <20180106200353.18334-1-lersek@redhat.com>
 <TU4PR8401MB1069B8E7601FF17CE11B620BED130@TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM>
 <CB6E33457884FA40993F35157061515CA3C19506@FMSMSX103.amr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <dca651e1-7732-4759-342f-be84857c4f0e@redhat.com>
Date: Mon, 8 Jan 2018 23:18:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CB6E33457884FA40993F35157061515CA3C19506@FMSMSX103.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Mon, 08 Jan 2018 22:19:00 +0000 (UTC)
Subject: Re: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI call conv spec
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 22:13:51 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/08/18 22:06, Carsey, Jaben wrote:
> Agree that the internal use is questionable.
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
>> -----Original Message-----
>> From: Palmer, Thomas [mailto:thomas.palmer@hpe.com]
>> Sent: Monday, January 08, 2018 10:07 AM
>> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-
>> devel@lists.01.org>
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
>> <liming.gao@intel.com>; Rebecca Cran <rebecca@bluestop.org>; Ni, Ruiyu
>> <ruiyu.ni@intel.com>
>> Subject: RE: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing
>> EFIAPI call conv spec
>> Importance: High
>>
>> Reviewed by thomas.palmer@hpe.com
>>
>>
>> Regards,
>>
>> Thomas Palmer

Commit 038720e89959.

Thank you both!
Laszlo