Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi: Create individual Platform Description File

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 4/27/20 4:54 PM, Aditya Angadi wrote:
> Hi Ard,
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
>> Biesheuvel via groups.io
>> Sent: 27 April 2020 16:32
>> To: devel@edk2.groups.io; Aditya Angadi <Aditya.Angadi@arm.com>
>> Cc: Thomas Abraham <thomas.abraham@arm.com>; leif@nuviainc.com;
>> Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>
>> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi:
>> Create individual Platform Description File
>>
>> On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
>>> From: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>>>
>>> In preparation for adding support for Reference Design (RD) platforms
>>> that have different base addresses for GIC distributor or
>>> redistributor, create individual platform description files for all
>>> SGI/RD platforms and move GIC related base addresses from the common
>>> SGI/RD platform description file to individual platform description
>>> files.The existing platform description is then included by individual
>>> platform description files. With this change, the builds for each
>>> supported platform is separate.
>>>
>>> Signed-off-by: Aditya Angadi <aditya.angadi@arm.com>
>>
>> Can you split this up please? There are a lot of different things going on at the
>> same time AFAICT.
>>
> 
> Thanks for your review. I will send the updated patchset tomorrow. I am assuming that so far the comments are for first three patches only. So I will address the comments accordingly and update the patchset.
> 

Please wait until I finish the review of this series.

-- 
Ard.