From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.156.1587999339137950010
 for <devel@edk2.groups.io>;
 Mon, 27 Apr 2020 07:55:39 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA5B131B;
	Mon, 27 Apr 2020 07:55:37 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E58863F68F;
	Mon, 27 Apr 2020 07:55:36 -0700 (PDT)
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi: Create individual Platform Description File
To: Aditya Angadi <Aditya.Angadi@arm.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Thomas Abraham <thomas.abraham@arm.com>,
 "leif@nuviainc.com" <leif@nuviainc.com>,
 Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>
References: <20200414125208.2878-1-aditya.angadi@arm.com>
 <20200414125208.2878-2-aditya.angadi@arm.com>
 <132a8ddf-a0d7-3bf3-8fbd-3b0b4bd4d084@arm.com>
 <AM0PR08MB4499F1901384E76CB6F470EFE1AF0@AM0PR08MB4499.eurprd08.prod.outlook.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <dcaaac16-abd4-a94f-19c3-5ad14d4f4c85@arm.com>
Date: Mon, 27 Apr 2020 16:55:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <AM0PR08MB4499F1901384E76CB6F470EFE1AF0@AM0PR08MB4499.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/27/20 4:54 PM, Aditya Angadi wrote:
> Hi Ard,
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
>> Biesheuvel via groups.io
>> Sent: 27 April 2020 16:32
>> To: devel@edk2.groups.io; Aditya Angadi <Aditya.Angadi@arm.com>
>> Cc: Thomas Abraham <thomas.abraham@arm.com>; leif@nuviainc.com;
>> Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>
>> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi:
>> Create individual Platform Description File
>>
>> On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
>>> From: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>>>
>>> In preparation for adding support for Reference Design (RD) platforms
>>> that have different base addresses for GIC distributor or
>>> redistributor, create individual platform description files for all
>>> SGI/RD platforms and move GIC related base addresses from the common
>>> SGI/RD platform description file to individual platform description
>>> files.The existing platform description is then included by individual
>>> platform description files. With this change, the builds for each
>>> supported platform is separate.
>>>
>>> Signed-off-by: Aditya Angadi <aditya.angadi@arm.com>
>>
>> Can you split this up please? There are a lot of different things going on at the
>> same time AFAICT.
>>
> 
> Thanks for your review. I will send the updated patchset tomorrow. I am assuming that so far the comments are for first three patches only. So I will address the comments accordingly and update the patchset.
> 

Please wait until I finish the review of this series.

-- 
Ard.