From: "Rebecca Cran" <rebecca@nuviainc.com>
To: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 2/2] ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL
Date: Wed, 15 Dec 2021 14:26:45 -0700 [thread overview]
Message-ID: <dcae6eba-d2ab-5ed5-5544-b917beeca56a@nuviainc.com> (raw)
In-Reply-To: <20211215174644.504-3-rebecca@nuviainc.com>
[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]
On 12/15/21 10:46 AM, Rebecca Cran wrote:
> diff --git a/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
> new file mode 100644
> index 000000000000..2275b6cca33a
> --- /dev/null
> +++ b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
> @@ -0,0 +1,53 @@
> +#/** @file
> +#
> +# Component description file for the DxeMpInitLib module.
> +#
> +# Copyright (c) 2021, NUVIA Inc. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +#**/
> +
> +[Defines]
> + INF_VERSION = 1.29
I'm having problems getting the CI Ecc check to pass this file: it keep
saying:
ERROR - EFI coding style error
ERROR - *Error code: 9001
ERROR - *The file headers should follow Doxygen special documentation
blocks in section 2.3.5
ERROR - *file:
D:\a\1\s\Build\.pytool\Plugin\EccCheck\ArmPkg\Library\MpInitLib\DxeMpInitLib.inf
ERROR - *Line number: 1
ERROR - *Header comment section must have Abstract information.
ERROR - --->Test Failed: EccCheck Test NO-TARGET returned 1
I've tried copying other .inf files in the tree: with the style above,
removing the C-style "/**" and "**/" and adding an extra "#" (i.e. "##
@file") without any success.
I've also moved the comment up to line 2 with no success. I was
wondering if anyone could help me come up with a header that can pass CI?
Thanks.
Rebecca Cran
[-- Attachment #2: Type: text/html, Size: 9262 bytes --]
next prev parent reply other threads:[~2021-12-15 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 17:46 [PATCH v2 0/2] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Rebecca Cran
2021-12-15 17:46 ` [PATCH v2 1/2] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct Rebecca Cran
2021-12-15 17:53 ` Ard Biesheuvel
2021-12-15 20:33 ` Rebecca Cran
2021-12-15 17:46 ` [PATCH v2 2/2] ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL Rebecca Cran
2021-12-15 17:55 ` Ard Biesheuvel
2021-12-15 18:15 ` Rebecca Cran
2021-12-15 21:26 ` Rebecca Cran [this message]
[not found] ` <16C10ACB9CD70BF0.6360@groups.io>
2021-12-16 2:45 ` [edk2-devel] " Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcae6eba-d2ab-5ed5-5544-b917beeca56a@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox