From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mx.groups.io with SMTP id smtpd.web11.1640.1639603608534161445 for ; Wed, 15 Dec 2021 13:26:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=EDmGOO5a; spf=pass (domain: nuviainc.com, ip: 209.85.215.175, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f175.google.com with SMTP id l10so10215713pgm.7 for ; Wed, 15 Dec 2021 13:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=6ZG/rsdFC7DkWYBZpEc5vy5tfIYpTnj52h2xUqLG56g=; b=EDmGOO5aoMn7r9o+guF6hqiA+EQ3k5rowL94lobAe5qPxL+CiRlYuSmuUVJhgIxfiT Batapxa1dPR6rAVx+/nOjy3VZ9wKkXwmAExIuJQjRj61x2d4Q0dpioo/W4Xx+I7R2gsu 11xmiCV4ROEg884xvCPMEFOkxzO27X0MteIgeNGjiew9Nv9WOxsLsWHrzsE0niLJ4oP0 +ddmarNc+7Df2qfqXd1KoDiWWhbIBCXbAQKsoA7ZR0S5nNQYwCUB8iyaaGn7VYYOHpKD y5iDpp2jNEckkPOPqHAjkhud2n5y8/v8UMITY0rfmbAxZI1dpVfeyIOf/MdbQU8Ys+KQ hecA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=6ZG/rsdFC7DkWYBZpEc5vy5tfIYpTnj52h2xUqLG56g=; b=EkkA7nIdnqZprXm0V6C/S39oLg4PIDHpKW8ocgOOHnj0hIDPlEMisUeqHrLGtlgYRs 6J5gJneED4+wrF2uPFaOHdbaYneh7eOBICtz9d7kyaBGbEKYOnbqD/Ran1aHJEy/DBFM hqp2tyiOCAd8dZHMP6KqiZs7ytqozXIaShEaupJoUVy7sP/DN/6zCOCfzgdG+x6E6KLq j30zqup9TLBIQztOhWVDj1zg3ScxE9DtgLIiHMZtcP2A5WLH0quKyEfkfbra+9J+3LFq nKGL/iR4O4SZCjJEiuYvNsJWjW0hRMR9r9Liqm+Mti0F1kgDveQeoexp8jQuxn6a+Wq+ gy+g== X-Gm-Message-State: AOAM533f/B7TJFx2YAPJrGTaSojcMhHktga5f/sqVp70Mo66GYY3cVZ3 bqBm2WgENt20ZC9+ctpO7J4x/w== X-Google-Smtp-Source: ABdhPJzgPROwZvIZefqDMdWCtEzG1MAznkEV+du8vKiPJ9Y3O1hORJ6HhcL2ouXi8y3uYfKuMrdg1g== X-Received: by 2002:aa7:9990:0:b0:4a1:57ff:3369 with SMTP id k16-20020aa79990000000b004a157ff3369mr10637609pfh.31.1639603608041; Wed, 15 Dec 2021 13:26:48 -0800 (PST) Return-Path: Received: from ?IPv6:2601:681:4300:69e:9e7b:efff:fe2b:884c? ([2601:681:4300:69e:9e7b:efff:fe2b:884c]) by smtp.gmail.com with ESMTPSA id p15sm3755567pfh.193.2021.12.15.13.26.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 13:26:47 -0800 (PST) Subject: Re: [PATCH v2 2/2] ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL To: devel@edk2.groups.io, Ard Biesheuvel , Gerd Hoffmann , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar References: <20211215174644.504-1-rebecca@nuviainc.com> <20211215174644.504-3-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Wed, 15 Dec 2021 14:26:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211215174644.504-3-rebecca@nuviainc.com> Content-Type: multipart/alternative; boundary="------------20C245F6933B1EF17E843AD2" Content-Language: en-US --------------20C245F6933B1EF17E843AD2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/21 10:46 AM, Rebecca Cran wrote: > diff --git a/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf > new file mode 100644 > index 000000000000..2275b6cca33a > --- /dev/null > +++ b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -0,0 +1,53 @@ > +#/** @file > +# > +# Component description file for the DxeMpInitLib module. > +# > +# Copyright (c) 2021, NUVIA Inc. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +#**/ > + > +[Defines] > + INF_VERSION = 1.29 I'm having problems getting the CI Ecc check to pass this file: it keep saying: ERROR - EFI coding style error ERROR - *Error code: 9001 ERROR - *The file headers should follow Doxygen special documentation blocks in section 2.3.5 ERROR - *file: D:\a\1\s\Build\.pytool\Plugin\EccCheck\ArmPkg\Library\MpInitLib\DxeMpInitLib.inf ERROR - *Line number: 1 ERROR - *Header comment section must have Abstract information. ERROR - --->Test Failed: EccCheck Test NO-TARGET returned 1 I've tried copying other .inf files in the tree: with the style above, removing the C-style "/**" and "**/" and adding an extra "#" (i.e. "## @file") without any success. I've also moved the comment up to line 2 with no success. I was wondering if anyone could help me come up with a header that can pass CI? Thanks. Rebecca Cran --------------20C245F6933B1EF17E843AD2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 12/15/21 10:46 AM, Rebecca Cran wrote: 
diff --git a/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
new file mode 100644
index 000000000000..2275b6cca33a
--- /dev/null
+++ b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
@@ -0,0 +1,53 @@
+#/** @file
+#
+# Component description file for the DxeMpInitLib module.
+#
+# Copyright (c) 2021, NUVIA Inc. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#**/
+
+[Defines]
+  INF_VERSION                    = 1.29

I'm having problems getting the CI Ecc check to pass this file: it keep saying:

ERROR - EFI coding style error
ERROR - *Error code: 9001
ERROR - *The file headers should follow Doxygen special documentation blocks in section 2.3.5
ERROR - *file: D:\a\1\s\Build\.pytool\Plugin\EccCheck\ArmPkg\Library\MpInitLib\DxeMpInitLib.inf
ERROR - *Line number: 1
ERROR - *Header comment section must have Abstract information.

ERROR - --->Test Failed: EccCheck Test NO-TARGET returned 1


I've tried copying other .inf files in the tree: with the style above, removing the C-style "/**" and "**/" and adding an extra "#" (i.e. "## @file") without any success.

I've also moved the comment up to line 2 with no success. I was wondering if anyone could help me come up with a header that can pass CI?


Thanks.
Rebecca Cran

--------------20C245F6933B1EF17E843AD2--