From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.68]) by mx.groups.io with SMTP id smtpd.web12.8738.1633351639330751703 for ; Mon, 04 Oct 2021 05:47:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Uv6ZZpk9; spf=pass (domain: arm.com, ip: 40.107.20.68, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0rkiu3gDBYH2bkJWsngz9KkwPI95GwCYLmPc2gnfgCs=; b=Uv6ZZpk9+IlHi/bzcEBATPxEz6rQ+PzROSoFJ/MFKfi7AcvFWGAacriVwZ7dPAAIxALFpQlk42krxB5u6j57S6h0LrHj8ACnGQrmwJV9+NmjeI+HxJsakj8Y8fW7z6GzHq03vtulzcXzKiwccge/7BIdf2/JAv+hNBffiQrRU+s= Received: from AM6PR0502CA0040.eurprd05.prod.outlook.com (2603:10a6:20b:56::17) by AM0PR08MB3460.eurprd08.prod.outlook.com (2603:10a6:208:de::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 4 Oct 2021 12:47:14 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::8b) by AM6PR0502CA0040.outlook.office365.com (2603:10a6:20b:56::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 12:47:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.33.187.114 as permitted sender) receiver=protection.outlook.com; client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 12:47:14 +0000 Received: ("Tessian outbound c9f4ff96a6ad:v103"); Mon, 04 Oct 2021 12:47:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a8837f0bb8724a45 X-CR-MTA-TID: 64aa7808 Received: from aff51170eb5e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7A12CDAE-7509-4901-B644-71DEE712B213.1; Mon, 04 Oct 2021 12:46:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aff51170eb5e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Oct 2021 12:46:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igtAiw/f0MuraHt9AiYVHBWhqgIqPGIRPizm41R2NHWVJs3HW13xWYLnrwXJ4ODEgyC5mOrDAayB4MvIB30rxNG6ulbJ54LlKSsXb78kqO4ke8rtDFQ/4kJOXe2Gx67MTKABagPMZ/NFTDMA+m+SgC29DQmi//T5Gr7qJBbrK1sJhbFYM5foZCs1o7yP7XtGNU5SoU6dzXxjZaeWWx+bWyPA5gQWEXU/8QUHjwMBVW9PdYURXa9sTZ1wjw43IRhfqlv5KpXZRCoh8QtDEAhcdQ5pgF6N14Br1gAT5n4Dw0b3IOTqU8CGm4/gjX6HdVKy+icrrO+AcB+or0BDV65Y2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0rkiu3gDBYH2bkJWsngz9KkwPI95GwCYLmPc2gnfgCs=; b=eBoaR3Tj4AN4iEMWm+Nl5fYWR3YqnSPVhA3KAYmYZOKZsoJT6qbkuw50+AuW6nx4LsSSGj4ln4MUO2tXc5ejx7FrbxwUun9a8Y/5kHHk57kTHBg6+00/Bc0y0huxrtpsTbd5oZcaqi38bAJvMz5f9IxVF4+SOdy+mrVX7r/kO/v/c9v+hW5ImtyHbJ9LRwH6Cz4E2Nq10rh4ACtyK2TS/RvKQbTgPDuqqSv728nGtEHj7jUt57hOHUJzo20r3XgfPX8lxJUB0ZltefbmQWdQJvaVR6cqfLvRnKiulooik2N6CSEF4vBlVlD2EPdOfOUvEGz87O/zIpO2EUT7FqYS1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0rkiu3gDBYH2bkJWsngz9KkwPI95GwCYLmPc2gnfgCs=; b=Uv6ZZpk9+IlHi/bzcEBATPxEz6rQ+PzROSoFJ/MFKfi7AcvFWGAacriVwZ7dPAAIxALFpQlk42krxB5u6j57S6h0LrHj8ACnGQrmwJV9+NmjeI+HxJsakj8Y8fW7z6GzHq03vtulzcXzKiwccge/7BIdf2/JAv+hNBffiQrRU+s= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6501.eurprd08.prod.outlook.com (2603:10a6:20b:338::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Mon, 4 Oct 2021 12:45:55 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 12:45:55 +0000 Subject: Re: [edk2-platforms][PATCH v3 2/5] Platform/Sgi: dmc-620 firmware-first error handling To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210824060027.27246-1-omkar.kulkarni@arm.com> <20210824060027.27246-3-omkar.kulkarni@arm.com> From: "Sami Mujawar" Message-ID: Date: Mon, 4 Oct 2021 13:45:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210824060027.27246-3-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO2P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::28) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend Transport; Mon, 4 Oct 2021 12:45:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95ef96a4-459e-4b2e-776c-08d98735175a X-MS-TrafficTypeDiagnostic: AS8PR08MB6501:|AM0PR08MB3460: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502;OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dy6lcx2AXXVnMs30tEEyYonF4gSH1gTFuSc3KMr64LAxUoSSY9PJV+vn4CJcFKXfYzBF7F2auIIA/uvxZq5XX62JPt8ppkB1VOtzX3djICQloeQ+4yKpvGD73pRsSEWv8+uwLirKVm2vn4OTkJyjArAuVP6beGTKiIZgQg1LLNpFQMMB3CNTSlE9LhU8ikYXx0N+kvnqF2yEoSgNYnPki026fSxVEeGDekBgtrRLC42hnE9JlIMMfzW1TswiSegD6hGy8EqtXRGe7/s6tY8ISzyjX79p7fntOqsgqqFfZ5LIkzmP5WMdFvwizg6ewleRb7Vs+fazX1NR4BElRgfEriVhOwvVIuki2nmn25E+DnccQLullcwNu4/6iZ190bURR4+hHeL5+HOcwwcA5WYGIGZ0lYew+X7qvSCH93FyEEsDSsAHLM5jcMDcU1IP3ApRch4Vuq01Y9ByJMuvYvkZEs9vjOVHJ2/FVI3bDvO7V1GRWxKRbHlB5MLex60DE0sJia0u74pxdLj81hhsBAco+R0I3h1HV2RxBS0vN0IH2ayTTs+/xSgFEzsEMpeYxIJUFB25FOhoRs3kRgQhksh5YiGBNnPYxzxCTNceLgv3CWZTg4rz6wCM67JcO3GRvLYnmuUyJ9aL1lwh2RENiECfwo5IDooLaRC7q1y2AusBqiPXw/u0jwSB2kKLA6jeC6KY5tqqBQ0HiU825zu6BxTGQjNwY4O3kQ0kfPxaZmkcad7ga9HQewKlkkDK9IDqqZl/9+7vNyskxCItJ69PIAgIrg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(52116002)(31686004)(2616005)(956004)(38100700002)(38350700002)(508600001)(53546011)(86362001)(16576012)(31696002)(26005)(83380400001)(5660300002)(36756003)(66556008)(66946007)(66476007)(19627235002)(316002)(8936002)(4326008)(54906003)(8676002)(6486002)(2906002)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6501 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 02efd906-dd8e-4a9f-df15-08d98734e838 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l/u6wQu929aySK64wwWokyAC7B//A+slmut3d+XNRwQCVSW8MI2AAisWTLl1XAqYfzQZrR3D+IuhStTDoKfbJ1NiUV73lXJTmi2bSfriToCrHEbSxQ2aMQpZvIYuvj0CjtkeA7yCT+EdnVB11LYauU94JKDq9rZ2v3MZ7f1uSgxwSzlz8DMUkawX5YS92941SPZlliRUnPeYjzXfXKHTQaE1tSHNguHcgrXVuPoTO1h4hHrFCHcq8pfLmm22Y2DLewkG3aOEIcSZhJyjMga4dnX+hZK7BoPJai3rkMJfRhOnyjouO1JVTbtv6IhZDV4us2gw9/0JSDgicvfBYQVEUJXAS/ZBp16oceCWyW9ed88aXtVge2KyYnk2MJUWl6SER47qFmI4FiAnZ2yp3YR+kM+iy4Tkti/di+fdJ+ozmJsTIuB31hoU+bnTB2s475kHzv0aEe3Cau5xmRvpLTmMLKO3dQkKvfg/sT+vuwsJd7JVGiQ8dUwZbtpyfZ12t/63m52WIDEpNWIxp7ATQSIfF75ImGia/SNS5lKAt5yNvdurPGqzjnupJRgosi/ay7Q+oAH98iRjf4KYO6ssdKhcheHMsHzDqolGieyxbyMTVMQ9Zdr16uMvoAv/B6cPsj39QL+7kw3dwvlqnzpiabifazGmWXOd2feFKnVlykaSrrlnkh6YpOTcFkrtSpqaYDLO1Q71aLcYGHD/Bku/iXrH3HfDmoiMVpW10D0m7gMtsGU= X-Forefront-Antispam-Report: CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(956004)(6486002)(31696002)(86362001)(508600001)(47076005)(83380400001)(44832011)(336012)(19627235002)(36860700001)(31686004)(2616005)(2906002)(54906003)(186003)(26005)(53546011)(5660300002)(82310400003)(4326008)(81166007)(70206006)(8936002)(36756003)(70586007)(8676002)(316002)(356005)(16576012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 12:47:14.3037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95ef96a4-459e-4b2e-776c-08d98735175a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3460 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Omkar, I have a minor suggestion marked inline as [SAMI]. Other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: > Enable the use of HEST table generation protocol, GHES error source > descriptor protocol and DMC-620 MM driver on ARM Neoverse Reference > Design platforms. This allows firmware-first error handling and > reporting of DMC-620 memory controller's 1-bit DRAM ECC errors. > > Co-authored-by: Thomas Abraham > Signed-off-by: Omkar Anand Kulkarni > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 17 +++++++++++ > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 30 ++++++++++++++++++++ > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 6 ++++ > Platform/ARM/SgiPkg/SgiPlatform.fdf | 6 ++++ > 4 files changed, 59 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > index 7e37732fb93c..bb32584de63d 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -21,6 +21,9 @@ > DEFINE LPI_EN = FALSE > DEFINE CPPC_EN = FALSE > > + # To allow firmware first error handling, set this to TRUE. > + DEFINE ENABLE_GHES_MM = FALSE > + > [BuildOptions] > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > @@ -208,6 +211,12 @@ > gArmTokenSpaceGuid.PcdMmBufferBase|0xFF600000 > gArmTokenSpaceGuid.PcdMmBufferSize|0x10000 > > +!if $(ENABLE_GHES_MM) == TRUE > + ## GHESv2 Generic Error memory space > + gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferBase|0xFF610000 > + gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferSize|0x20000 > +!endif > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -365,3 +374,11 @@ > !else > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > !endif > + > + # > + # GHESv2 HEST error sources support > + # > + MdeModulePkg/Universal/Apei/HestDxe/HestDxe.inf [SAMI] Should HestDxe.inf be included when ENABLE_GHES_MM== TRUE? Same question for SgiPlatform.fdf below. > +!if $(ENABLE_GHES_MM) == TRUE > + ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf > +!endif > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > index 5287e1f8e568..dbba82c74f39 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > @@ -11,6 +11,10 @@ > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > +[Defines] > + # To enable DMC-620 MM driver, set this to TRUE. > + DEFINE ENABLE_DMC620_MM = FALSE > + > [LibraryClasses] > # > # Basic > @@ -94,6 +98,25 @@ > gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|TRUE > !endif > > +!if $(ENABLE_GHES_MM) == TRUE > + ## GHESv2 Generic Error Memory Space > + gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferBase|0xFF610000 > + gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferSize|0x20000 > +!endif > + > +!if $(ENABLE_DMC620_MM) == TRUE > + ## DMC620 > + gDmc620MmTokenSpaceGuid.PcdDmc620NumCtrl|2 > + gDmc620MmTokenSpaceGuid.PcdDmc620RegisterBase|0x4E000000 > + gDmc620MmTokenSpaceGuid.PcdDmc620CtrlSize|0x100000 > + gDmc620MmTokenSpaceGuid.PcdDmc620CorrectableErrorThreshold|10 > + gDmc620MmTokenSpaceGuid.PcdDmc620ErrSourceCount|1 > + gDmc620MmTokenSpaceGuid.PcdDmc620DramErrorSdeiEventBase|804 > + gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorDataBase|0xFF610000 > + gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorDataSize|0x100 > + gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorSourceId|0 > +!endif > + > ################################################################################################### > # > # Components Section - list of the modules and components that will be processed by compilation > @@ -134,6 +157,13 @@ > } > !endif > > +!if $(ENABLE_GHES_MM) == TRUE > + ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf > +!endif > +!if $(ENABLE_DMC620_MM) == TRUE > + Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf > +!endif > + > ################################################################################################### > # > # BuildOptions Section - Define the module specific tool chain flags that should be used as > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > index c1c24b747fa5..e029b9164570 100644 > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > @@ -48,6 +48,12 @@ READ_STATUS = TRUE > READ_LOCK_CAP = TRUE > READ_LOCK_STATUS = TRUE > > +!if $(ENABLE_GHES_MM) == TRUE > + INF ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf > +!endif > +!if $(ENABLE_DMC620_MM) == TRUE > + INF Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf > +!endif > INF StandaloneMmPkg/Core/StandaloneMmCore.inf > !if $(SECURE_STORAGE_ENABLE) == TRUE > INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf > index 8227ae03330c..d6e942e19b81 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > @@ -179,6 +179,12 @@ READ_LOCK_STATUS = TRUE > # MM Communicate > INF ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > + # Hest Error Source Support > + INF MdeModulePkg/Universal/Apei/HestDxe/HestDxe.inf > +!if $(ENABLE_GHES_MM) == TRUE > + INF ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf > +!endif > + > # > # Platform driver > #