From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 16 Sep 2019 07:24:29 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C4E7307BCC4; Mon, 16 Sep 2019 14:24:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-96.rdu2.redhat.com [10.10.124.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id B12171ED; Mon, 16 Sep 2019 14:24:27 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 01/11] OvmfPkg/XenBusDxe: Fix missing \n in DEBUG messages To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Ard Biesheuvel , Julien Grall , Jordan Justen , xen-devel@lists.xenproject.org References: <20190913145100.303433-1-anthony.perard@citrix.com> <20190913145100.303433-2-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 16 Sep 2019 16:24:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190913145100.303433-2-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 16 Sep 2019 14:24:29 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/13/19 16:50, Anthony PERARD wrote: > Fix missing \n in DEBUG messages in XenBusDxe and use DEBUG_*. > > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenBusDxe/EventChannel.c | 3 ++- > OvmfPkg/XenBusDxe/XenStore.c | 6 +++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/XenBusDxe/EventChannel.c b/OvmfPkg/XenBusDxe/EventChannel.c > index 6900071782..c6b3871781 100644 > --- a/OvmfPkg/XenBusDxe/EventChannel.c > +++ b/OvmfPkg/XenBusDxe/EventChannel.c > @@ -44,7 +44,8 @@ XenBusEventChannelAllocate ( > EVTCHNOP_alloc_unbound, > &Parameter); > if (ReturnCode != 0) { > - DEBUG ((EFI_D_ERROR, "ERROR: alloc_unbound failed with rc=%d", ReturnCode)); > + DEBUG ((DEBUG_ERROR, "ERROR: alloc_unbound failed with rc=%d\n", > + ReturnCode)); > return ReturnCode; > } > *Port = Parameter.port; > diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c > index 34890ae40b..7253d8ae37 100644 > --- a/OvmfPkg/XenBusDxe/XenStore.c > +++ b/OvmfPkg/XenBusDxe/XenStore.c > @@ -738,7 +738,7 @@ XenStoreReadReply ( > XENSTORE_STATUS Status; > Status = XenStoreProcessMessage (); > if (Status != XENSTORE_STATUS_SUCCESS && Status != XENSTORE_STATUS_EAGAIN) { > - DEBUG ((EFI_D_ERROR, "XenStore, error while reading the ring (%d).", > + DEBUG ((DEBUG_ERROR, "XenStore, error while reading the ring (%d).\n", > Status)); > return Status; > } > @@ -1076,7 +1076,7 @@ XenStoreDeinit ( > if (!IsListEmpty (&xs.RegisteredWatches)) { > XENSTORE_WATCH *Watch; > LIST_ENTRY *Entry; > - DEBUG ((EFI_D_WARN, "XenStore: RegisteredWatches is not empty, cleaning up...")); > + DEBUG ((DEBUG_WARN, "XenStore: RegisteredWatches is not empty, cleaning up...\n")); > Entry = GetFirstNode (&xs.RegisteredWatches); > while (!IsNull (&xs.RegisteredWatches, Entry)) { > Watch = XENSTORE_WATCH_FROM_LINK (Entry); > @@ -1092,7 +1092,7 @@ XenStoreDeinit ( > // > if (!IsListEmpty (&xs.WatchEvents)) { > LIST_ENTRY *Entry; > - DEBUG ((EFI_D_WARN, "XenStore: WatchEvents is not empty, cleaning up...")); > + DEBUG ((DEBUG_WARN, "XenStore: WatchEvents is not empty, cleaning up...\n")); > Entry = GetFirstNode (&xs.WatchEvents); > while (!IsNull (&xs.WatchEvents, Entry)) { > XENSTORE_MESSAGE *Message = XENSTORE_MESSAGE_FROM_LINK (Entry); > Reviewed-by: Laszlo Ersek