From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.89248.1597847402006956327 for ; Wed, 19 Aug 2020 07:30:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GtZd4sb0; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597847401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5BQvqZtaHJVPTV8X6CfPPedvu42qxaSiQHI2n1adomo=; b=GtZd4sb0POEQC7jDhq+KvKI9C8F3UKTTyHSeaMAapA8GSlaLFbqiSwkF8w8HmbU25bC4PJ c3b1xsPZm9NmmySxewAH5MRPSDsBuQOJG9IlGgyfcj66bvS4W/MqkK7rYkTMmgaTgKe70W 7DzVgyAcVrWU7e0faKDfKQswyz5myk8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-1yFLLfcDPI-TPzpJGw_-yg-1; Wed, 19 Aug 2020 10:29:56 -0400 X-MC-Unique: 1yFLLfcDPI-TPzpJGw_-yg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E55DB1009BA8; Wed, 19 Aug 2020 14:29:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-57.ams2.redhat.com [10.36.114.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05BC95B680; Wed, 19 Aug 2020 14:29:52 +0000 (UTC) Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008 To: "Chang, Abner (HPS SW/FW Technologist)" , Leif Lindholm Cc: "devel@edk2.groups.io" , "liming.gao" , "announce@edk2.groups.io" , "afish@apple.com" , "Kinney, Michael D" References: <877468e5-d154-14fc-b23b-ffa8fd2c9103@redhat.com> <03b3deed-8506-94c3-d14a-eca9198b48a2@redhat.com> <20200819114853.GF17439@vanye> <7fa9c99d-56d1-842e-3fd4-2d3fe649b588@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 19 Aug 2020 16:29:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/19/20 15:34, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, August 19, 2020 9:19 PM >> To: Leif Lindholm ; Chang, Abner (HPS SW/FW >> Technologist) >> Cc: devel@edk2.groups.io; liming.gao ; >> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D >> >> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2- >> stable202008 >> >> On 08/19/20 13:48, Leif Lindholm wrote: >>> (Slightly trimmed recipient list due to different patch being >>> discussed.) >>> >>> So, I can't make this call, because I'm the one who messed up. >>> >>> This patch does exactly what I had requested Abner to do some time >>> back (off-list, unfortunately), and I was *convinced* I gave it an R-b >>> as soon as it hit my inbox - until Abner nudged me about it yesterday. >>> >>> The patch in question is >>> https://edk2.groups.io/g/devel/topic/76021725 >> >> My understanding is: >> >> (1) there is an external project that consumes the FDT library in >> EmbeddedPkg, meaning the lib class header >> "EmbeddedPkg/Include/libfdt.h" >> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf", > [Chang, Abner] Yes >> >> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h", > [Chang, Abner] yes >> >> (3) the external project is not edk2-platforms, > [Chang, Abner] yes >> >> (4) the external project wants -- for some strange reason -- edk2's >> "libfdt_env.h" to provide an strncmp() function (or function-like macro), with >> that particular stncmp() implementation not being needed in either edk2- >> platforms or edk2 itself, > [Chang, Abner] yes, at least so far >> >> (5) the patch for adding said strncmp() was posted on Aug 6th (at least when >> viewed from my time zone), i.e., before the SFF, > [Chang, Abner] Yes >> >> (6) it was reviewed 12 days later (within the SFF) > [Chang, Abner] yes. >> >> If my understanding is correct, then I don't see how this patch could be >> considered a bugfix -- even as a feature addition, it seems hardly justified to >> me --, and there would have been ~8 days before the SFF to review it. >> >> I think we should postpone the patch until after the stable tag. > This patch is important because the edk2-stable202008 would be the stable tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with EFI Runtime service on either real platform and QEMU. We can publish this information in RISC-V community which is considered as a valuable milestone for RISC-V edk2 port. Let's move out the dates for the stable tag then, by one week: - let the SFF start on 2020-08-21 - let the HFF start on 2020-08-28 - let's release edk2-stable202008 on 2020-09-04 Release slips are permitted and there have been examples. What doesn't make sense is making rules and then breaking them opportunistically, whenever they're uncomfortable. If that's a frequent occurrence, we should pick different rules, or -- again -- if this is a very important patch, we should delay the release for it. BTW what about reverting the OpenSBI change? You could still call sbi_strncmp() -- rather than strncmp() -- in the "helper" lib. Thanks Laszlo