From: "Laszlo Ersek" <lersek@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bsdio.com" <rebecca@bsdio.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] Adding Bhyve support into upstream EDK2
Date: Sat, 7 Mar 2020 08:53:00 +0100 [thread overview]
Message-ID: <dcf6724e-6feb-dbed-ae98-edea9f089e06@redhat.com> (raw)
In-Reply-To: <c3e5ac54-9b64-7cee-3813-cf1fdbce9e64@redhat.com>
On 03/07/20 08:39, Laszlo Ersek wrote:
> Hi Jiewen,
>
> On 03/07/20 02:43, Yao, Jiewen wrote:
>> Just saw Laszlo's email. Similar feedback. Especially, I like the regression test part.
>
> Thanks.
>
>> I am not sure how many virtual platforms we will have eventually.
>> If there are more and more, maybe we can create a new edk2-virt-platform repo, and put them together there. (Similar to edk2-platform repo for the physical platform)
>
> Regarding the last part ("move them together here") -- I'm 100% opposed
> to removing OvmfPkg and ArmVirtPkg from edk2. They *must* remain in the
> exact same git repository where the core (MdePkg, MdeModulePkg,
> CryptoPkg, SecurityPkg, UefiCpuPkg, ...) lives too, and share a common
> git history.
>
> ArmVirtPkg and OvmfPkg move very closely together with the core, most
> significant ArmVirtPkg and OvmfPkg contributions need changes (and
> therefore introduce new dependencies) on the core. Managing such
> dependencies is a nightmare evein with git submodules; it only works if
> the git history is shared. This problem is not theoretical, it already
> has a bad effect on edk2-platforms.
>
> [...]
... now I expect this might raise the question why my stance on
consuming submodules in edk2 itself is different -- i.e., why it is that
I *like* edk2 to consume OpenSSL, brotli (TianoCore#2558,
TianoCore#2559), Oniguruma (TianoCore#2073) etc through git submodules.
Here's why: because we mostly treat those projects as black boxes.
- The contributor audiences for those projects hardly overlap with edk2
developers.
- The development workflows sharply differ.
- The rate of change introduced into those projects, for addressing
consumer (i.e., edk2) needs, is very low.
This is very much not the case between edk2, and: ArmVirtPkg and OvmfPkg
(and, again edk2-platforms).
Thanks
Laszlo
prev parent reply other threads:[~2020-03-07 7:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:09 Adding Bhyve support into upstream EDK2 Rebecca Cran
2020-03-06 19:54 ` Laszlo Ersek
2020-03-06 20:04 ` [edk2-devel] " Laszlo Ersek
2020-03-07 1:29 ` Yao, Jiewen
2020-03-24 1:34 ` Rebecca Cran
2020-03-25 0:04 ` Laszlo Ersek
2020-03-25 18:18 ` [EXTERNAL] " Bret Barkelew
2020-03-27 12:56 ` Laszlo Ersek
2020-03-25 18:50 ` Rebecca Cran
[not found] ` <15F9E16A0219E7B7.19404@groups.io>
2020-03-07 1:43 ` Yao, Jiewen
2020-03-07 7:39 ` Laszlo Ersek
2020-03-07 7:52 ` Ard Biesheuvel
2020-03-08 2:40 ` Rebecca Cran
2020-03-09 6:08 ` Sean
2020-03-09 22:54 ` Laszlo Ersek
2020-03-09 23:17 ` Laszlo Ersek
2020-03-10 1:50 ` Sean
2020-03-10 9:05 ` Laszlo Ersek
2020-03-10 17:25 ` Sean
2020-03-10 17:54 ` Ard Biesheuvel
2020-03-10 19:10 ` Sean
2020-03-10 19:23 ` Michael D Kinney
2020-03-10 19:44 ` Sean
2020-03-10 20:04 ` Rebecca Cran
2020-03-11 0:05 ` Laszlo Ersek
2020-03-11 0:30 ` Sean
2020-03-11 3:21 ` Liming Gao
2020-03-10 23:34 ` Laszlo Ersek
2020-03-11 0:43 ` Leif Lindholm
2020-03-07 7:53 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcf6724e-6feb-dbed-ae98-edea9f089e06@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox