Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

["Laszlo Ersek" <lersek@redhat.com>]

On 09/24/19 12:41, Philippe Mathieu-Daudé wrote:
> Hi Liming,
> 
> On 9/24/19 3:19 AM, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> ---
>>  Maintainers.txt | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index f348d70df3..f75b35d5a8 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -82,6 +82,12 @@ EDK II Releases:
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>>  M: Liming Gao <liming.gao@intel.com>
>>  
> 
> Shouldn't you keep the F: tag too? Maybe:
> 
>  ShellPkg
>  (stable)
>  F: ShellPkg/

I think we should keep "F:" only if the related "M:" entries work as
expected, with the "BaseTools/Scripts/GetMaintainer.py" script.

(I haven't checked.)

Thanks
Laszlo

> 
> 
>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> +
>>  EDK II Architectures:
>>  ---------------------
>>  ARM, AARCH64
>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>  M: Ray Ni <ray.ni@intel.com>
>>  M: Zhichao Gao <zhichao.gao@intel.com>
>>  
>> -Maintainers for stable Shell binaries generation
>> -when need to publish Shell binaries with edk2 release:
>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> -
>>  SignedCapsulePkg
>>  F: SignedCapsulePkg/
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>