From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 24 Sep 2019 10:17:28 -0700
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id B76C212E5;
	Tue, 24 Sep 2019 17:17:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-118.rdu2.redhat.com [10.10.120.118])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 167A0600CC;
	Tue, 24 Sep 2019 17:17:20 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 devel@edk2.groups.io, liming.gao@intel.com,
 Leif Lindholm <leif.lindholm@linaro.org>
Cc: Andrew Fish <afish@apple.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <1569287994-7660-1-git-send-email-liming.gao@intel.com>
 <057d571d-2a84-a08d-377f-f2f443219e81@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <dd086c77-ba6f-339f-bc29-f06faa9c8be0@redhat.com>
Date: Tue, 24 Sep 2019 19:17:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <057d571d-2a84-a08d-377f-f2f443219e81@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 24 Sep 2019 17:17:27 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 09/24/19 12:41, Philippe Mathieu-Daud=C3=A9 wrote:
> Hi Liming,
>=20
> On 9/24/19 3:19 AM, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> ---
>>  Maintainers.txt | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index f348d70df3..f75b35d5a8 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -82,6 +82,12 @@ EDK II Releases:
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Relea=
se-Planning
>>  M: Liming Gao <liming.gao@intel.com>
>> =20
>=20
> Shouldn't you keep the F: tag too? Maybe:
>=20
>  ShellPkg
>  (stable)
>  F: ShellPkg/

I think we should keep "F:" only if the related "M:" entries work as
expected, with the "BaseTools/Scripts/GetMaintainer.py" script.

(I haven't checked.)

Thanks
Laszlo

>=20
>=20
>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20X=
XXX/ShellBinPkg.zip
>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> +
>>  EDK II Architectures:
>>  ---------------------
>>  ARM, AARCH64
>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.=
io/wiki/ShellPkg
>>  M: Ray Ni <ray.ni@intel.com>
>>  M: Zhichao Gao <zhichao.gao@intel.com>
>> =20
>> -Maintainers for stable Shell binaries generation
>> -when need to publish Shell binaries with edk2 release:
>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> -
>>  SignedCapsulePkg
>>  F: SignedCapsulePkg/
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsul=
ePkg
>>