From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, chasel.chiu@intel.com
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
Date: Tue, 3 Dec 2019 08:19:56 +0100 [thread overview]
Message-ID: <dd1abf97-082f-f984-4917-6a6150529075@redhat.com> (raw)
In-Reply-To: <20190422101158.18436-1-chasel.chiu@intel.com>
On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
>
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
> coding style issues.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
> extern EFI_GUID gFspHobGuid;
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
> };
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
> }
>
> /**
> - Do FSP initialization in API mode
> + Do FSP initialization in API mode.
>
> @retval EFI_STATUS Always return EFI_SUCCESS
> **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
> }
>
> /**
> - Do FSP initialization in Dispatch mode
> + Do FSP initialization in Dispatch mode.
>
> @retval FSP initialization status.
> **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
> }
>
> /**
> - This is the entrypoint of PEIM
> + This is the entrypoint of PEIM.
>
> @param[in] FileHandle Handle of the file being invoked.
> @param[in] PeiServices Describes the list of possible PEI Services.
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2019-12-03 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 10:11 [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style Chiu, Chasel
2019-04-22 10:17 ` Zeng, Star
2019-12-03 7:19 ` Philippe Mathieu-Daudé [this message]
2019-12-04 0:50 ` [edk2-devel] " Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1abf97-082f-f984-4917-6a6150529075@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox