* [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
@ 2019-04-22 10:11 Chiu, Chasel
2019-04-22 10:17 ` Zeng, Star
2019-12-03 7:19 ` [edk2-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Chiu, Chasel @ 2019-04-22 10:11 UTC (permalink / raw)
To: devel; +Cc: Nate DeSimone, Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
coding style issues.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 9f8ce16023..0f8cd69a0e 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
extern EFI_GUID gFspHobGuid;
/**
- This function handles S3 resume task at the end of PEI
+ This function handles S3 resume task at the end of PEI.
@param[in] PeiServices Pointer to PEI Services Table.
@param[in] NotifyDesc Pointer to the descriptor for the Notification event that
@@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
};
/**
- This function handles S3 resume task at the end of PEI
+ This function handles S3 resume task at the end of PEI.
@param[in] PeiServices Pointer to PEI Services Table.
@param[in] NotifyDesc Pointer to the descriptor for the Notification event that
@@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
}
/**
- Do FSP initialization in API mode
+ Do FSP initialization in API mode.
@retval EFI_STATUS Always return EFI_SUCCESS
**/
@@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
}
/**
- Do FSP initialization in Dispatch mode
+ Do FSP initialization in Dispatch mode.
@retval FSP initialization status.
**/
@@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
}
/**
- This is the entrypoint of PEIM
+ This is the entrypoint of PEIM.
@param[in] FileHandle Handle of the file being invoked.
@param[in] PeiServices Describes the list of possible PEI Services.
--
2.13.3.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
2019-04-22 10:11 [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style Chiu, Chasel
@ 2019-04-22 10:17 ` Zeng, Star
2019-12-03 7:19 ` [edk2-devel] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Zeng, Star @ 2019-04-22 10:17 UTC (permalink / raw)
To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Chiu, Chasel
Sent: Monday, April 22, 2019 6:12 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those coding style issues.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 9f8ce16023..0f8cd69a0e 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
extern EFI_GUID gFspHobGuid;
/**
- This function handles S3 resume task at the end of PEI
+ This function handles S3 resume task at the end of PEI.
@param[in] PeiServices Pointer to PEI Services Table.
@param[in] NotifyDesc Pointer to the descriptor for the Notification event that
@@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = { };
/**
- This function handles S3 resume task at the end of PEI
+ This function handles S3 resume task at the end of PEI.
@param[in] PeiServices Pointer to PEI Services Table.
@param[in] NotifyDesc Pointer to the descriptor for the Notification event that
@@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify ( }
/**
- Do FSP initialization in API mode
+ Do FSP initialization in API mode.
@retval EFI_STATUS Always return EFI_SUCCESS
**/
@@ -370,7 +370,7 @@ FspsWrapperInitApiMode ( }
/**
- Do FSP initialization in Dispatch mode
+ Do FSP initialization in Dispatch mode.
@retval FSP initialization status.
**/
@@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode ( }
/**
- This is the entrypoint of PEIM
+ This is the entrypoint of PEIM.
@param[in] FileHandle Handle of the file being invoked.
@param[in] PeiServices Describes the list of possible PEI Services.
--
2.13.3.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
2019-04-22 10:11 [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style Chiu, Chasel
2019-04-22 10:17 ` Zeng, Star
@ 2019-12-03 7:19 ` Philippe Mathieu-Daudé
2019-12-04 0:50 ` Nate DeSimone
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 7:19 UTC (permalink / raw)
To: devel, chasel.chiu; +Cc: Nate DeSimone, Star Zeng
On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
>
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
> coding style issues.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
> extern EFI_GUID gFspHobGuid;
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
> };
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
> }
>
> /**
> - Do FSP initialization in API mode
> + Do FSP initialization in API mode.
>
> @retval EFI_STATUS Always return EFI_SUCCESS
> **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
> }
>
> /**
> - Do FSP initialization in Dispatch mode
> + Do FSP initialization in Dispatch mode.
>
> @retval FSP initialization status.
> **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
> }
>
> /**
> - This is the entrypoint of PEIM
> + This is the entrypoint of PEIM.
>
> @param[in] FileHandle Handle of the file being invoked.
> @param[in] PeiServices Describes the list of possible PEI Services.
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
2019-12-03 7:19 ` [edk2-devel] " Philippe Mathieu-Daudé
@ 2019-12-04 0:50 ` Nate DeSimone
0 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2019-12-04 0:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel@edk2.groups.io, Chiu, Chasel
Cc: Zeng, Star
Hi Philippe,
FYI, this patch from Chasel was merged 8 months ago:
https://github.com/tianocore/edk2/commit/00e3e4801467dd73b90a151994fc26ba9b5734d7
Thanks,
Nate
-----Original Message-----
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Sent: Monday, December 2, 2019 11:20 PM
To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
>
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those coding style
> issues.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
> extern EFI_GUID gFspHobGuid;
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
> };
>
> /**
> - This function handles S3 resume task at the end of PEI
> + This function handles S3 resume task at the end of PEI.
>
> @param[in] PeiServices Pointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
> }
>
> /**
> - Do FSP initialization in API mode
> + Do FSP initialization in API mode.
>
> @retval EFI_STATUS Always return EFI_SUCCESS
> **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
> }
>
> /**
> - Do FSP initialization in Dispatch mode
> + Do FSP initialization in Dispatch mode.
>
> @retval FSP initialization status.
> **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
> }
>
> /**
> - This is the entrypoint of PEIM
> + This is the entrypoint of PEIM.
>
> @param[in] FileHandle Handle of the file being invoked.
> @param[in] PeiServices Describes the list of possible PEI Services.
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-04 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-22 10:11 [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style Chiu, Chasel
2019-04-22 10:17 ` Zeng, Star
2019-12-03 7:19 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-12-04 0:50 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox