From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.2770.1575357603686109707 for ; Mon, 02 Dec 2019 23:20:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R5s5CEAD; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575357602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ZrwRM3v4Xilbbv+4EbDPrnUS1Qg3ev1ewVeWxzHCt4=; b=R5s5CEADNkMtjDBsysVR7DQDRDawfkrXQ7ktBerVrJwsCQveY9ysfw6JRR6bEaohpvXz4s tJBr9iWsTH/KUiU5OQ5RmaGWKKZOB3S2Xpbl/HFOkgoiGv6yXCwGa4+TKkZ5a5ya+R2Xdv cfzahda1r4JIyJTu64lnL1EkTVZlIzE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-xhN7iprIP8yXfubdX595xA-1; Tue, 03 Dec 2019 02:19:59 -0500 Received: by mail-wm1-f72.google.com with SMTP id v8so552669wml.4 for ; Mon, 02 Dec 2019 23:19:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0ZrwRM3v4Xilbbv+4EbDPrnUS1Qg3ev1ewVeWxzHCt4=; b=uT8NOFgY7Jd38i/n0ZeGrzC3DPf1Esf+MX5B8nEDbtYBiu+TkVkc3yRliRWCyWC+sQ 8HVPfw4k7laPjK8gXlMRX41C87/8MT5S/aWJXXdaQu5A7BJ062k6+tOe/znoDKU5HlML oShyHZaMNkw+wpfR585SxdCrDLGa9YvmE/Me0EAOppROAjwnYuYX1cxVIIyLryw2NY6+ i4aWGKiBknf451W2phafxpOOVArvdJljMjChXIxtaKl27hwfsWDbdMohNCApMr4E3HRn u4f7fJQceFooe+NHvL6FMMI9Dk8IQ8CLkXv9L4XyeTw5J6DOutgGHZggif7MeDGk2Prz DkRA== X-Gm-Message-State: APjAAAXMHmrH8T90lPCSRu2pbq3fC7Xfr/1FFmc3KLVNA4zmnmLzPbxV 6D9Y5+pILz1De4V233LSIf2rD2kBT3sxEhWhPLFcmiV+zl3M7YH4b5JMhSG+p7DcftEsVDKuM6+ jxGsGwvGVjjI1Vw== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr23559821wmb.73.1575357598451; Mon, 02 Dec 2019 23:19:58 -0800 (PST) X-Google-Smtp-Source: APXvYqx8fxbbInCd2OpWJiOud4xZhVJYTZ3xh0AceqOui5uAOIyBU6H4BWqRwVoweYSAkoo0wwWAqg== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr23559801wmb.73.1575357598225; Mon, 02 Dec 2019 23:19:58 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id a6sm1963157wmb.1.2019.12.02.23.19.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2019 23:19:57 -0800 (PST) Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style. To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: Nate DeSimone , Star Zeng References: <20190422101158.18436-1-chasel.chiu@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 3 Dec 2019 08:19:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20190422101158.18436-1-chasel.chiu@intel.com> X-MC-Unique: xhN7iprIP8yXfubdX595xA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 4/22/19 12:11 PM, Chiu, Chasel wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730 > > Internal code quality check failed after this commit: > 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those > coding style issues. > > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > index 9f8ce16023..0f8cd69a0e 100644 > --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc; > extern EFI_GUID gFspHobGuid; > > /** > - This function handles S3 resume task at the end of PEI > + This function handles S3 resume task at the end of PEI. > > @param[in] PeiServices Pointer to PEI Services Table. > @param[in] NotifyDesc Pointer to the descriptor for the Notification event that > @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = { > }; > > /** > - This function handles S3 resume task at the end of PEI > + This function handles S3 resume task at the end of PEI. > > @param[in] PeiServices Pointer to PEI Services Table. > @param[in] NotifyDesc Pointer to the descriptor for the Notification event that > @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify ( > } > > /** > - Do FSP initialization in API mode > + Do FSP initialization in API mode. > > @retval EFI_STATUS Always return EFI_SUCCESS > **/ > @@ -370,7 +370,7 @@ FspsWrapperInitApiMode ( > } > > /** > - Do FSP initialization in Dispatch mode > + Do FSP initialization in Dispatch mode. > > @retval FSP initialization status. > **/ > @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode ( > } > > /** > - This is the entrypoint of PEIM > + This is the entrypoint of PEIM. > > @param[in] FileHandle Handle of the file being invoked. > @param[in] PeiServices Describes the list of possible PEI Services. > Reviewed-by: Philippe Mathieu-Daude